From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id E42221B436 for ; Thu, 2 Aug 2018 08:38:14 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Aug 2018 23:38:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,434,1526367600"; d="scan'208";a="79834446" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga002.jf.intel.com with ESMTP; 01 Aug 2018 23:38:06 -0700 Received: from fmsmsx121.amr.corp.intel.com (10.18.125.36) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 1 Aug 2018 23:38:01 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx121.amr.corp.intel.com (10.18.125.36) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 1 Aug 2018 23:38:01 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.57]) by shsmsx102.ccr.corp.intel.com ([169.254.2.124]) with mapi id 14.03.0319.002; Thu, 2 Aug 2018 14:37:59 +0800 From: "Han, YingyaX" To: "Liu, Yong" , "dts@dpdk.org" CC: "Xia, JuanX" Thread-Topic: [dts] [PATCH V1]tests/shutdown-api: fix the crc-strip issue Thread-Index: AQHUKh4Q44X89wZZs06/o29Fa//f0KSsAYMg Date: Thu, 2 Aug 2018 06:37:59 +0000 Message-ID: <9AC1400278453341942179604C2BF126DE6713@SHSMSX101.ccr.corp.intel.com> References: <1533176303-109061-1-git-send-email-yingyax.han@intel.com> <86228AFD5BCD8E4EBFD2B90117B5E81E63104EF2@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <86228AFD5BCD8E4EBFD2B90117B5E81E63104EF2@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1]tests/shutdown-api: fix the crc-strip issue X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Aug 2018 06:38:15 -0000 Hi Marvin, Ok, I'll change it. Thank you for your advice. Yingya -----Original Message----- From: Liu, Yong=20 Sent: Thursday, August 2, 2018 1:03 PM To: Han, YingyaX ; dts@dpdk.org Cc: Han, YingyaX Subject: RE: [dts] [PATCH V1]tests/shutdown-api: fix the crc-strip issue Hi Yingya, Hex value 0x10000 look wired here, please change the verify message to "CRC= keeping not enabled properly" which will be more meaningful. Thanks, Marvin > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of han,yingya > Sent: Thursday, August 02, 2018 10:18 AM > To: dts@dpdk.org > Cc: Han, YingyaX > Subject: [dts] [PATCH V1]tests/shutdown-api: fix the crc-strip issue >=20 > The "disable-crc-strip" parameter was modified in dpdk 18.08. > The expected value for RX_offloads when crc-strip is off is 0x10000=20 > and when crc-strip is on is 0x1000. > More details can refer to dpdk commit e557ebc0 and DPDK-5829. > Signed-off-by: han,yingya > --- > tests/TestSuite_shutdown_api.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/tests/TestSuite_shutdown_api.py=20 > b/tests/TestSuite_shutdown_api.py index d00c3fb..3cb0eff 100644 > --- a/tests/TestSuite_shutdown_api.py > +++ b/tests/TestSuite_shutdown_api.py > @@ -266,7 +266,7 @@ class TestShutdownApi(TestCase): > self.pmdout.start_testpmd("Default", "--portmask=3D%s --port-=20 > topology=3Dloop --disable-crc-strip" % utils.create_mask(self.ports), > socket=3Dself.ports_socket) > out =3D self.dut.send_expect("show config rxtx", "testpmd> ") > self.verify( > - "Rx offloads=3D0x0" in out, "CRC stripping not disabled prop= erly") > + "Rx offloads=3D0x10000" in out, "CRC stripping not disabled > properly") >=20 > self.dut.send_expect("port stop all", "testpmd> ", 100) > self.dut.send_expect("port config all crc-strip on",=20 > "testpmd> ") > -- > 1.9.3