test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1]tests/runtime_queue_number: fix the problem of sending packets and modprobe vfio-pci
@ 2018-08-22  6:27 han,yingya
  2018-08-22  8:44 ` Tu, Lijuan
  0 siblings, 1 reply; 4+ messages in thread
From: han,yingya @ 2018-08-22  6:27 UTC (permalink / raw)
  To: dts; +Cc: han,yingya

256 exceeded the IP address range.

Signed-off-by: han,yingya <yingyax.han@intel.com>
---
 tests/TestSuite_runtime_queue_number.py | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/tests/TestSuite_runtime_queue_number.py b/tests/TestSuite_runtime_queue_number.py
index 44aec06..7d7bc5b 100644
--- a/tests/TestSuite_runtime_queue_number.py
+++ b/tests/TestSuite_runtime_queue_number.py
@@ -90,6 +90,7 @@ class TestRuntime_Queue_Number(TestCase):
         # assigned number of VFs
         self.dut.generate_sriov_vfs_by_port(self.dut_ports[0], vfs_num, self.drivername)
         self.sriov_vfs_port = self.dut.ports_info[self.dut_ports[0]]['vfs_port']
+        self.dut.send_expect('modprobe vfio-pci', '#')
 
         try:
             for port in self.sriov_vfs_port:
@@ -125,7 +126,7 @@ class TestRuntime_Queue_Number(TestCase):
         """
         self.tester.scapy_foreground()
         time.sleep(2)
-        for i in range(256):
+        for i in range(254):
             packet = r'sendp([Ether(dst="%s", src=get_if_hwaddr("%s"))/IP(src="192.168.0.%d", dst="192.168.0.%d")], iface="%s")' % (
                 self.vf_mac, itf, i + 1, i + 2, itf)
             self.tester.scapy_append(packet)
@@ -160,7 +161,7 @@ class TestRuntime_Queue_Number(TestCase):
                 m = scanner.search(line)
                 packet_rec = m.group(1)
             
-        self.verify(packet_sumnum == int(packet_rec) == 256, "There are some packets lost.")
+        self.verify(packet_sumnum == int(packet_rec) == 254, "There are some packets lost.")
 
     def test_set_valid_vf_max_qn(self):
         """
-- 
1.9.3

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH V1]tests/runtime_queue_number: fix the problem of sending packets and modprobe vfio-pci
  2018-08-22  6:27 [dts] [PATCH V1]tests/runtime_queue_number: fix the problem of sending packets and modprobe vfio-pci han,yingya
@ 2018-08-22  8:44 ` Tu, Lijuan
  2018-08-22  9:04   ` Han, YingyaX
  2018-08-24  6:40   ` Han, YingyaX
  0 siblings, 2 replies; 4+ messages in thread
From: Tu, Lijuan @ 2018-08-22  8:44 UTC (permalink / raw)
  To: Han, YingyaX, dts; +Cc: Han, YingyaX

Comments inline

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of han,yingya
> Sent: Wednesday, August 22, 2018 2:27 PM
> To: dts@dpdk.org
> Cc: Han, YingyaX <yingyax.han@intel.com>
> Subject: [dts] [PATCH V1]tests/runtime_queue_number: fix the problem of
> sending packets and modprobe vfio-pci
> 
> 256 exceeded the IP address range.
> 
> Signed-off-by: han,yingya <yingyax.han@intel.com>
> ---
>  tests/TestSuite_runtime_queue_number.py | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/TestSuite_runtime_queue_number.py
> b/tests/TestSuite_runtime_queue_number.py
> index 44aec06..7d7bc5b 100644
> --- a/tests/TestSuite_runtime_queue_number.py
> +++ b/tests/TestSuite_runtime_queue_number.py
> @@ -90,6 +90,7 @@ class TestRuntime_Queue_Number(TestCase):
>          # assigned number of VFs
>          self.dut.generate_sriov_vfs_by_port(self.dut_ports[0], vfs_num,
> self.drivername)
>          self.sriov_vfs_port =
> self.dut.ports_info[self.dut_ports[0]]['vfs_port']
> +        self.dut.send_expect('modprobe vfio-pci', '#')
[Lijuan] if vf doesn't use vfio, there is no need to insmod vfio-pci
> 
>          try:
>              for port in self.sriov_vfs_port:
> @@ -125,7 +126,7 @@ class TestRuntime_Queue_Number(TestCase):
>          """
>          self.tester.scapy_foreground()
>          time.sleep(2)
> -        for i in range(256):
> +        for i in range(254):
>              packet = r'sendp([Ether(dst="%s",
> src=get_if_hwaddr("%s"))/IP(src="192.168.0.%d", dst="192.168.0.%d")],
> iface="%s")' % (
>                  self.vf_mac, itf, i + 1, i + 2, itf)
>              self.tester.scapy_append(packet) @@ -160,7 +161,7 @@
> class TestRuntime_Queue_Number(TestCase):
>                  m = scanner.search(line)
>                  packet_rec = m.group(1)
> 
> -        self.verify(packet_sumnum == int(packet_rec) == 256, "There are
> some packets lost.")
> +        self.verify(packet_sumnum == int(packet_rec) == 254, "There are
> + some packets lost.")
> 
>      def test_set_valid_vf_max_qn(self):
>          """
> --
> 1.9.3

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH V1]tests/runtime_queue_number: fix the problem of sending packets and modprobe vfio-pci
  2018-08-22  8:44 ` Tu, Lijuan
@ 2018-08-22  9:04   ` Han, YingyaX
  2018-08-24  6:40   ` Han, YingyaX
  1 sibling, 0 replies; 4+ messages in thread
From: Han, YingyaX @ 2018-08-22  9:04 UTC (permalink / raw)
  To: Tu, Lijuan, dts

I'll retest it . Thank you

-----Original Message-----
From: Tu, Lijuan 
Sent: Wednesday, August 22, 2018 4:45 PM
To: Han, YingyaX <yingyax.han@intel.com>; dts@dpdk.org
Cc: Han, YingyaX <yingyax.han@intel.com>
Subject: RE: [dts] [PATCH V1]tests/runtime_queue_number: fix the problem of sending packets and modprobe vfio-pci

Comments inline

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of han,yingya
> Sent: Wednesday, August 22, 2018 2:27 PM
> To: dts@dpdk.org
> Cc: Han, YingyaX <yingyax.han@intel.com>
> Subject: [dts] [PATCH V1]tests/runtime_queue_number: fix the problem 
> of sending packets and modprobe vfio-pci
> 
> 256 exceeded the IP address range.
> 
> Signed-off-by: han,yingya <yingyax.han@intel.com>
> ---
>  tests/TestSuite_runtime_queue_number.py | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/TestSuite_runtime_queue_number.py
> b/tests/TestSuite_runtime_queue_number.py
> index 44aec06..7d7bc5b 100644
> --- a/tests/TestSuite_runtime_queue_number.py
> +++ b/tests/TestSuite_runtime_queue_number.py
> @@ -90,6 +90,7 @@ class TestRuntime_Queue_Number(TestCase):
>          # assigned number of VFs
>          self.dut.generate_sriov_vfs_by_port(self.dut_ports[0], 
> vfs_num,
> self.drivername)
>          self.sriov_vfs_port =
> self.dut.ports_info[self.dut_ports[0]]['vfs_port']
> +        self.dut.send_expect('modprobe vfio-pci', '#')
[Lijuan] if vf doesn't use vfio, there is no need to insmod vfio-pci
> 
>          try:
>              for port in self.sriov_vfs_port:
> @@ -125,7 +126,7 @@ class TestRuntime_Queue_Number(TestCase):
>          """
>          self.tester.scapy_foreground()
>          time.sleep(2)
> -        for i in range(256):
> +        for i in range(254):
>              packet = r'sendp([Ether(dst="%s", 
> src=get_if_hwaddr("%s"))/IP(src="192.168.0.%d", dst="192.168.0.%d")], 
> iface="%s")' % (
>                  self.vf_mac, itf, i + 1, i + 2, itf)
>              self.tester.scapy_append(packet) @@ -160,7 +161,7 @@ 
> class TestRuntime_Queue_Number(TestCase):
>                  m = scanner.search(line)
>                  packet_rec = m.group(1)
> 
> -        self.verify(packet_sumnum == int(packet_rec) == 256, "There are
> some packets lost.")
> +        self.verify(packet_sumnum == int(packet_rec) == 254, "There 
> + are some packets lost.")
> 
>      def test_set_valid_vf_max_qn(self):
>          """
> --
> 1.9.3

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH V1]tests/runtime_queue_number: fix the problem of sending packets and modprobe vfio-pci
  2018-08-22  8:44 ` Tu, Lijuan
  2018-08-22  9:04   ` Han, YingyaX
@ 2018-08-24  6:40   ` Han, YingyaX
  1 sibling, 0 replies; 4+ messages in thread
From: Han, YingyaX @ 2018-08-24  6:40 UTC (permalink / raw)
  To: Tu, Lijuan, dts

It needs to bind vf to vfio-pci. 
This is the following code:

for port in self.sriov_vfs_port:
                port.bind_driver(driver="vfio-pci")

-----Original Message-----
From: Tu, Lijuan 
Sent: Wednesday, August 22, 2018 4:45 PM
To: Han, YingyaX <yingyax.han@intel.com>; dts@dpdk.org
Cc: Han, YingyaX <yingyax.han@intel.com>
Subject: RE: [dts] [PATCH V1]tests/runtime_queue_number: fix the problem of sending packets and modprobe vfio-pci

Comments inline

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of han,yingya
> Sent: Wednesday, August 22, 2018 2:27 PM
> To: dts@dpdk.org
> Cc: Han, YingyaX <yingyax.han@intel.com>
> Subject: [dts] [PATCH V1]tests/runtime_queue_number: fix the problem 
> of sending packets and modprobe vfio-pci
> 
> 256 exceeded the IP address range.
> 
> Signed-off-by: han,yingya <yingyax.han@intel.com>
> ---
>  tests/TestSuite_runtime_queue_number.py | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/TestSuite_runtime_queue_number.py
> b/tests/TestSuite_runtime_queue_number.py
> index 44aec06..7d7bc5b 100644
> --- a/tests/TestSuite_runtime_queue_number.py
> +++ b/tests/TestSuite_runtime_queue_number.py
> @@ -90,6 +90,7 @@ class TestRuntime_Queue_Number(TestCase):
>          # assigned number of VFs
>          self.dut.generate_sriov_vfs_by_port(self.dut_ports[0], 
> vfs_num,
> self.drivername)
>          self.sriov_vfs_port =
> self.dut.ports_info[self.dut_ports[0]]['vfs_port']
> +        self.dut.send_expect('modprobe vfio-pci', '#')
[Lijuan] if vf doesn't use vfio, there is no need to insmod vfio-pci
> 
>          try:
>              for port in self.sriov_vfs_port:
> @@ -125,7 +126,7 @@ class TestRuntime_Queue_Number(TestCase):
>          """
>          self.tester.scapy_foreground()
>          time.sleep(2)
> -        for i in range(256):
> +        for i in range(254):
>              packet = r'sendp([Ether(dst="%s", 
> src=get_if_hwaddr("%s"))/IP(src="192.168.0.%d", dst="192.168.0.%d")], 
> iface="%s")' % (
>                  self.vf_mac, itf, i + 1, i + 2, itf)
>              self.tester.scapy_append(packet) @@ -160,7 +161,7 @@ 
> class TestRuntime_Queue_Number(TestCase):
>                  m = scanner.search(line)
>                  packet_rec = m.group(1)
> 
> -        self.verify(packet_sumnum == int(packet_rec) == 256, "There are
> some packets lost.")
> +        self.verify(packet_sumnum == int(packet_rec) == 254, "There 
> + are some packets lost.")
> 
>      def test_set_valid_vf_max_qn(self):
>          """
> --
> 1.9.3

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-08-24  6:41 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-22  6:27 [dts] [PATCH V1]tests/runtime_queue_number: fix the problem of sending packets and modprobe vfio-pci han,yingya
2018-08-22  8:44 ` Tu, Lijuan
2018-08-22  9:04   ` Han, YingyaX
2018-08-24  6:40   ` Han, YingyaX

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).