test suite reviews and discussions
 help / color / Atom feed
From: "Chen, Zhaoyan" <zhaoyan.chen@intel.com>
To: "Tu, Lijuan" <lijuan.tu@intel.com>,
	"pvukkisala@marvell.com" <pvukkisala@marvell.com>,
	"dts@dpdk.org" <dts@dpdk.org>
Cc: "avijay@marvell.com" <avijay@marvell.com>,
	"fmasood@marvell.com" <fmasood@marvell.com>,
	"Mo, YufengX" <yufengx.mo@intel.com>,
	"Chen, Zhaoyan" <zhaoyan.chen@intel.com>
Subject: Re: [dts] [PATCH] IXIA: Exit on failure of clear/take port ownership
Date: Mon, 12 Aug 2019 07:28:37 +0000
Message-ID: <9DEEADBC57E43F4DA73B571777FECECA41D7D35B@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <8CE3E05A3F976642AAB0F4675D0AD20E0BB018CE@SHSMSX101.ccr.corp.intel.com>

Thanks, Vukkisala,

Good fixing on etgen.py, however, we are going to remove the etgen API in future. 
Because there is a new pktgen API developed in DTS framework, 
which support not only IXIA but also TREX (SW). They have unified packet generator API,
so you need to modify nothing in the test suite, if you change the packet generator in test environment.

So we encourage you to try this new unified API for your performance test suite.
We have several documents for you to migrate from old etgen API under doc folder
- migrate_from_etgen_to_pktgen.rst
- pktgen_prog_guide.rst
- trex_known_issue.rst

Furthermore, your fixing seems also valid for the new pktgen API. Could you please generate 1 more patch for it?

BTW, how many test suite you are using with etgen in DTS? What are they?

Any problem, please let me know. Thanks.


Regards,
Zhaoyan Chen


> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Tu, Lijuan
> Sent: Monday, August 12, 2019 3:00 PM
> To: pvukkisala@marvell.com; dts@dpdk.org
> Cc: avijay@marvell.com; fmasood@marvell.com
> Subject: Re: [dts] [PATCH] IXIA: Exit on failure of clear/take port ownership
> 
> Applied, thanks
> 
> > -----Original Message-----
> > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of
> > pvukkisala@marvell.com
> > Sent: Friday, August 9, 2019 8:51 PM
> > To: dts@dpdk.org
> > Cc: avijay@marvell.com; fmasood@marvell.com; Phanendra Vukkisala
> > <pvukkisala@marvell.com>
> > Subject: [dts] [PATCH] IXIA: Exit on failure of clear/take port
> > ownership
> >
> > From: Phanendra Vukkisala <pvukkisala@marvell.com>
> >
> > Signed-off-by: Phanendra Vukkisala <pvukkisala@marvell.com>
> > ---
> >  framework/etgen.py |    8 ++++++--
> >  1 file changed, 6 insertions(+), 2 deletions(-)
> >
> > diff --git a/framework/etgen.py b/framework/etgen.py index
> > 212b9c2..a47d8cd 100644
> > --- a/framework/etgen.py
> > +++ b/framework/etgen.py
> > @@ -427,10 +427,14 @@ class IxiaPacketGenerator(SSHConnection):
> >          out = self.send_expect("set chasId [ixGetChassisID %s]" %
> > self.tclServerIP, "% ")
> >          self.chasId = int(out.strip())
> >
> > -        self.send_expect("ixClearOwnership [list %s]" % string.join(
> > +        out = self.send_expect("ixClearOwnership [list %s]" %
> > + string.join(
> >              ['[list %d %d %d]' % (self.chasId, item['card'],
> > item['port']) for item in self.ports], ' '), "% ", 10)
> > -        self.send_expect("ixTakeOwnership [list %s] force" % string.join(
> > +        if out.strip()[-1] != '0':
> > +            return False
> > +        out = self.send_expect("ixTakeOwnership [list %s] force" %
> > + string.join(
> >              ['[list %d %d %d]' % (self.chasId, item['card'],
> > item['port']) for item in self.ports], ' '), "% ", 10)
> > +        if out.strip()[-1] != '0':
> > +            return False
> >
> >          return True
> >
> > --
> > 1.7.9.5


  reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-09 12:51 pvukkisala
2019-08-12  6:59 ` Tu, Lijuan
2019-08-12  7:28   ` Chen, Zhaoyan [this message]
2019-08-14 14:20     ` Phanendra Vukkisala

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9DEEADBC57E43F4DA73B571777FECECA41D7D35B@SHSMSX104.ccr.corp.intel.com \
    --to=zhaoyan.chen@intel.com \
    --cc=avijay@marvell.com \
    --cc=dts@dpdk.org \
    --cc=fmasood@marvell.com \
    --cc=lijuan.tu@intel.com \
    --cc=pvukkisala@marvell.com \
    --cc=yufengx.mo@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox