From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A0013A0471 for ; Mon, 12 Aug 2019 09:28:42 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 73AD32629; Mon, 12 Aug 2019 09:28:42 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id B94561252 for ; Mon, 12 Aug 2019 09:28:40 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Aug 2019 00:28:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,376,1559545200"; d="scan'208";a="375142390" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga005.fm.intel.com with ESMTP; 12 Aug 2019 00:28:39 -0700 Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 12 Aug 2019 00:28:39 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.112]) by SHSMSX154.ccr.corp.intel.com ([169.254.7.249]) with mapi id 14.03.0439.000; Mon, 12 Aug 2019 15:28:37 +0800 From: "Chen, Zhaoyan" To: "Tu, Lijuan" , "pvukkisala@marvell.com" , "dts@dpdk.org" CC: "avijay@marvell.com" , "fmasood@marvell.com" , "Mo, YufengX" , "Chen, Zhaoyan" Thread-Topic: [dts] [PATCH] IXIA: Exit on failure of clear/take port ownership Thread-Index: AQHVTrE8kQaICVHalkSvuS8fVyYM5qb2k4OAgACIsVA= Date: Mon, 12 Aug 2019 07:28:37 +0000 Message-ID: <9DEEADBC57E43F4DA73B571777FECECA41D7D35B@SHSMSX104.ccr.corp.intel.com> References: <1565355071-16059-1-git-send-email-pvukkisala@marvell.com> <8CE3E05A3F976642AAB0F4675D0AD20E0BB018CE@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <8CE3E05A3F976642AAB0F4675D0AD20E0BB018CE@SHSMSX101.ccr.corp.intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH] IXIA: Exit on failure of clear/take port ownership X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" Thanks, Vukkisala, Good fixing on etgen.py, however, we are going to remove the etgen API in f= uture.=20 Because there is a new pktgen API developed in DTS framework,=20 which support not only IXIA but also TREX (SW). They have unified packet ge= nerator API, so you need to modify nothing in the test suite, if you change the packet g= enerator in test environment. So we encourage you to try this new unified API for your performance test s= uite. We have several documents for you to migrate from old etgen API under doc f= older - migrate_from_etgen_to_pktgen.rst - pktgen_prog_guide.rst - trex_known_issue.rst Furthermore, your fixing seems also valid for the new pktgen API. Could you= please generate 1 more patch for it? BTW, how many test suite you are using with etgen in DTS? What are they? Any problem, please let me know. Thanks. Regards, Zhaoyan Chen > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Tu, Lijuan > Sent: Monday, August 12, 2019 3:00 PM > To: pvukkisala@marvell.com; dts@dpdk.org > Cc: avijay@marvell.com; fmasood@marvell.com > Subject: Re: [dts] [PATCH] IXIA: Exit on failure of clear/take port owner= ship >=20 > Applied, thanks >=20 > > -----Original Message----- > > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of > > pvukkisala@marvell.com > > Sent: Friday, August 9, 2019 8:51 PM > > To: dts@dpdk.org > > Cc: avijay@marvell.com; fmasood@marvell.com; Phanendra Vukkisala > > > > Subject: [dts] [PATCH] IXIA: Exit on failure of clear/take port > > ownership > > > > From: Phanendra Vukkisala > > > > Signed-off-by: Phanendra Vukkisala > > --- > > framework/etgen.py | 8 ++++++-- > > 1 file changed, 6 insertions(+), 2 deletions(-) > > > > diff --git a/framework/etgen.py b/framework/etgen.py index > > 212b9c2..a47d8cd 100644 > > --- a/framework/etgen.py > > +++ b/framework/etgen.py > > @@ -427,10 +427,14 @@ class IxiaPacketGenerator(SSHConnection): > > out =3D self.send_expect("set chasId [ixGetChassisID %s]" % > > self.tclServerIP, "% ") > > self.chasId =3D int(out.strip()) > > > > - self.send_expect("ixClearOwnership [list %s]" % string.join( > > + out =3D self.send_expect("ixClearOwnership [list %s]" % > > + string.join( > > ['[list %d %d %d]' % (self.chasId, item['card'], > > item['port']) for item in self.ports], ' '), "% ", 10) > > - self.send_expect("ixTakeOwnership [list %s] force" % string.jo= in( > > + if out.strip()[-1] !=3D '0': > > + return False > > + out =3D self.send_expect("ixTakeOwnership [list %s] force" % > > + string.join( > > ['[list %d %d %d]' % (self.chasId, item['card'], > > item['port']) for item in self.ports], ' '), "% ", 10) > > + if out.strip()[-1] !=3D '0': > > + return False > > > > return True > > > > -- > > 1.7.9.5