test suite reviews and discussions
 help / color / mirror / Atom feed
From: Lijuan Tu <lijuan.tu@intel.com>
To: wenjieli <wenjiex.a.li@intel.com>, dts@dpdk.org
Subject: Re: [dts] [PATCH V1] tests/ptype_mapping: align changes with dpdk
Date: Mon, 5 Nov 2018 18:41:17 +0800	[thread overview]
Message-ID: <9cb7b71b-69e4-ce72-6eae-11743746f663@intel.com> (raw)
In-Reply-To: <1541066496-19543-1-git-send-email-wenjiex.a.li@intel.com>

Applied, thanks


On 2018年11月01日 18:01, wenjieli wrote:
> Since dpdk commit 739e13bcc98f56 changes the file app/test-pmd/rxonly.c,
> test cases should be aligned with dpdk. Print "pktype" in
> app/test-pmd/util.c instead of app/test-pmd/rxonly.c.
>
> Signed-off-by: wenjieli <wenjiex.a.li@intel.com>
> ---
>   tests/TestSuite_ptype_mapping.py | 9 +++++----
>   1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/tests/TestSuite_ptype_mapping.py b/tests/TestSuite_ptype_mapping.py
> index 1581887..7838ee7 100644
> --- a/tests/TestSuite_ptype_mapping.py
> +++ b/tests/TestSuite_ptype_mapping.py
> @@ -54,9 +54,10 @@ class TestPtype_Mapping(TestCase):
>           tester_port = self.tester.get_local_port(self.dut_port)
>           self.tester_iface = self.tester.get_interface(tester_port)
>           self.dut.send_expect("sed -i -e '" +\
> -            "/rte_get_ptype_name(mb->packet_type, buf, sizeof(buf));" +\
> -            "/a\\\\t\\t\\tprintf(\" - pktype: 0x%x\", mb->packet_type);'" +\
> -            " app/test-pmd/rxonly.c", "# ", 30, verify = True)
> +            "/printf(\" - VLAN tci=0x%x\", mb->vlan_tci);" +\
> +            "/a\\\\t\\tprintf(\" - pktype: 0x%x\", mb->packet_type);'" +\
> +            " app/test-pmd/util.c", "# ", 30, verify = True)
> +
>           self.dut.build_install_dpdk(self.dut.target)
>           
>   
> @@ -231,7 +232,7 @@ class TestPtype_Mapping(TestCase):
>           Run after each test suite.
>           """
>           self.dut.send_expect("sed -i '/printf(\" - pktype: 0x%x\", " +\
> -            "mb->packet_type);/d' app/test-pmd/rxonly.c", "# ", 30, verify = True)
> +            "mb->packet_type);/d' app/test-pmd/util.c", "# ", 30, verify = True)
>           self.dut.build_install_dpdk(self.dut.target)
>           self.dut.kill_all()
>           pass

  reply	other threads:[~2018-11-05  2:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-01 10:01 wenjieli
2018-11-05 10:41 ` Lijuan Tu [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-10-22  9:31 yaobing

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9cb7b71b-69e4-ce72-6eae-11743746f663@intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=wenjiex.a.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).