From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 61DF2239 for ; Mon, 5 Nov 2018 03:13:25 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Nov 2018 18:13:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,466,1534834800"; d="scan'208";a="105251928" Received: from dts-maintain.sh.intel.com (HELO [10.67.119.110]) ([10.67.119.110]) by fmsmga001.fm.intel.com with ESMTP; 04 Nov 2018 18:13:22 -0800 To: wenjieli , dts@dpdk.org References: <1541066496-19543-1-git-send-email-wenjiex.a.li@intel.com> From: Lijuan Tu Message-ID: <9cb7b71b-69e4-ce72-6eae-11743746f663@intel.com> Date: Mon, 5 Nov 2018 18:41:17 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <1541066496-19543-1-git-send-email-wenjiex.a.li@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Subject: Re: [dts] [PATCH V1] tests/ptype_mapping: align changes with dpdk X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Nov 2018 02:13:25 -0000 Applied, thanks On 2018年11月01日 18:01, wenjieli wrote: > Since dpdk commit 739e13bcc98f56 changes the file app/test-pmd/rxonly.c, > test cases should be aligned with dpdk. Print "pktype" in > app/test-pmd/util.c instead of app/test-pmd/rxonly.c. > > Signed-off-by: wenjieli > --- > tests/TestSuite_ptype_mapping.py | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/tests/TestSuite_ptype_mapping.py b/tests/TestSuite_ptype_mapping.py > index 1581887..7838ee7 100644 > --- a/tests/TestSuite_ptype_mapping.py > +++ b/tests/TestSuite_ptype_mapping.py > @@ -54,9 +54,10 @@ class TestPtype_Mapping(TestCase): > tester_port = self.tester.get_local_port(self.dut_port) > self.tester_iface = self.tester.get_interface(tester_port) > self.dut.send_expect("sed -i -e '" +\ > - "/rte_get_ptype_name(mb->packet_type, buf, sizeof(buf));" +\ > - "/a\\\\t\\t\\tprintf(\" - pktype: 0x%x\", mb->packet_type);'" +\ > - " app/test-pmd/rxonly.c", "# ", 30, verify = True) > + "/printf(\" - VLAN tci=0x%x\", mb->vlan_tci);" +\ > + "/a\\\\t\\tprintf(\" - pktype: 0x%x\", mb->packet_type);'" +\ > + " app/test-pmd/util.c", "# ", 30, verify = True) > + > self.dut.build_install_dpdk(self.dut.target) > > > @@ -231,7 +232,7 @@ class TestPtype_Mapping(TestCase): > Run after each test suite. > """ > self.dut.send_expect("sed -i '/printf(\" - pktype: 0x%x\", " +\ > - "mb->packet_type);/d' app/test-pmd/rxonly.c", "# ", 30, verify = True) > + "mb->packet_type);/d' app/test-pmd/util.c", "# ", 30, verify = True) > self.dut.build_install_dpdk(self.dut.target) > self.dut.kill_all() > pass