From: "Juraj Linkeš" <juraj.linkes@pantheon.tech>
To: "Juraj Linkeš" <juraj.linkes@pantheon.tech>,
"Tu, Lijuan" <lijuan.tu@intel.com>,
"ohilyard@iol.unh.edu" <ohilyard@iol.unh.edu>
Cc: "dts@dpdk.org" <dts@dpdk.org>
Subject: RE: [PATCH v1] framework/pktgen_*: fix pylama errors
Date: Thu, 25 Nov 2021 11:02:51 +0000 [thread overview]
Message-ID: <9deeeb5ba512468ca91063ee2a45ebcd@pantheon.tech> (raw)
In-Reply-To: <37f8eb2cca26402c8f966ada1107f23f@pantheon.tech>
> -----Original Message-----
> From: Juraj Linkeš <juraj.linkes@pantheon.tech>
> Sent: Thursday, November 25, 2021 11:33 AM
> To: Tu, Lijuan <lijuan.tu@intel.com>; ohilyard@iol.unh.edu
> Cc: dts@dpdk.org
> Subject: RE: [PATCH v1] framework/pktgen_*: fix pylama errors
>
>
>
> > -----Original Message-----
> > From: Tu, Lijuan <lijuan.tu@intel.com>
> > Sent: Thursday, November 25, 2021 11:28 AM
> > To: Juraj Linkeš <juraj.linkes@pantheon.tech>; ohilyard@iol.unh.edu
> > Cc: dts@dpdk.org
> > Subject: RE: [PATCH v1] framework/pktgen_*: fix pylama errors
> >
> >
> >
> > > -----Original Message-----
> > > From: Juraj Linkeš <juraj.linkes@pantheon.tech>
> > > Sent: 2021年11月25日 18:25
> > > To: Tu, Lijuan <lijuan.tu@intel.com>; ohilyard@iol.unh.edu
> > > Cc: dts@dpdk.org; Juraj Linkeš <juraj.linkes@pantheon.tech>
> > > Subject: [PATCH v1] framework/pktgen_*: fix pylama errors
> > >
> > > Pylama found the following errors:
> > > framework/pktgen_base.py:108: [E] E1101 Instance of 'PacketGenerator'
> > > has no '_get_gen_port' member [pylint]
> > > framework/pktgen_base.py:148: [E] E1101 Instance of 'PacketGenerator'
> > > has no '_clear_streams' member; maybe 'clear_streams'? [pylint]
> > > framework/pktgen_base.py:173: [E] E1101 Instance of 'PacketGenerator'
> > > has no 'pktgen_type' member [pylint]
> > > framework/pktgen_base.py:279: [E] E1101 Instance of 'PacketGenerator'
> > > has no 'pktgen_type' member [pylint]
> > > framework/pktgen_base.py:479: [E] E1101 Instance of 'PacketGenerator'
> > > has no '_clear_streams' member; maybe 'clear_streams'? [pylint]
> > > framework/pktgen_base.py:528: [E] E0602 Undefined variable
> > > 'last_no_lost_mult' [pylint]
> > > framework/pktgen_base.py:558: [E] E1101 Instance of 'PacketGenerator'
> > > has no 'pktgen_type' member [pylint]
> > > framework/pktgen_base.py:573: [E] E1101 Instance of 'PacketGenerator'
> > > has no '_clear_streams' member; maybe 'clear_streams'? [pylint]
> > > framework/pktgen_base.py:607: [E] E1101 Instance of 'PacketGenerator'
> > > has no '_clear_streams' member; maybe 'clear_streams'? [pylint]
> > > framework/pktgen_base.py:673: [E] E1101 Instance of 'PacketGenerator'
> > > has no 'pktgen_type' member [pylint]
> > > framework/pktgen_base.py:677: [E] E1101 Instance of 'PacketGenerator'
> > > has no 'pktgen_type' member [pylint]
> > > framework/pktgen_base.py:69: [E] E1101 Instance of 'PacketGenerator'
> > > has no '_prepare_generator' member; maybe 'prepare_generator'?
> > > [pylint]
> > > framework/pktgen_base.py:77: [E] E1101 Instance of 'PacketGenerator'
> > > has no '_get_port_pci' member [pylint]
> > > framework/pktgen_ixia.py:1085: [E] E1306 Not enough arguments for
> > > format string [pylint]
> > > framework/pktgen_trex.py:194: [E] E0602 Undefined variable 'Ether'
> > > [pylint]
> > > framework/pktgen_trex.py:195: [E] E0602 Undefined variable 'IP'
> > > [pylint]
> > >
> > > Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
> > > ---
> > > Lijuan, please add additional people to review if needed.
> >
> > Hi Juraj,
> >
> > Can I know your plan for fixing pylama errors.
>
> The plan is to fix them, not sure how much more there is to it. I'm just going
> through the errors in the various file where Pylama reports them and sending
> patches. Sometimes it makes sense to submit fixes in multiple related files,
> sometimes I'm fixing the error one file at a time.
Let me know if there's something better we can do. I want to go through everything except testsuites, at least until I know that all of the deprecated testcases have been removed.
prev parent reply other threads:[~2021-11-25 11:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-25 10:24 Juraj Linkeš
2021-11-25 10:27 ` Tu, Lijuan
2021-11-25 10:33 ` Juraj Linkeš
2021-11-25 11:02 ` Juraj Linkeš [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9deeeb5ba512468ca91063ee2a45ebcd@pantheon.tech \
--to=juraj.linkes@pantheon.tech \
--cc=dts@dpdk.org \
--cc=lijuan.tu@intel.com \
--cc=ohilyard@iol.unh.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).