test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Wang, FeiX Y" <feix.y.wang@intel.com>
To: "pmacarth@iol.unh.edu" <pmacarth@iol.unh.edu>,
	"dts@dpdk.org" <dts@dpdk.org>
Subject: Re: [dts] [PATCH for-next 6/6] tests/TestSuite_nic_single_core_perf:	Fix test case name
Date: Mon, 5 Mar 2018 09:25:39 +0000	[thread overview]
Message-ID: <A527267237D7C74DAC8B4819E4DDAD2302D788F1@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <188971FCDA171749BED5DA74ABF3E6F03C123A39@SHSMSX104.ccr.corp.intel.com>

HI, Patrick

There is no need  to configure nic_single_core_perf with perf prefix, because if we did, DTS will enable Ixia as external traffic generator (enable TREX for perf test has not been implemented by DTS framework so far). So we walk around this by configuring the test as a func test.

Thanks

Fei

-----Original Message-----
From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Patrick MacArthur
Sent: Wednesday, February 21, 2018 1:26 AM
To: dts@dpdk.org
Cc: pmacarth@iol.unh.edu; dpdklab@iol.unh.edu
Subject: [dts] [PATCH for-next 6/6] tests/TestSuite_nic_single_core_perf: Fix test case name

The test framework will only run performance tests that start with test_perf_. Fix the name so that the nic_single_core_perf test is run.

Tested-by: Ali Alnubani <alialnu@mellanox.com>
Signed-off-by: Patrick MacArthur <pmacarth@iol.unh.edu>
---
 tests/TestSuite_nic_single_core_perf.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/TestSuite_nic_single_core_perf.py b/tests/TestSuite_nic_single_core_perf.py
index bff763c129fa..2a0934742623 100644
--- a/tests/TestSuite_nic_single_core_perf.py
+++ b/tests/TestSuite_nic_single_core_perf.py
@@ -97,7 +97,7 @@ class TestNicSingleCorePerf(TestCase):
         else:
             raise Exception("Not required NIC")
 
-    def test_nic_single_core_perf(self):
+    def test_perf_nic_single_core_perf(self):
         """
         Run nic single core performance 
         """
--
2.14.1

  parent reply	other threads:[~2018-03-05  9:25 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-20 17:26 [dts] [PATCH for-next 0/6] Fixes and modifications for T-Rex integration and nic_single_core_perf Patrick MacArthur
2018-02-20 17:26 ` [dts] [PATCH for-next 1/6] framework/texttable: Update to latest upstream version Patrick MacArthur
2018-02-20 17:26 ` [dts] [PATCH for-next 2/6] framework: Do not attempt ping6 on T-Rex ports Patrick MacArthur
2018-02-20 17:26 ` [dts] [PATCH for-next 3/6] tests/TestSuite_nic_single_core_perf: Fix config parsing Patrick MacArthur
2018-02-20 17:26 ` [dts] [PATCH for-next 4/6] tests/TestSuite_nic_single_core_perf: Use user-specified output dir Patrick MacArthur
2018-02-20 17:26 ` [dts] [PATCH for-next 5/6] framework/pktgen: Start T-Rex during prepare_generator() Patrick MacArthur
2018-03-02  1:51   ` Liu, Yong
2018-02-20 17:26 ` [dts] [PATCH for-next 6/6] tests/TestSuite_nic_single_core_perf: Fix test case name Patrick MacArthur
     [not found]   ` <188971FCDA171749BED5DA74ABF3E6F03C123A39@SHSMSX104.ccr.corp.intel.com>
2018-03-05  9:25     ` Wang, FeiX Y [this message]
     [not found] ` <188971FCDA171749BED5DA74ABF3E6F03C1239F0@SHSMSX104.ccr.corp.intel.com>
2018-03-05  9:16   ` [dts] [PATCH for-next 0/6] Fixes and modifications for T-Rex integration and nic_single_core_perf Wang, FeiX Y
2018-03-20 22:25     ` Patrick MacArthur
2018-03-21  7:28       ` Wang, FeiX Y
2018-03-23  9:03       ` Wang, FeiX Y

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=A527267237D7C74DAC8B4819E4DDAD2302D788F1@shsmsx102.ccr.corp.intel.com \
    --to=feix.y.wang@intel.com \
    --cc=dts@dpdk.org \
    --cc=pmacarth@iol.unh.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).