From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0051.outbound.protection.outlook.com [104.47.1.51]) by dpdk.org (Postfix) with ESMTP id 0F75F2A66 for ; Mon, 12 Mar 2018 03:26:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=C41AOdG0vBKtXqx82LWDe1U311gTj53XLuvKH4iYoO4=; b=O+Z7obGTlXYj92695bKEahlzM1pyTMzeJjxho/Zsowp1mg/6gcGwZzB6G7lmQraXkBhzJtz7fM/6VqaA4TWW7Lz28vZESJ4rz43rfy1j49gmgEnAJaEvNqo8D7d8plCClg4D2Itu+Sl8JqTjEZn2888ggkZBlK+Hba3yMxF79R4= Received: from AM2PR08MB0178.eurprd08.prod.outlook.com (10.161.130.155) by AM2PR08MB0436.eurprd08.prod.outlook.com (10.163.148.153) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.548.13; Mon, 12 Mar 2018 02:26:22 +0000 Received: from AM2PR08MB0178.eurprd08.prod.outlook.com ([fe80::9c4e:9348:e886:dade]) by AM2PR08MB0178.eurprd08.prod.outlook.com ([fe80::9c4e:9348:e886:dade%13]) with mapi id 15.20.0567.018; Mon, 12 Mar 2018 02:26:22 +0000 From: Joyce Kong To: "Liu, Yong" , "dts@dpdk.org" Thread-Topic: [dts] [PATCH 1/2] tests/vf_packet_rxtx: fix test case failures in vf_reset Thread-Index: AdO3mhJVIcWFrM9hQHKVkOJTOaUQ8ACB/KKgAAFoc+A= Date: Mon, 12 Mar 2018 02:26:22 +0000 Message-ID: References: <86228AFD5BCD8E4EBFD2B90117B5E81E62FBD7E2@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <86228AFD5BCD8E4EBFD2B90117B5E81E62FBD7E2@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Joyce.Kong@arm.com; x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM2PR08MB0436; 7:VhGuAZiTayGHtlQv3bZq7+dgnJwRe6AD1VOtA8kH6AGJu6VID8sEahqqxeILMXkOwfsZj6h1LPEJLalas6i80OD67ZndTzayhwc4G6Onebq/5+nkts+nSf2/1Zf40ufoqp3hc3Kw/SKfwM/SVspokVRsifcbJn/e1e+fP1uraW9UrFNG+zcG0FuUwmwXS1Lej59V+M5eomq4ts6HzNfdoF2t7LFslJWGomPNfRGlsVF92zKvvfQBIlwZvpd57Ygr x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: c44b379f-22e0-4377-ff55-08d587c0a5b8 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:AM2PR08MB0436; x-ms-traffictypediagnostic: AM2PR08MB0436: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(10201501046)(3231220)(944501244)(52105095)(6055026)(6041310)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123560045)(20161123558120)(6072148)(201708071742011); SRVR:AM2PR08MB0436; BCL:0; PCL:0; RULEID:; SRVR:AM2PR08MB0436; x-forefront-prvs: 06098A2863 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(396003)(366004)(39380400002)(376002)(39850400004)(40434004)(13464003)(199004)(189003)(2501003)(2906002)(186003)(8676002)(59450400001)(5660300001)(26005)(25786009)(72206003)(53546011)(6506007)(6246003)(7696005)(105586002)(316002)(81156014)(81166006)(86362001)(5250100002)(102836004)(55236004)(8936002)(5890100001)(110136005)(3280700002)(6116002)(6436002)(68736007)(76176011)(2950100002)(66066001)(55016002)(99286004)(74316002)(53936002)(33656002)(106356001)(97736004)(9686003)(229853002)(7736002)(305945005)(478600001)(3846002)(3660700001)(2900100001)(14454004); DIR:OUT; SFP:1101; SCL:1; SRVR:AM2PR08MB0436; H:AM2PR08MB0178.eurprd08.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: vVw6dQBwW4TQq559O52Ju4SgEIHwnC2Zl8HaY2g/R92F7WjFbQ1ddhaS3+jogYpV/fbWdxOp19z1UhcUJuThIzc8XBw9dsyUO1n9O8yf4vveI4CedEyYfPW5GanssHLsWStxQkQ9i5xlh5pRrLeyIahaxbu0l/eNtUkELVXeXR2mznTeI84NAIeVtOBGuFg0LUGuCT5/m3UFmkn/Cs1F5hiMV4C02wDkMy7iLRDFuWqw0whxf8tj6HJ2ln+TjXcPhAd6jXsNN1d46S1WqZVnYH/WEKVoZn9tCRD6d5/R5S0LSUXHuGAtnwEaFIW2HS6Efcg3Yb2UjibMsmkVDGEJJw== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: c44b379f-22e0-4377-ff55-08d587c0a5b8 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Mar 2018 02:26:22.5222 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM2PR08MB0436 Subject: Re: [dts] [PATCH 1/2] tests/vf_packet_rxtx: fix test case failures in vf_reset X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Mar 2018 02:26:25 -0000 Hi Marvin, Clearing port stats is valid on most occasions and we can't always ensure t= o disable all network-manager on PF. Overall there's no harm in doing this. Thanks & regards=1B$B!$=1B(B Joyce -----Original Message----- From: Liu, Yong [mailto:yong.liu@intel.com] Sent: Monday, March 12, 2018 9:39 AM To: Joyce Kong ; dts@dpdk.org Subject: RE: [dts] [PATCH 1/2] tests/vf_packet_rxtx: fix test case failures= in vf_reset Joyce, There's still some kind of possibility that PF will transmit packets in the= test which will cause unexpected result. It's better to disable network-manager on the PF device. But if this soluti= on is workable for you, I can also merge it. Thanks, Marvin > -----Original Message----- > From: Joyce Kong [mailto:Joyce.Kong@arm.com] > Sent: Friday, March 09, 2018 7:39 PM > To: Liu, Yong ; dts@dpdk.org > Subject: RE: [dts] [PATCH 1/2] tests/vf_packet_rxtx: fix test case > failures in vf_reset > > Hi Marvin, > > DUT PF would send dhcp protocol packet to VF before tester > transmission, and that's why we need to clear ports at the start. > > Best Regards=1B$B!$=1B(B > Joyce > > -----Original Message----- > From: Liu, Yong [mailto:yong.liu@intel.com] > Sent: Thursday, March 8, 2018 11:37 AM > To: Joyce Kong ; dts@dpdk.org > Cc: Zhao, MeijuanX > Subject: RE: [dts] [PATCH 1/2] tests/vf_packet_rxtx: fix test case > failures in vf_reset > > Hi Joyce, > Could you please figure out why need to clean the counter before > tester transmission? It should be no packet sent to VF before that moment= . > > Thanks, > Marvin > > > -----Original Message----- > > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Joyce Kong > > Sent: Tuesday, March 06, 2018 3:47 PM > > To: dts@dpdk.org > > Cc: Joyce Kong > > Subject: [dts] [PATCH 1/2] tests/vf_packet_rxtx: fix test case > > failures in vf_reset > > > > Clear port stats before counting port info > > > > Signed-off-by: Joyce Kong > > --- > > tests/TestSuite_vf_packet_rxtx.py | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/tests/TestSuite_vf_packet_rxtx.py > > b/tests/TestSuite_vf_packet_rxtx.py > > index 63f4820..6a29d23 100644 > > --- a/tests/TestSuite_vf_packet_rxtx.py > > +++ b/tests/TestSuite_vf_packet_rxtx.py > > @@ -279,6 +279,7 @@ class TestVfPacketRxtx(TestCase): > > rx_port =3D tx_port > > > > dst_mac =3D pmd0_vf0_mac > > + self.vm0_testpmd.execute_cmd('clear port stats all') > > self.tester.sendpkt_bg(tx_port, dst_mac) > > > > #vf port stop/start can trigger reset action > > -- > > 1.8.3.1 > > IMPORTANT NOTICE: The contents of this email and any attachments are > confidential and may also be privileged. If you are not the intended > recipient, please notify the sender immediately and do not disclose > the contents to any other person, use it for any purpose, or store or > copy the information in any medium. Thank you. IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.