From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50078.outbound.protection.outlook.com [40.107.5.78]) by dpdk.org (Postfix) with ESMTP id 07AE62BDF for ; Wed, 28 Mar 2018 08:34:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=0SXn5gpNtx3ZydyYm0+QRfKbyEhDJBdBNn8XatNbpRA=; b=BXnbUg+R9RsjtPY8fnUTQ1j9y/wk3c5ym801vdDHL08NNI8Vcy3uJseVfsCiusmcopoLhqbmc9ygPQ6hpNY0n3bN0IEmnizMvgi7S1gsoICHSN6Wpsy8NZqejjxFqvtB+9hVPRKp3WneUvHSKMaH7lkAikvlRsTb+SDH7ua/WZw= Received: from AM4PR08MB0913.eurprd08.prod.outlook.com (10.166.133.135) by AM4PR08MB1203.eurprd08.prod.outlook.com (10.167.92.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.631.10; Wed, 28 Mar 2018 06:34:00 +0000 Received: from AM4PR08MB0913.eurprd08.prod.outlook.com ([fe80::3418:15f6:2cf7:e5ef]) by AM4PR08MB0913.eurprd08.prod.outlook.com ([fe80::3418:15f6:2cf7:e5ef%3]) with mapi id 15.20.0609.012; Wed, 28 Mar 2018 06:34:00 +0000 From: Phil Yang To: "Liu, Yong" , "dts@dpdk.org" CC: nd , Herbert Guan Thread-Topic: [PATCH 01/17] framwork/packet: Add sniff_packet specify running Thread-Index: AQHTwn2UYevtu5s2FkaYy5PMVJXdIaPk94KAgAAJrAA= Date: Wed, 28 Mar 2018 06:34:00 +0000 Message-ID: References: <1521792246-4950-1-git-send-email-phil.yang@arm.com> <86228AFD5BCD8E4EBFD2B90117B5E81E62FCC680@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <86228AFD5BCD8E4EBFD2B90117B5E81E62FCC680@SHSMSX103.ccr.corp.intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Phil.Yang@arm.com; x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM4PR08MB1203; 7:1W/prYUhnqRIoiNmlzc/SQ8acUInTDBjyVnB2rDvtG4Qofkma9EFMu6kW2pGgGAhbzLbszguleoBKT1S7jVIYcVmYbCqHfd1iSu6G+dUNnCsqSCRpXEVz/FXkfgf41yp18hQN/ZtopTQwFg0gy2z10yzXsqmyNDo4bhh2+jIfn/mzgwA7QUsELwtdthV+Fy8d0v+fcvkLFpp1v27igElizPEqzBFRTw4hS6XpSfC4ZhblsAdycW7YKQ4tFGcTqie x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: d73db265-163c-43bd-9801-08d59475e463 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:AM4PR08MB1203; x-ms-traffictypediagnostic: AM4PR08MB1203: nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917)(21532816269658)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(10201501046)(3231221)(944501327)(52105095)(6055026)(6041310)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:AM4PR08MB1203; BCL:0; PCL:0; RULEID:; SRVR:AM4PR08MB1203; x-forefront-prvs: 06259BA5A2 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(396003)(376002)(346002)(39860400002)(39380400002)(199004)(189003)(13464003)(4326008)(72206003)(561944003)(3280700002)(53936002)(551544002)(446003)(5250100002)(68736007)(76176011)(11346002)(486005)(476003)(9686003)(6506007)(2501003)(2900100001)(53546011)(486005)(99286004)(25786009)(33656002)(316002)(59450400001)(6436002)(97736004)(55236004)(6246003)(26005)(8676002)(110136005)(14454004)(106356001)(6116002)(229853002)(186003)(66066001)(105586002)(8936002)(102836004)(55016002)(86362001)(478600001)(5660300001)(2906002)(81166006)(81156014)(7696005)(3660700001)(74316002)(7736002)(54906003)(305945005)(3846002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR08MB1203; H:AM4PR08MB0913.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: HPdeY3lj29ZPY2sNJnVOCICS5R7k61iJpG4lGeYg6cCva7hCkJQ1Sc7Tmfkp0+dTOZJ5qvEOU8C9ixRKHEmMEz1Ch74ZF66HswHVrC1DOZI1YVBgWU1zSF/yk8U9C04/aafACK7liTiZUdIJv6cycC2eAFyQq4neIM5J6sqfwg75xkVSsKP3+cftTiwAqbG+pZqFbcfGbhEHV7BIrDhdLxWkIWqacu+haaAM6LqFDmwBBUKhJHmaU0/HrEiOPOj9gh2svXmD0axgtGWdKc/Q2uwwU/DQxHWgTI/zzJ64otnF6YBXZpQSb5vDcIEFgUJjFUKkh8ID+sJtTLTpuqTfEg== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: d73db265-163c-43bd-9801-08d59475e463 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Mar 2018 06:34:00.6141 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR08MB1203 Subject: Re: [dts] [PATCH 01/17] framwork/packet: Add sniff_packet specify running X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Mar 2018 06:34:02 -0000 Hi Marvin, > -----Original Message----- > From: Liu, Yong > Sent: Wednesday, March 28, 2018 10:41 AM > To: Phil Yang ; dts@dpdk.org > Cc: nd ; Herbert Guan > Subject: RE: [PATCH 01/17] framwork/packet: Add sniff_packet specify runn= ing >=20 > Hi Phil, > In previous design, DTS will be run on tester for simple design and stabi= lity. > In our site, I can't see the benefit of change the design. Could you plea= se explain > why you change it? > Anyway we can change the design, but I think it will need some kind of di= agnosis > about the impact. > There may be some other staff depend on the assumption that DTS is on the > tester machine. We are trying to use one machine as the controller to run DTS. The controll= er communicate with testers which listed in the crbs.cfg by SSH connection. So the DTS will not running on tester.=20 Since testers are connected with DUTs port by port, so I think introduce co= ntroller into the DTS is more flexible to manager machines. If other staff = depend on the assumption that DTS is no the tester machine, sniff_packet pr= ocess will also connect to the tester by SSH connection. Just one more SSH = connection. However, we cannot make sure the DTS is always running on the tester.=20 >=20 > Just for this patch. In load function, DTS machine should transmit tester= 's pcap > file first and then analyze packets. You are correct. Thanks to point out. If my proposal is acceptable, I will resend the version 2 to add the transm= it process. Thanks. >=20 > Regards, > Marvin >=20 > > -----Original Message----- > > From: Phil Yang [mailto:phil.yang@arm.com] > > Sent: Friday, March 23, 2018 4:04 PM > > To: dts@dpdk.org > > Cc: nd@arm.com; phil.yang@arm.com; Liu, Yong ; > > herbert.guan@arm.com > > Subject: [PATCH 01/17] framwork/packet: Add sniff_packet specify > > running > > > > If tester in crb file was not the machine which running dts, the > > sniff_packet process will not running on tester. > > > > Create a ssh connection to the tester and run tcpdump to make sure > > sniff_packet process running on the machine we expected. > > > > Signed-off-by: Phil Yang > > --- > > framework/packet.py | 34 ++++++++++++++++++++++++++++------ > > framework/tester.py | 34 ++++++++++++++++++++++++++++++++++ > > 2 files changed, 62 insertions(+), 6 deletions(-) > > > > diff --git a/framework/packet.py b/framework/packet.py index > > 976b82b..484e511 100755 > > --- a/framework/packet.py > > +++ b/framework/packet.py > > @@ -812,15 +812,30 @@ def get_filter_cmd(filters=3D[]): > > return "" > > > > > > -def sniff_packets(intf, count=3D0, timeout=3D5, filters=3D[]): > > +def sniff_packets(intf, count=3D0, timeout=3D5, filters=3D[], target= =3D[]): > > """ > > sniff all packets for certain port in certain seconds > > """ > > param =3D "" > > direct_param =3D r"(\s+)\[ (\S+) in\|out\|inout \]" > > - tcpdump_help =3D subprocess.check_output("tcpdump -h; echo 0", > > - stderr=3Dsubprocess.STDOUT, > > - shell=3DTrue) > > + > > + # target[] contain the remote machine info for ssh connection > > + # target[0]: username > > + # target[1]: ip address > > + # target[2]: pass word > > + if target: > > + tcpdump_help_pipe =3D subprocess.Popen(["ssh", > > + "%s@%s" % (target[0], target[1]), > > + "tcpdump -h"], > > + stderr=3Dsubprocess.PIPE, > > + stdout=3Dsubprocess.PIPE, > > + shell=3DFalse) > > + tcpdump_help =3D "".join(tuple(tcpdump_help_pipe.communicate()= )) > > + tcpdump_help_pipe.wait() > > + else: > > + tcpdump_help =3D subprocess.check_output("tcpdump -h; echo 0", > > + stderr=3Dsubprocess.STDOUT, > > + shell=3DTrue) > > + > > for line in tcpdump_help.split('\n'): > > m =3D re.match(direct_param, line) > > if m: > > @@ -850,9 +865,16 @@ def sniff_packets(intf, count=3D0, timeout=3D5, > > filters=3D[]): > > else: > > cmd =3D sniff_cmd % options > > > > - args =3D shlex.split(cmd) > > + if target: > > + pipe =3D subprocess.Popen(["ssh", > > + "%s@%s" % (target[0], target[1]), > > + cmd], > > + stdin=3Dsubprocess.PIPE, > > + shell=3DFalse) > > + else: > > + args =3D shlex.split(cmd) > > + pipe =3D subprocess.Popen(args) > > > > - pipe =3D subprocess.Popen(args) > > index =3D str(time.time()) > > SNIFF_PIDS[index] =3D (pipe, intf, timeout) > > time.sleep(1) > > diff --git a/framework/tester.py b/framework/tester.py index > > a775f68..49749de 100755 > > --- a/framework/tester.py > > +++ b/framework/tester.py > > @@ -704,6 +704,40 @@ class Tester(Crb): > > self.proc.kill() > > self.proc =3D None > > > > + def tcpdump_sniff_packets(self, intf, count=3D0, timeout=3D5, filt= ers=3D[]): > > + """ > > + Wrapper for packet module sniff_packets > > + """ > > + # load functions in packet module > > + module =3D __import__("packet") > > + sniff_f =3D getattr(module, "sniff_packets") > > + > > + target=3D[] > > + target.append(self.get_username()) > > + target.append(self.get_ip_address()) > > + target.append(self.get_password()) > > + return sniff_f(intf, count, timeout, filters, target) > > + > > + def load_tcpdump_sniff_pcap(self, index=3D''): > > + """ > > + Wrapper for packet module load_sniff_pcap > > + """ > > + # load functions in packet module > > + module =3D __import__("packet") > > + load_pcap_f =3D getattr(module, "load_sniff_pcap") > > + > > + return load_pcap_f(index) > > + > > + def load_tcpdump_sniff_packets(self, index=3D''): > > + """ > > + Wrapper for packet module load_sniff_packets > > + """ > > + # load functions in packet module > > + module =3D __import__("packet") > > + load_f =3D getattr(module, "load_sniff_packets") > > + > > + return load_f(index) > > + > > def kill_all(self, killall=3DFalse): > > """ > > Kill all scapy process or DPDK application on tester. > > -- > > 2.7.4