test suite reviews and discussions
 help / color / mirror / Atom feed
From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
To: David Marchand <david.marchand@redhat.com>,
	"Ling, WeiX" <weix.ling@intel.com>
Cc: "dts@dpdk.org" <dts@dpdk.org>, "Tu, Lijuan" <lijuan.tu@intel.com>,
	"thomas@monjalon.net" <thomas@monjalon.net>,
	"Mcnamara, John" <john.mcnamara@intel.com>, nd <nd@arm.com>
Subject: RE: [dts][PATCH V4 3/3] tests/dpdk_gro_lib_cbdma: add dpdk_gro_lib_cbdma testsuite
Date: Wed, 18 May 2022 15:25:48 +0000
Message-ID: <AM8PR08MB58105E4CDDAA67BFAAAF02C798D19@AM8PR08MB5810.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <CAJFAV8yVq5R==vDJMR7gSbLVDSNE5MkbE+e6b0hbyLXoE1CaqQ@mail.gmail.com>

<snip>
> 
> On Wed, May 18, 2022 at 11:36 AM Ling, WeiX <weix.ling@intel.com> wrote:
> > > >
> > > > Add new testsuite tests/TestSuite_dpdk_gro_lib_cbdma.py.
> > > >
> > > > Signed-off-by: Wei Ling <weix.ling@intel.com>
> > >
> > > I commented on v1.
> > > v4 is the same.
> > >
> > > NAK.
> >
> > Because we also need to modify DPDK code to test this suite before the
> > DPDK patch merged into the DPDK.
> 
> The existing code must be cleaned and Intel should stop adding more
> technical debt stuff to dts.
> 
> I can see the patch already got merged, so it seems my point was not
> understood by the dts maintainer.
On one end we are trying to fix all the dpdk code changes done by DTS and here we are adding more to the list. I will bring this topic up in the next DTS WG meeting.

> This patch should be reverted.
+1, please revert and come up with alternatives. If you need additional API in DPDK or additional support in testpmd, I highly encourage people to discuss with the DPDK community.

> 
> 
> --
> David Marchand


  reply	other threads:[~2022-05-18 15:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-10  3:01 Wei Ling
2022-05-10  7:04 ` David Marchand
2022-05-18  9:36   ` Ling, WeiX
2022-05-18 13:39     ` David Marchand
2022-05-18 15:25       ` Honnappa Nagarahalli [this message]
2022-05-11  1:33 ` He, Xingguang
2022-05-11  7:47 ` Huang, ChenyuX
2022-05-18 11:03 ` lijuan.tu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM8PR08MB58105E4CDDAA67BFAAAF02C798D19@AM8PR08MB5810.eurprd08.prod.outlook.com \
    --to=honnappa.nagarahalli@arm.com \
    --cc=david.marchand@redhat.com \
    --cc=dts@dpdk.org \
    --cc=john.mcnamara@intel.com \
    --cc=lijuan.tu@intel.com \
    --cc=nd@arm.com \
    --cc=thomas@monjalon.net \
    --cc=weix.ling@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

test suite reviews and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git