test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Mo, YufengX" <yufengx.mo@intel.com>
To: Thinh Tran <thinhtr@linux.vnet.ibm.com>, "dts@dpdk.org" <dts@dpdk.org>
Subject: Re: [dts] [PATCH] tests/unit_tests_timer increase timeout
Date: Fri, 19 Jul 2019 08:49:30 +0000	[thread overview]
Message-ID: <B8B15C44A3F2C044966E545C7B7371153E81A8B5@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <20190718183903.1596-1-thinhtr@linux.vnet.ibm.com>

Missing `self` in using this_timeout.

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Thinh Tran
> Sent: Friday, July 19, 2019 2:39 AM
> To: dts@dpdk.org
> Cc: thinhtr@linux.vnet.ibm.com
> Subject: [dts] [PATCH] tests/unit_tests_timer increase timeout
> 
> 
> - fix the TIMEOUT Failure for some systems have more than 16 cores
> 
> 
> Signed-off-by: Thinh Tran <thinhtr@linux.vnet.ibm.com>
> ---
>  tests/TestSuite_unit_tests_timer.py | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/TestSuite_unit_tests_timer.py b/tests/TestSuite_unit_tests_timer.py
> index 717dab8..f3bb02d 100644
> --- a/tests/TestSuite_unit_tests_timer.py
> +++ b/tests/TestSuite_unit_tests_timer.py
> @@ -59,6 +59,13 @@ class TestUnitTestsTimer(TestCase):
>          """
>          cores = self.dut.get_core_list("all")
>          self.coremask = utils.create_mask(cores)
> +        #
> +        # change timeout base number of cores on the system
> +        # default 60 secs
> +        #
> +        self.this_timeout = 60
> +        if (len(cores) > 16) :
> +            self.this_timeout = self.this_timeout * len(cores)/16
> 
>      def set_up(self):
>          """
> @@ -71,7 +78,7 @@ class TestUnitTestsTimer(TestCase):
>          Run timer autotest.
>          """
>          self.dut.send_expect("./%s/app/test -n 1 -c %s" % (self.target, self.coremask), "R.*T.*E.*>.*>", 60)
> -        out = self.dut.send_expect("timer_autotest", "RTE>>", 60)
> +        out = self.dut.send_expect("timer_autotest", "RTE>>", this_timeout)
>          self.dut.send_expect("quit", "# ")
>          self.verify("Test OK" in out, "Test failed")
> 
> @@ -80,7 +87,7 @@ class TestUnitTestsTimer(TestCase):
>          Run timer autotest.
>          """
>          self.dut.send_expect("./%s/app/test -n 1 -c %s" % (self.target, self.coremask), "R.*T.*E.*>.*>", 60)
> -        out = self.dut.send_expect("timer_perf_autotest", "RTE>>", 60)
> +        out = self.dut.send_expect("timer_perf_autotest", "RTE>>", this_timeout)
>          self.dut.send_expect("quit", "# ")
>          self.verify("Test OK" in out, "Test failed")
> 
> --
> 2.17.1


  reply	other threads:[~2019-07-19  8:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-18 18:39 Thinh Tran
2019-07-19  8:49 ` Mo, YufengX [this message]
2019-07-19 12:59   ` [dts] [PATCH v2] " Thinh Tran
2019-07-22  2:01     ` Mo, YufengX
2019-07-22 12:18       ` Thinh Tran
2019-07-22 13:15       ` [dts] [PATCH V3] " Thinh Tran
2019-07-23  3:05         ` Mo, YufengX
2019-08-06  9:51         ` Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B8B15C44A3F2C044966E545C7B7371153E81A8B5@shsmsx102.ccr.corp.intel.com \
    --to=yufengx.mo@intel.com \
    --cc=dts@dpdk.org \
    --cc=thinhtr@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).