test suite reviews and discussions
 help / color / Atom feed
* Re: [dts] [PATCH V1] tests/nvgre:Modify the syntax error.
  2019-08-13  2:46 [dts] [PATCH V1] tests/nvgre:Modify the syntax error zhu,shuai
@ 2019-08-13  2:45 ` Zhu, WenhuiX
  2019-08-13  4:48 ` Mo, YufengX
  1 sibling, 0 replies; 3+ messages in thread
From: Zhu, WenhuiX @ 2019-08-13  2:45 UTC (permalink / raw)
  To: Zhu, ShuaiX, dts

Tested-by: Zhu, WenhuiX <wenhuix.zhu@intel.com>

-----Original Message-----
From: Zhu, ShuaiX 
Sent: Tuesday, August 13, 2019 10:46 AM
To: dts@dpdk.org
Cc: Zhu, WenhuiX <wenhuix.zhu@intel.com>; Zhu, ShuaiX <shuaix.zhu@intel.com>
Subject: [dts][PATCH V1] tests/nvgre:Modify the syntax error.

Modify the syntax error.

Signed-off-by: zhu,shuai <shuaix.zhu@intel.com>
---
 tests/TestSuite_nvgre.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/TestSuite_nvgre.py b/tests/TestSuite_nvgre.py index 62aac3a..dbba011 100644
--- a/tests/TestSuite_nvgre.py
+++ b/tests/TestSuite_nvgre.py
@@ -162,7 +162,7 @@ class NvgreTestConfig(object):
         """
         Return nvgre packet type
         """
-        if (self.nic in ["cavium_a063", "cavium_a064"]):
+        if (nic in ["cavium_a063", "cavium_a064"]):
             if self.outer_ip_proto !=47:
                 if self.outer_l3_type == 'IPv4':
                     return 'L3_IPV4'
--
2.17.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [dts] [PATCH V1] tests/nvgre:Modify the syntax error.
@ 2019-08-13  2:46 zhu,shuai
  2019-08-13  2:45 ` Zhu, WenhuiX
  2019-08-13  4:48 ` Mo, YufengX
  0 siblings, 2 replies; 3+ messages in thread
From: zhu,shuai @ 2019-08-13  2:46 UTC (permalink / raw)
  To: dts; +Cc: wenhuix.zhu, zhu,shuai

Modify the syntax error.

Signed-off-by: zhu,shuai <shuaix.zhu@intel.com>
---
 tests/TestSuite_nvgre.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/TestSuite_nvgre.py b/tests/TestSuite_nvgre.py
index 62aac3a..dbba011 100644
--- a/tests/TestSuite_nvgre.py
+++ b/tests/TestSuite_nvgre.py
@@ -162,7 +162,7 @@ class NvgreTestConfig(object):
         """
         Return nvgre packet type
         """
-        if (self.nic in ["cavium_a063", "cavium_a064"]):
+        if (nic in ["cavium_a063", "cavium_a064"]):
             if self.outer_ip_proto !=47:
                 if self.outer_l3_type == 'IPv4':
                     return 'L3_IPV4'
-- 
2.17.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1] tests/nvgre:Modify the syntax error.
  2019-08-13  2:46 [dts] [PATCH V1] tests/nvgre:Modify the syntax error zhu,shuai
  2019-08-13  2:45 ` Zhu, WenhuiX
@ 2019-08-13  4:48 ` Mo, YufengX
  1 sibling, 0 replies; 3+ messages in thread
From: Mo, YufengX @ 2019-08-13  4:48 UTC (permalink / raw)
  To: Zhu, ShuaiX, dts; +Cc: Zhu, WenhuiX, Zhu, ShuaiX

`If ( )` is a C language usage habit, Could you remove it?


> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhu,shuai
> Sent: Tuesday, August 13, 2019 10:46 AM
> To: dts@dpdk.org
> Cc: Zhu, WenhuiX <wenhuix.zhu@intel.com>; Zhu, ShuaiX <shuaix.zhu@intel.com>
> Subject: [dts] [PATCH V1] tests/nvgre:Modify the syntax error.
> 
> Modify the syntax error.
> 
> Signed-off-by: zhu,shuai <shuaix.zhu@intel.com>
> ---
>  tests/TestSuite_nvgre.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_nvgre.py b/tests/TestSuite_nvgre.py
> index 62aac3a..dbba011 100644
> --- a/tests/TestSuite_nvgre.py
> +++ b/tests/TestSuite_nvgre.py
> @@ -162,7 +162,7 @@ class NvgreTestConfig(object):
>          """
>          Return nvgre packet type
>          """
> -        if (self.nic in ["cavium_a063", "cavium_a064"]):
> +        if (nic in ["cavium_a063", "cavium_a064"]):
>              if self.outer_ip_proto !=47:
>                  if self.outer_l3_type == 'IPv4':
>                      return 'L3_IPV4'
> --
> 2.17.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-13  2:46 [dts] [PATCH V1] tests/nvgre:Modify the syntax error zhu,shuai
2019-08-13  2:45 ` Zhu, WenhuiX
2019-08-13  4:48 ` Mo, YufengX

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox