test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Mo, YufengX" <yufengx.mo@intel.com>
To: "Yao, BingX Y" <bingx.y.yao@intel.com>
Cc: "Yao, BingX Y" <bingx.y.yao@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Subject: Re: [dts] [PATCH V1] tests/ip_pipeline:add case	pipeline_with_traffic_management
Date: Tue, 10 Sep 2019 01:25:12 +0000	[thread overview]
Message-ID: <B8B15C44A3F2C044966E545C7B7371153E8470FB@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1567763055-14243-1-git-send-email-bingx.y.yao@intel.com>

Hi, yao,bing

*. Your test case will fail when run with below command. It is caused by your hard code of dpdk directory.
   mv /root/dpdk /root/dpdk2
   ./dts -d /root/dpdk2 -t test_perf_pipeline_with_traffic_management
*. Your vm config step value is larger than range, range should be multiple of step. Your config has no sense.



> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of yaobing
> Sent: Friday, September 6, 2019 5:44 PM
> To: dts@dpdk.org
> Cc: Yao, BingX Y <bingx.y.yao@intel.com>
> Subject: [dts] [PATCH V1] tests/ip_pipeline:add case pipeline_with_traffic_management
> 
> add case test_perf_pipeline_with_traffic_management
> 
> Signed-off-by: yaobing <bingx.y.yao@intel.com>
> ---
>  tests/TestSuite_ip_pipeline.py | 60 ++++++++++++++++++++++++++++++++++
>  1 file changed, 60 insertions(+)
> 
> diff --git a/tests/TestSuite_ip_pipeline.py b/tests/TestSuite_ip_pipeline.py
> index f05b5cd..6aa6aed 100644
> --- a/tests/TestSuite_ip_pipeline.py
> +++ b/tests/TestSuite_ip_pipeline.py
> @@ -61,6 +61,7 @@ from scapy.packet import bind_layers, Raw
>  from scapy.arch import get_if_hwaddr
>  from scapy.sendrecv import sniff
>  from scapy.sendrecv import sendp
> +from pktgen import PacketGeneratorHelper
> 
>  class TestIPPipeline(TestCase):
> 
> @@ -224,6 +225,15 @@ class TestIPPipeline(TestCase):
>          self.verify("Error" not in out, "Compilation error")
> 
>          self.param_flow_dir = self.get_flow_direction_param_of_tcpdump()
> +        # get dts output path
> +        if self.logger.log_path.startswith(os.sep):
> +            self.output_path = self.logger.log_path
> +        else:
> +            cur_path = os.path.dirname(
> +                                os.path.dirname(os.path.realpath(__file__)))
> +            self.output_path = os.sep.join([cur_path, self.logger.log_path])
> +        # create an instance to set stream field setting
> +        self.pktgen_helper = PacketGeneratorHelper()
> 
>      def set_up(self):
>          """
> @@ -231,6 +241,56 @@ class TestIPPipeline(TestCase):
>          """
>          pass
> 
> +    def set_fields(self):
> +        """
> +        set ip protocol field behavior
> +        """
> +        fields_config = {
> +            'ip': {
> +                'dst': {'range':4096, 'step': 65025, 'action': 'inc'}}, }
> +        return fields_config
> +
> +    def copy_cli_files_to_dut(self):
> +        """
> +        Copy traffic_manager.cli from tester to DUT
> +        """
> +        tar_file = 'ip_pipeline.tar.gz'
> +        src_file = r'./dep/%s' % tar_file
> +        dst = '/root/dpdk/examples/ip_pipeline/examples/'
> +        self.dut.session.copy_file_to(src_file, dst)
> +        self.dut.send_expect("tar -xvf %s/%s" % (dst,tar_file), "#", 30)
> +        self.dut.send_expect("cp ./ip_pipeline/traffic_manager.cli %s" % dst, "#", 30)
> +
> +    def test_perf_pipeline_with_traffic_management(self):
> +        """
> +        rss pipeline
> +        """
> +        self.copy_cli_files_to_dut()
> +        cmd = "sed -i -e 's/0000:07:00.0/%s/' ./examples/ip_pipeline/examples/traffic_manager.cli" % self.dut_p0_pci
> +        self.dut.send_expect(cmd, "# ", 20)
> +        IP_PIPELINE = "./examples/ip_pipeline/build/ip_pipeline"
> +        DUT_PORTS = " -w {0}".format(self.dut_p0_pci)
> +        SCRIPT_FILE = "./examples/ip_pipeline/examples/traffic_manager.cli"
> +        cmd = "{0} -c 0x3 -n 4 {1} -- -s {2}".format(IP_PIPELINE, DUT_PORTS, SCRIPT_FILE)
> +        out = self.dut.send_expect(cmd,"15.255.0.0",60)
> +        self.verify("failed" not in out, "Create rule failed!")
> +        pcap = os.sep.join([self.output_path, "test.pcap"])
> +        dmac = self.dut.get_mac_address(self.dut_ports[0])
> +        flow = 'Ether(dst="%s")/IP(src="192.168.0.2",dst="0.0.0.0")' % (dmac)
> +        self.tester.scapy_append('wrpcap("%s", [%s])' % (pcap, flow))
> +        self.tester.scapy_execute()
> +        tgenInput = []
> +        port = self.tester.get_local_port(self.dut_ports[0])
> +        tgenInput.append([port, port, pcap])
> +        vm_config = self.set_fields()
> +        self.tester.pktgen.clear_streams()
> +        streams = self.pktgen_helper.prepare_stream_from_tginput(tgenInput, 100, vm_config, self.tester.pktgen)
> +        _, pps = self.tester.pktgen.measure_throughput(stream_ids=streams)
> +        self.dut.send_expect("^C","#",20)
> +        strandard_pps =14880000 / 4096
> +        difference_value = pps - strandard_pps
> +        self.verify( -50 < difference_value < 50, "throughput validation failure")
> +
>      def test_routing_pipeline(self):
>          """
>          routing pipeline
> --
> 2.17.2


      reply	other threads:[~2019-09-10  1:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-06  9:44 yaobing
2019-09-10  1:25 ` Mo, YufengX [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B8B15C44A3F2C044966E545C7B7371153E8470FB@shsmsx102.ccr.corp.intel.com \
    --to=yufengx.mo@intel.com \
    --cc=bingx.y.yao@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).