test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Mo, YufengX" <yufengx.mo@intel.com>
To: "dts@dpdk.org" <dts@dpdk.org>,
	"Li, WenjieX A" <wenjiex.a.li@intel.com>,
	"Chen, Zhaoyan" <zhaoyan.chen@intel.com>,
	"Tu, Lijuan" <lijuan.tu@intel.com>
Subject: Re: [dts] [PATCH V2 2/7] framework/dut: fix logger quit issue
Date: Mon, 23 Sep 2019 06:58:18 +0000	[thread overview]
Message-ID: <B8B15C44A3F2C044966E545C7B7371153E84BAAE@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <20190923065040.8251-3-yufengx.mo@intel.com>

Tested by Mo, YufengX <yufengx.mo@intel.com>



> -----Original Message-----
> From: Mo, YufengX
> Sent: Monday, September 23, 2019 2:51 PM
> To: dts@dpdk.org; Li, WenjieX A <wenjiex.a.li@intel.com>; Chen, Zhaoyan <zhaoyan.chen@intel.com>; Tu, Lijuan <lijuan.tu@intel.com>
> Cc: Mo, YufengX <yufengx.mo@intel.com>
> Subject: [dts][PATCH V2 2/7] framework/dut: fix logger quit issue
> 
> 
> *. move dut logger close after session close for logger used by session.
> *. fix typo.
> 
> Signed-off-by: yufengmx <yufengx.mo@intel.com>
> ---
>  framework/dut.py | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/framework/dut.py b/framework/dut.py
> index 1779d3a..a394b34 100644
> --- a/framework/dut.py
> +++ b/framework/dut.py
> @@ -208,7 +208,7 @@ class Dut(Crb):
>          self.restore_interfaces()
>          # rescan ports after interface up
>          self.rescan_ports()
> -        # load port infor from config file
> +        # load port information from config file
>          self.load_portconf()
>          self.mount_procfs()
>          # auto detect network topology
> @@ -933,8 +933,8 @@ class Dut(Crb):
> 
>      def load_portconf(self):
>          """
> -        Load port configurations for ports_info. If manually configured infor
> -        not same as auto scanned, still use infor in configuration file.
> +        Load port configurations for ports_info. If manually configured info
> +        not same as auto scanned, still use information in configuration file.
>          """
>          for port in self.ports_info:
>              pci_bus = port['pci']
> @@ -1097,6 +1097,6 @@ class Dut(Crb):
>          """
>          Recover all resource before crb exit
>          """
> -        self.logger.logger_exit()
>          self.enable_tester_ipv6()
>          self.close()
> +        self.logger.logger_exit()
> --
> 2.21.0


  reply	other threads:[~2019-09-23  6:58 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-23  6:50 [dts] [PATCH V2 0/7] dts/pktgen: fix internal bugs yufengmx
2019-09-23  6:50 ` [dts] [PATCH V2 1/7] framework/logger: add pktgen logger and remove duplicate yufengmx
2019-09-23  6:58   ` Mo, YufengX
2019-09-23  6:50 ` [dts] [PATCH V2 2/7] framework/dut: fix logger quit issue yufengmx
2019-09-23  6:58   ` Mo, YufengX [this message]
2019-09-23  6:50 ` [dts] [PATCH V2 3/7] framework/tester: " yufengmx
2019-09-23  6:58   ` Mo, YufengX
2019-09-23  6:50 ` [dts] [PATCH V2 4/7] framework/pktgen_base: fix internal bug yufengmx
2019-09-23  6:58   ` Mo, YufengX
2019-09-23  6:50 ` [dts] [PATCH V2 5/7] framework/pktgen_ixia: " yufengmx
2019-09-23  6:57   ` Mo, YufengX
2019-09-23  6:50 ` [dts] [PATCH V2 6/7] framework/pktgen_trex: " yufengmx
2019-09-23  6:57   ` Mo, YufengX
2019-09-23  6:50 ` [dts] [PATCH V2 7/7] framework/pktgen: " yufengmx
2019-09-23  6:57   ` Mo, YufengX
2019-09-23  6:58 ` [dts] [PATCH V2 0/7] dts/pktgen: fix internal bugs Mo, YufengX
2019-09-24  9:14 ` Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B8B15C44A3F2C044966E545C7B7371153E84BAAE@shsmsx102.ccr.corp.intel.com \
    --to=yufengx.mo@intel.com \
    --cc=dts@dpdk.org \
    --cc=lijuan.tu@intel.com \
    --cc=wenjiex.a.li@intel.com \
    --cc=zhaoyan.chen@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).