Re: [dts] [PATCH V1] framework/qemu_libvirt: rm ssh keygen before connect to vm

["Mo, YufengX" <yufengx.mo@intel.com>]

Hi, lihong
 
Ok,  It is my mis-understanding. Ignore my comment.


> -----Original Message-----
> From: Ma, LihongX
> Sent: Thursday, September 26, 2019 11:18 AM
> To: Mo, YufengX <yufengx.mo@intel.com>; Zhang, YanX A <yanx.a.zhang@intel.com>; dts@dpdk.org
> Subject: RE: [dts] [PATCH V1] framework/qemu_libvirt: rm ssh keygen before connect to vm
> 
> Hi,yufeng
> Yes, the code will change the tester ssh config when dts run on tester.
> The qemu is start on the dut, but the connect is from the tester, so I change the ssh config on tester.
> 
> -----Original Message-----
> From: Mo, YufengX
> Sent: Thursday, September 26, 2019 11:06 AM
> To: Ma, LihongX <lihongx.ma@intel.com>; Zhang, YanX A <yanx.a.zhang@intel.com>; dts@dpdk.org
> Subject: RE: [dts] [PATCH V1] framework/qemu_libvirt: rm ssh keygen before connect to vm
> 
> Hi,ma lihong
> 
> When dts is running on tester node(tester/dut not the same node), these code change the tester ssh config.
> 
> But virtual machine is running on dut, virtual machine's ip address is assigned by dut/qemu and is managed by  dut/libvirt tool.
> 
> 
> > -----Original Message-----
> > From: Ma, LihongX
> > Sent: Thursday, September 26, 2019 11:00 AM
> > To: Mo, YufengX <yufengx.mo@intel.com>; Zhang, YanX A <yanx.a.zhang@intel.com>; dts@dpdk.org
> > Subject: RE: [dts] [PATCH V1] framework/qemu_libvirt: rm ssh keygen before connect to vm
> >
> > Hi, yufeng
> > Yan has verify this scenes, the dts and dut not on same server.
> > And i think all the session connect is from the server which run dts, so it can not use the self.host_session.
> >
> > -----Original Message-----
> > From: Mo, YufengX
> > Sent: Thursday, September 26, 2019 10:49 AM
> > To: Zhang, YanX A <yanx.a.zhang@intel.com>; dts@dpdk.org
> > Cc: Ma, LihongX <lihongx.ma@intel.com>
> > Subject: RE: [dts] [PATCH V1] framework/qemu_libvirt: rm ssh keygen before connect to vm
> >
> > Hi,zhangyan
> >
> > when dts doesn't run on dut, your fix will malfunction.
> >
> > In LibvirtKvm class, use self.host_session.send_expect to do action on the node, which run virtual machine using libvirt tool.
> >
> > BRs
> > Yufen, Mo
> >
> >
> > > -----Original Message-----
> > > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Zhang, YanX A
> > > Sent: Wednesday, September 25, 2019 3:18 PM
> > > To: Ma, LihongX <lihongx.ma@intel.com>; dts@dpdk.org
> > > Cc: Ma, LihongX <lihongx.ma@intel.com>
> > > Subject: Re: [dts] [PATCH V1] framework/qemu_libvirt: rm ssh keygen before connect to vm
> > >
> > > Tested-by:  Zhang, YanX A <yanx.a.zhang@intel.com>
> > >
> > > -----Original Message-----
> > > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of lihong
> > > Sent: Wednesday, September 25, 2019 7:49 AM
> > > To: dts@dpdk.org
> > > Cc: Ma, LihongX <lihongx.ma@intel.com>
> > > Subject: [dts] [PATCH V1] framework/qemu_libvirt: rm ssh keygen before connect to vm
> > >
> > > Signed-off-by: lihong <lihongx.ma@intel.com>
> > > ---
> > >  framework/qemu_libvirt.py | 3 +++
> > >  1 file changed, 3 insertions(+)
> > >
> > > diff --git a/framework/qemu_libvirt.py b/framework/qemu_libvirt.py index d2edd31..5b25dec 100644
> > > --- a/framework/qemu_libvirt.py
> > > +++ b/framework/qemu_libvirt.py
> > > @@ -817,6 +817,9 @@ class LibvirtKvm(VirtBase):
> > >          while count:
> > >              out = self.__control_session('ifconfig')
> > >              if "10.0.2" in out:
> > > +                pos = self.vm_ip.find(':')
> > > +                ssh_key = '[' + self.vm_ip[:pos] + ']' + self.vm_ip[pos:]
> > > +                os.system('ssh-keygen -R %s' % ssh_key)
> > >                  return True
> > >              time.sleep(6)
> > >              count -= 1
> > > --
> > > 2.7.4