test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Ma, LihongX" <lihongx.ma@intel.com>
To: "Zhu, WenhuiX" <wenhuix.zhu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Zhu, WenhuiX" <wenhuix.zhu@intel.com>
Subject: Re: [dts] [PATCH V1] tests/hotpiug_mp:add parameters when igb_uio
Date: Mon, 29 Jul 2019 06:36:07 +0000	[thread overview]
Message-ID: <BE1E572D0441E34284F1F8B7AC28F1970BAED421@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1564377735-117273-1-git-send-email-wenhuix.zhu@intel.com>

Hi, wenhui
From the patch, I think the only different of the command between igb_uio and other driver is the "--iova-mode=pa"
Driver igb_uio has the param of "--iova-mode=pa" and other did not.
So I think maybe you can define a params of it.
Eg : 
	self.iova_param = ""
	if self.drivername in ['igb_uio']:
		self.iova_param = "--iova-mode=pa"

	.........
	out = self.session_pri.send_expect("./examples/multi_process/hotplug_mp/%s/hotplug_mp %s --proc-type=auto"
				% (self.target, self.iova_param), "example>")

-----Original Message-----
From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhuwenhui
Sent: Monday, July 29, 2019 1:22 PM
To: dts@dpdk.org
Cc: Zhu, WenhuiX <wenhuix.zhu@intel.com>
Subject: [dts] [PATCH V1] tests/hotpiug_mp:add parameters when igb_uio

change test cases based on dpdk bbe29a9bd7ab6feab.

Signed-off-by: zhuwenhui <wenhuix.zhu@intel.com>
---
 tests/TestSuite_hotplug_mp.py | 42 ++++++++++++++++++++++++-----------
 1 file changed, 29 insertions(+), 13 deletions(-)

diff --git a/tests/TestSuite_hotplug_mp.py b/tests/TestSuite_hotplug_mp.py index ff89164..62f1982 100644
--- a/tests/TestSuite_hotplug_mp.py
+++ b/tests/TestSuite_hotplug_mp.py
@@ -42,19 +42,35 @@ class TestHotplugMp(TestCase):
         """
         Setup primary process and two secondary processes.
         """
-        out = self.session_pri.send_expect(
-            "./examples/multi_process/hotplug_mp/%s/hotplug_mp --proc-type=auto"
-            % self.target, "example>")
-        self.verify("Auto-detected process type: PRIMARY" in out,
-                    "Failed to setup primary process!")
-        for out in [self.session_sec_1.send_expect(
-                        "./examples/multi_process/hotplug_mp/%s/hotplug_mp --proc-type=auto"
-                        % self.target, "example>"),
-                    self.session_sec_2.send_expect(
-                        "./examples/multi_process/hotplug_mp/%s/hotplug_mp --proc-type=auto"
-                        % self.target, "example>")]:
-            self.verify("Auto-detected process type: SECONDARY" in out,
-                        "Failed to setup secondary process!")
+        if self.drivername == "igb_uio":
+            out = self.session_pri.send_expect(
+                "./examples/multi_process/hotplug_mp/%s/hotplug_mp --iova-mode=pa --proc-type=auto"
+                % self.target, "example>")
+            self.verify("Auto-detected process type: PRIMARY" in out,
+                        "Failed to setup primary process!")
+            for out in [self.session_sec_1.send_expect(
+                            "./examples/multi_process/hotplug_mp/%s/hotplug_mp --iova-mode=pa --proc-type=auto"
+                            % self.target, "example>"),
+                        self.session_sec_2.send_expect(
+                            "./examples/multi_process/hotplug_mp/%s/hotplug_mp --iova-mode=pa --proc-type=auto"
+                            % self.target, "example>")]:
+                self.verify("Auto-detected process type: SECONDARY" in out,
+                            "Failed to setup secondary process!")
+
+        else:
+            out = self.session_pri.send_expect(
+                "./examples/multi_process/hotplug_mp/%s/hotplug_mp --proc-type=auto"
+                % self.target, "example>")
+            self.verify("Auto-detected process type: PRIMARY" in out,
+                        "Failed to setup primary process!")
+            for out in [self.session_sec_1.send_expect(
+                            "./examples/multi_process/hotplug_mp/%s/hotplug_mp --proc-type=auto"
+                            % self.target, "example>"),
+                        self.session_sec_2.send_expect(
+                            "./examples/multi_process/hotplug_mp/%s/hotplug_mp --proc-type=auto"
+                            % self.target, "example>")]:
+                self.verify("Auto-detected process type: SECONDARY" in out,
+                            "Failed to setup secondary process!")
 
     def multi_process_quit(self):
         """
--
2.17.2


  parent reply	other threads:[~2019-07-29  6:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-29  5:22 zhuwenhui
2019-07-29  5:56 ` Zhu, ShuaiX
2019-07-29  6:36 ` Ma, LihongX [this message]
2019-07-29  6:59   ` Zhu, WenhuiX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BE1E572D0441E34284F1F8B7AC28F1970BAED421@SHSMSX101.ccr.corp.intel.com \
    --to=lihongx.ma@intel.com \
    --cc=dts@dpdk.org \
    --cc=wenhuix.zhu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).