From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E3D36A3201 for ; Mon, 21 Oct 2019 04:30:21 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CD05529C6; Mon, 21 Oct 2019 04:30:21 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 7CE66F3E for ; Mon, 21 Oct 2019 04:30:19 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Oct 2019 19:30:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,321,1566889200"; d="scan'208";a="280834790" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga001.jf.intel.com with ESMTP; 20 Oct 2019 19:30:18 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 20 Oct 2019 19:30:17 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Sun, 20 Oct 2019 19:30:15 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Sun, 20 Oct 2019 19:30:15 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.96]) by SHSMSX152.ccr.corp.intel.com ([10.239.6.52]) with mapi id 14.03.0439.000; Mon, 21 Oct 2019 10:30:13 +0800 From: "Ma, LihongX" To: "Peng, ZhihongX" , "dts@dpdk.org" CC: "Peng, ZhihongX" Thread-Topic: [dts] [PATCH V2] Modify the clv offset code Thread-Index: AQHVh7a3MtjuTyIVJ02dXQdAxh8R8qdkXxxQ Date: Mon, 21 Oct 2019 02:30:13 +0000 Message-ID: References: <20191021102450.22197-1-zhihongx.peng@intel.com> In-Reply-To: <20191021102450.22197-1-zhihongx.peng@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V2] Modify the clv offset code X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" Hi, zhihong This patch will apply failed, because you base dts is not right. -----Original Message----- From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Peng Zhihong Sent: Monday, October 21, 2019 6:25 PM To: dts@dpdk.org Cc: Peng, ZhihongX Subject: [dts] [PATCH V2] Modify the clv offset code Signed-off-by: Peng Zhihong --- tests/TestSuite_userspace_ethtool.py | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/tests/TestSuite_userspace_ethtool.py b/tests/TestSuite_userspa= ce_ethtool.py index bdbbea3..5898511 100644 --- a/tests/TestSuite_userspace_ethtool.py +++ b/tests/TestSuite_userspace_ethtool.py @@ -546,10 +546,16 @@ class TestUserspaceEthtool(TestCase, IxiaPacketGenera= tor): mtus =3D [1519, 2048] mtu_threshold =3D 2022 offset =3D 0 - ice_eth_overhead =3D 8 + =20 if self.nic in ['powerville', 'springville']: mtu_threshold =3D 2026 offset =3D 4 + elif self.nic in ['columbiaville_25g', 'columbiaville_100g']: + #jira DPDK-16219 + offset =3D 8 + else: + pass + for index in range(len(self.ports)): port =3D self.ports[index] # change mtu @@ -573,10 +579,7 @@ class TestUserspaceEthtool(TestCase, IxiaPacketGenerat= or): pkt.send_pkt(self.tester, tx_port=3Dintf, count=3D4) rx_pkts, _ =3D self.strip_portstats(index) self.verify(rx_pkts =3D=3D ori_rx_pkts + 4, "Packet match = mtu not forwarded as expected") - if self.nic in ['columbiaville_25g', 'columbiaville_100g']= : - pkt =3D Packet(pkt_type=3D'UDP', pkt_len=3Dmtu + ice_e= th_overhead + 1 + HEADER_SIZE['eth'] + offset) - else: - pkt =3D Packet(pkt_type=3D'UDP', pkt_len=3Dmtu + 1 + H= EADER_SIZE['eth'] + offset) + pkt =3D Packet(pkt_type=3D'UDP', pkt_len=3Dmtu + 1 + HEADE= R_SIZE['eth'] + offset) pkt.send_pkt(self.tester, tx_port=3Dintf, count=3D4) rx_pkts_over, _ =3D self.strip_portstats(index) self.verify(rx_pkts =3D=3D rx_pkts_over, "Packet over mtu = should not be forwarded") --=20 2.17.1