test suite reviews and discussions
 help / color / Atom feed
* [dts]  [PATCH V1] tests/vlan_ethertype_config:change testpmd cmd
@ 2019-10-30  6:59 Xie Wei
  2019-10-31  7:21 ` Ma, LihongX
  0 siblings, 1 reply; 2+ messages in thread
From: Xie Wei @ 2019-10-30  6:59 UTC (permalink / raw)
  To: dts; +Cc: Xie Wei

change testpmd cmd in dpdk-2a0b41984c7

Signed-off-by: Xie Wei <weix.xie@intel.com>
---
 tests/TestSuite_vlan_ethertype_config.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/TestSuite_vlan_ethertype_config.py b/tests/TestSuite_vlan_ethertype_config.py
index 33e9948..d66f0d3 100644
--- a/tests/TestSuite_vlan_ethertype_config.py
+++ b/tests/TestSuite_vlan_ethertype_config.py
@@ -344,7 +344,7 @@ class TestVlanEthertypeConfig(TestCase):
         random_vlan = random.randint(1, MAX_VLAN - 1)
         rx_vlans = [1, random_vlan, MAX_VLAN]
         self.dut.send_expect(
-            "vlan set qinq on %d" % dutRxPortId, "testpmd> ", 20)
+            "vlan set qinq_strip on %d" % dutRxPortId, "testpmd> ", 20)
         self.dut.send_expect("set verbose 1", "testpmd> ")
         self.dut.send_expect("set fwd rxonly", "testpmd> ")
         self.dut.send_expect("start", "testpmd> ")
-- 
2.17.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH V1] tests/vlan_ethertype_config:change testpmd cmd
  2019-10-30  6:59 [dts] [PATCH V1] tests/vlan_ethertype_config:change testpmd cmd Xie Wei
@ 2019-10-31  7:21 ` Ma, LihongX
  0 siblings, 0 replies; 2+ messages in thread
From: Ma, LihongX @ 2019-10-31  7:21 UTC (permalink / raw)
  To: Xie, WeiX, dts; +Cc: Xie, WeiX

Hi, xiewei
As the commit 2a0b41984c7 , we will use the ' vlan set extend on' instead of 'vlan set qinq on'
And if we will identification the packet as Qin vlan pkts, so we should add 'vlan set strip on xx' before 'vlan set extend on'

-----Original Message-----
From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xie Wei
Sent: Wednesday, October 30, 2019 3:00 PM
To: dts@dpdk.org
Cc: Xie, WeiX <weix.xie@intel.com>
Subject: [dts] [PATCH V1] tests/vlan_ethertype_config:change testpmd cmd

change testpmd cmd in dpdk-2a0b41984c7

Signed-off-by: Xie Wei <weix.xie@intel.com>
---
 tests/TestSuite_vlan_ethertype_config.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/TestSuite_vlan_ethertype_config.py b/tests/TestSuite_vlan_ethertype_config.py
index 33e9948..d66f0d3 100644
--- a/tests/TestSuite_vlan_ethertype_config.py
+++ b/tests/TestSuite_vlan_ethertype_config.py
@@ -344,7 +344,7 @@ class TestVlanEthertypeConfig(TestCase):
         random_vlan = random.randint(1, MAX_VLAN - 1)
         rx_vlans = [1, random_vlan, MAX_VLAN]
         self.dut.send_expect(
-            "vlan set qinq on %d" % dutRxPortId, "testpmd> ", 20)
+            "vlan set qinq_strip on %d" % dutRxPortId, "testpmd> ", 20)
         self.dut.send_expect("set verbose 1", "testpmd> ")
         self.dut.send_expect("set fwd rxonly", "testpmd> ")
         self.dut.send_expect("start", "testpmd> ")
-- 
2.17.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-30  6:59 [dts] [PATCH V1] tests/vlan_ethertype_config:change testpmd cmd Xie Wei
2019-10-31  7:21 ` Ma, LihongX

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox