From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A2F8AA0352; Tue, 5 Nov 2019 02:53:10 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7E79F2C23; Tue, 5 Nov 2019 02:53:10 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id A22952BE9 for ; Tue, 5 Nov 2019 02:53:09 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Nov 2019 17:53:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,269,1569308400"; d="scan'208";a="226941591" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga004.fm.intel.com with ESMTP; 04 Nov 2019 17:53:08 -0800 Received: from fmsmsx122.amr.corp.intel.com (10.18.125.37) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 4 Nov 2019 17:53:07 -0800 Received: from shsmsx153.ccr.corp.intel.com (10.239.6.53) by fmsmsx122.amr.corp.intel.com (10.18.125.37) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 4 Nov 2019 17:53:07 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.213]) by SHSMSX153.ccr.corp.intel.com ([169.254.12.215]) with mapi id 14.03.0439.000; Tue, 5 Nov 2019 09:53:05 +0800 From: "Ma, LihongX" To: "Peng, ZhihongX" , "dts@dpdk.org" CC: "Peng, ZhihongX" Thread-Topic: [dts] [PATCH V1] Before the exception exit, it needs to be re-bound to the DPDK. Thread-Index: AQHVktisobwxEtrS1UmzOqsBLaCKMKd7z5/g Date: Tue, 5 Nov 2019 01:53:05 +0000 Message-ID: References: <20191104062109.15705-1-zhihongx.peng@intel.com> In-Reply-To: <20191104062109.15705-1-zhihongx.peng@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1] Before the exception exit, it needs to be re-bound to the DPDK. X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" Hi, zhihong Please add the prefix 'dir/suite_name' to you subject, like 'tests/userspac= e_ethtool: Before the exception exit, it needs to be re-bound to the DPDK' And becasuse the ports number greather than 1, as you modify, if the verify= failed on second port, it will only re-bound the second port, the first po= rt is also bind on system driver. I think you should optimization the code. By the way, in this suite, case test_dump_driver_info also have this issue,= please modify code together. -----Original Message----- From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Peng Zhihong Sent: Monday, November 4, 2019 2:21 PM To: dts@dpdk.org Cc: Peng, ZhihongX Subject: [dts] [PATCH V1] Before the exception exit, it needs to be re-boun= d to the DPDK. Before the exception exit, it needs to be re-bound to the DPDK. Signed-off-by: Peng Zhihong --- tests/TestSuite_userspace_ethtool.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/TestSuite_userspace_ethtool.py b/tests/TestSuite_userspa= ce_ethtool.py index 116fd3a..16d7f5c 100644 --- a/tests/TestSuite_userspace_ethtool.py +++ b/tests/TestSuite_userspace_ethtool.py @@ -335,7 +335,9 @@ class TestUserspaceEthtool(TestCase, IxiaPacketGenerato= r): # get linux interface intf =3D netdev.get_interface_name() out =3D self.dut.send_expect("ethtool -d %s raw off file %s" %= (intf, portinfo['reg_file']), "# ") - self.verify(("register" in out and "CTRL" in out), "Failed to = dump %s registers" % intf) + if "register" not in out or "CTRL" not in out: + portinfo['net_dev'].bind_driver(portinfo['ori_driver']) + raise VerifyFailure("Failed to dump %s registers" % intf) =20 for index in range(len(self.ports)): # bind to original driver --=20 2.17.1