From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AE606A04A2; Wed, 6 Nov 2019 02:54:15 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9BAB01BFE6; Wed, 6 Nov 2019 02:54:15 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id CBB421BFE4 for ; Wed, 6 Nov 2019 02:54:13 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Nov 2019 17:54:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,272,1569308400"; d="scan'208";a="376895424" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga005.jf.intel.com with ESMTP; 05 Nov 2019 17:54:13 -0800 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 5 Nov 2019 17:54:12 -0800 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 5 Nov 2019 17:54:11 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 5 Nov 2019 17:54:10 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.213]) by shsmsx102.ccr.corp.intel.com ([169.254.2.108]) with mapi id 14.03.0439.000; Wed, 6 Nov 2019 09:54:08 +0800 From: "Ma, LihongX" To: "Zhu, ShuaiX" , "dts@dpdk.org" CC: "Wang, Yinan" Thread-Topic: [dts] [PATCH V1] tests/vdev_primary_secondary:disable RSS Thread-Index: AQHVk6CiGBGlqPc7F0Gi2aS/JSGl7ad9VQ8A//+B+ICAAIu5IA== Date: Wed, 6 Nov 2019 01:54:08 +0000 Message-ID: References: <1572934913-57413-1-git-send-email-shuaix.zhu@intel.com> <4DC48DF9BDA3E54A836D2D3C057DEC6F0BBA8220@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <4DC48DF9BDA3E54A836D2D3C057DEC6F0BBA8220@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1] tests/vdev_primary_secondary:disable RSS X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" Yes, you are right, the second app should wait first complete. -----Original Message----- From: Zhu, ShuaiX=20 Sent: Wednesday, November 6, 2019 9:34 AM To: Ma, LihongX ; dts@dpdk.org Cc: Wang, Yinan Subject: RE: [dts] [PATCH V1] tests/vdev_primary_secondary:disable RSS Hi lihong, Time.sleep needs to be added after the first process starts, waiting fo= r the second start. If placed after the second process, the second process = cannot be started. > -----Original Message----- > From: Ma, LihongX > Sent: Wednesday, November 6, 2019 9:12 AM > To: Zhu, ShuaiX ; dts@dpdk.org > Cc: Wang, Yinan ; Zhu, ShuaiX=20 > > Subject: RE: [dts] [PATCH V1] tests/vdev_primary_secondary:disable RSS >=20 > Hi, shuai > I think you time.sleep(3) should add after the command ' > self.vhost_secondary.send_expect(final_cmd_secondary, " ", 120)' > Because you only wait the first app but not wait the second app. > And I think you can use ' Checking' or 'Port' instead of ' ' as a expecte= d word. >=20 > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhu,shuai > Sent: Tuesday, November 5, 2019 2:22 PM > To: dts@dpdk.org > Cc: Wang, Yinan ; Zhu, ShuaiX=20 > > Subject: [dts] [PATCH V1] tests/vdev_primary_secondary:disable RSS >=20 > RSS is not support by virito device and will thus will return error=20 > configure device with RSS enabled. Need to disable RSS when configuring v= irtio device. >=20 > Signed-off-by: zhu,shuai > --- > tests/TestSuite_vdev_primary_secondary.py | 3 +++ > 1 file changed, 3 insertions(+) >=20 > diff --git a/tests/TestSuite_vdev_primary_secondary.py > b/tests/TestSuite_vdev_primary_secondary.py > index 8b7b899..102a9e0 100644 > --- a/tests/TestSuite_vdev_primary_secondary.py > +++ b/tests/TestSuite_vdev_primary_secondary.py > @@ -119,6 +119,7 @@ class TestVdevPrimarySecondary(TestCase): > final_cmd_first =3D example_cmd_auto % (self.mem_channels, > self.queues) > final_cmd_secondary =3D example_cmd_secondary %=20 > (self.mem_channels, self.queues) > self.vhost_first.send_expect(final_cmd_first, " ", 120) > + time.sleep(3) > self.vhost_secondary.send_expect(final_cmd_secondary, " ",=20 > 120) >=20 >=20 > @@ -126,6 +127,8 @@ class TestVdevPrimarySecondary(TestCase): >=20 > self.vm_dut.send_expect("cp=20 > ./examples/multi_process/symmetric_mp/main.c > .", "#") > self.vm_dut.send_expect( > "sed -i '/.offloads =3D DEV_RX_OFFLOAD_CHECKSUM,/d'=20 > ./examples/multi_process/symmetric_mp/m > ain.c", "#") > + self.vm_dut.send_expect( > + "sed -i 's/.mq_mode =3D > ETH_MQ_RX_RSS,/.mq_mode =3D > ETH_MQ_RX_NONE,/g' ./examples/multi_process/symmetric_mp/main.c", "#") > out =3D > self.vm_dut.build_dpdk_apps('./examples/multi_process/symmetric_mp') > self.verify("Error" not in out, "compilation symmetric_mp=20 > error") >=20 > -- > 2.17.2