test suite reviews and discussions
 help / color / Atom feed
From: "Ma, LihongX" <lihongx.ma@intel.com>
To: "Xiao, QimaiX" <qimaix.xiao@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Xiao, QimaiX" <qimaix.xiao@intel.com>
Subject: Re: [dts] [PATCH V1]framework/dut: fix create_eal_parameters method
Date: Wed, 27 Nov 2019 02:38:45 +0000
Message-ID: <BE1E572D0441E34284F1F8B7AC28F1970BB294AF@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1574674372-20174-1-git-send-email-qimaix.xiao@intel.com>

Reviewed-by:ma,lihong <lihongx.ma@intel.com>

-----Original Message-----
From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xiao Qimai
Sent: Monday, November 25, 2019 5:33 PM
To: dts@dpdk.org
Cc: Xiao, QimaiX <qimaix.xiao@intel.com>
Subject: [dts] [PATCH V1]framework/dut: fix create_eal_parameters method

fix create_eal_parameters method

Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
---
 framework/dut.py | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/framework/dut.py b/framework/dut.py index 4d8874a..f26b081 100644
--- a/framework/dut.py
+++ b/framework/dut.py
@@ -120,12 +120,13 @@ class Dut(Crb):
         if config:
             # deal with cores
             if config.has_key('cores'):
-                if config['cores'] == '' or config['cores'].lower() == 'default':
-                    core_list = self.get_core_list(default_cores)
-                elif type(config['cores']) == list:
+                if type(config['cores']) == list:
                     core_list = config['cores']
-                else:
-                    core_list = self.get_core_list(config['cores'], socket=socket)
+                elif isinstance(config['cores'], str):
+                    if config['cores'] == '' or config['cores'].lower() == 'default':
+                        core_list = self.get_core_list(default_cores)
+                    else:
+                        core_list = self.get_core_list(config['cores'], 
+ socket=socket)
             else:
                 core_list = self.get_core_list(default_cores)
 
--
2.17.1


  reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-25  9:32 Xiao Qimai
2019-11-27  2:38 ` Ma, LihongX [this message]
2019-11-27  9:28 ` Tu, Lijuan

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BE1E572D0441E34284F1F8B7AC28F1970BB294AF@SHSMSX101.ccr.corp.intel.com \
    --to=lihongx.ma@intel.com \
    --cc=dts@dpdk.org \
    --cc=qimaix.xiao@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox