From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 60EF1A04B5; Mon, 2 Dec 2019 07:31:26 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2FAAF2C58; Mon, 2 Dec 2019 07:31:26 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 6435B91 for ; Mon, 2 Dec 2019 07:31:24 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Dec 2019 22:31:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,268,1571727600"; d="scan'208";a="411655246" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga006.fm.intel.com with ESMTP; 01 Dec 2019 22:31:22 -0800 Received: from fmsmsx161.amr.corp.intel.com (10.18.125.9) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 1 Dec 2019 22:31:22 -0800 Received: from shsmsx106.ccr.corp.intel.com (10.239.4.159) by FMSMSX161.amr.corp.intel.com (10.18.125.9) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 1 Dec 2019 22:31:22 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.19]) by SHSMSX106.ccr.corp.intel.com ([169.254.10.236]) with mapi id 14.03.0439.000; Mon, 2 Dec 2019 14:31:20 +0800 From: "Ma, LihongX" To: "Zhu, WenhuiX" , "Li, WenjieX A" , "dts@dpdk.org" CC: "Li, WenjieX A" Thread-Topic: [dts] [PATCH V1] tests/shutdown_api:'port stop' recover the orignal link status for CVL Thread-Index: AQHVpbZMtcX1B5xoE0mnQz5lrXFsM6efm1+AgAbNSjA= Date: Mon, 2 Dec 2019 06:31:19 +0000 Message-ID: References: <1574954547-24055-1-git-send-email-wenjiex.a.li@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1] tests/shutdown_api:'port stop' recover the orignal link status for CVL X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" Reviewed-by: ma,lihong -----Original Message----- From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Zhu, WenhuiX Sent: Thursday, November 28, 2019 2:39 PM To: Li, WenjieX A ; dts@dpdk.org Cc: Li, WenjieX A Subject: Re: [dts] [PATCH V1] tests/shutdown_api:'port stop' recover the or= ignal link status for CVL Tested-by: Zhu, WenhuiX -----Original Message----- From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Wenjie Li Sent: Thursday, November 28, 2019 11:22 PM To: dts@dpdk.org Cc: Li, WenjieX A Subject: [dts] [PATCH V1] tests/shutdown_api:'port stop' recover the origna= l link status for CVL In DPDK fdcf92ed6637b790, the 'port stop' will recovery the oringnal link s= tatus for CVL.=20 If the link is up, it should be up after 'port stop'; if down, then be down= . This is different with other NICs. In test case stop_restart, the port is up before 'port stop', so verify the= port is UP for CVL and down for other NICs. Signed-off-by: Wenjie Li --- tests/TestSuite_shutdown_api.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tests/TestSuite_shutdown_api.py b/tests/TestSuite_shutdown_api= .py index 63fff84..58daad1 100644 --- a/tests/TestSuite_shutdown_api.py +++ b/tests/TestSuite_shutdown_api.py @@ -201,7 +201,10 @@ class TestShutdownApi(TestCase): self.check_forwarding(received=3DFalse) self.dut.send_expect("port stop all", "testpmd> ", 100) time.sleep(5) - self.check_ports(status=3DFalse) + if self.nic in ["columbiaville_25g", "columbiaville_100g"]: + self.check_ports(status=3DTrue) + else: + self.check_ports(status=3DFalse) self.dut.send_expect("port start all", "testpmd> ", 100) time.sleep(5) self.check_ports(status=3DTrue) -- 2.17.1