RE: [dts] [PATCH V1] checksum_offload:ignore sctp checksum in check l4 tx

["Huang, ZhiminX" <zhiminx.huang@intel.com>]

> -----Original Message-----
> From: Tu, Lijuan <lijuan.tu@intel.com>
> Sent: Tuesday, November 30, 2021 11:12 AM
> To: Huang, ZhiminX <zhiminx.huang@intel.com>; dts@dpdk.org
> Cc: Huang, ZhiminX <zhiminx.huang@intel.com>
> Subject: RE: [dts] [PATCH V1] checksum_offload:ignore sctp checksum in check
> l4 tx
> 
> 
> 
> > -----Original Message-----
> > From: Zhimin Huang <zhiminx.huang@intel.com>
> > Sent: 2021年11月15日 22:38
> > To: dts@dpdk.org
> > Cc: Huang, ZhiminX <zhiminx.huang@intel.com>
> > Subject: [dts] [PATCH V1] checksum_offload:ignore sctp checksum in
> > check l4 tx
> >
> > sync with dev to ignore check sctp in pmd,customers only require udp and
> tcp.
> >
> > Signed-off-by: Zhimin Huang <zhiminx.huang@intel.com>
> > ---
> >  test_plans/checksum_offload_test_plan.rst | 2 +-
> >  tests/TestSuite_checksum_offload.py       | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/test_plans/checksum_offload_test_plan.rst
> > b/test_plans/checksum_offload_test_plan.rst
> > index db939b45..f4b388c4 100644
> > --- a/test_plans/checksum_offload_test_plan.rst
> > +++ b/test_plans/checksum_offload_test_plan.rst
> > @@ -297,7 +297,7 @@ Test Case: Hardware Checksum Check L4 TX
> > ===========================================
> >  This test involves testing many different scenarios with a L4 checksum.
> >  A variety of tunneling protocols, L3 protocols and L4 protocols are
> > combined - to test as many scenarios as possible. Currently, UDP, TCP
> > and SCTP are used
> > +to test as many scenarios as possible. Currently, UDP and TCP are
> > +used
> >  as L4 protocols, with IP and IPv6 being used at level 3. The tested
> > tunneling protocols are VXLAN and GRE. This test is used to determine
> > whether the hardware offloading of checksums works properly.
> > diff --git a/tests/TestSuite_checksum_offload.py
> > b/tests/TestSuite_checksum_offload.py
> > index 3338e334..bdea6a15 100644
> > --- a/tests/TestSuite_checksum_offload.py
> > +++ b/tests/TestSuite_checksum_offload.py
> > @@ -69,7 +69,7 @@ l3_proto_classes = [  l4_proto_classes = [
> >      UDP,
> >      TCP,
> > -    SCTP
> > +#    SCTP
> 
> It is commented here,  I think it is a know issue and will be fixed in a short
> time.
> 
> If there is no plan to fix it? Why keep them ?
> 
> >  ]
> >
> >  tunnelling_proto_classes = [
> > --
> > 2.17.1
> 
Ok, I will re_submit v2 patch to remove it, thanks.