test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Huang, ZhiminX" <zhiminx.huang@intel.com>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
	"dts@dpdk.org" <dts@dpdk.org>
Cc: "An, XiangX" <xiangx.an@intel.com>
Subject: Re: [dts] [PATCH V1 4/4] tests/unit_tests_eal: modify code to adapt avx512
Date: Tue, 2 Nov 2021 11:16:21 +0000	[thread overview]
Message-ID: <BN0PR11MB57123854537291FF222EF089FD8B9@BN0PR11MB5712.namprd11.prod.outlook.com> (raw)
In-Reply-To: <DM6PR11MB4491CA60A14CC2EA389A6EEB9A8B9@DM6PR11MB4491.namprd11.prod.outlook.com>

> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Ananyev, Konstantin
> Sent: Tuesday, November 2, 2021 6:43 PM
> To: An, XiangX <xiangx.an@intel.com>; dts@dpdk.org
> Cc: An, XiangX <xiangx.an@intel.com>
> Subject: Re: [dts] [PATCH V1 4/4] tests/unit_tests_eal: modify code to adapt
> avx512
> 
> 
> Hi Xiang,
> 
> > Modify code to adapt rxmod avx512.
> >
> > Signed-off-by: Xiang An <xiangx.an@intel.com>
> > ---
> >  tests/TestSuite_unit_tests_eal.py | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/tests/TestSuite_unit_tests_eal.py
> b/tests/TestSuite_unit_tests_eal.py
> > index 8096183..b5cb7a2 100644
> > --- a/tests/TestSuite_unit_tests_eal.py
> > +++ b/tests/TestSuite_unit_tests_eal.py
> > @@ -38,7 +38,7 @@ EAL autotest.
> >
> >  import framework.utils as utils
> >  from framework.test_case import TestCase
> > -
> > +from framework.settings import load_global_setting,
> DPDK_RXMODE_SETTING
> >  #
> >  #
> >  # Test class.
> > @@ -462,7 +462,8 @@ class TestUnitTestsEal(TestCase):
> >          self.test_app_cmdline += "--no-pci"
> >
> >          if self.dut.dpdk_version >= '20.11.0':
> > -            self.test_app_cmdline += " --force-max-simd-bitwidth=0"
> > +            if load_global_setting(DPDK_RXMODE_SETTING) == 'default':
> > +                self.test_app_cmdline += "
> --force-max-simd-bitwidth=0"
> 
> Could you probably explain why it is needed here?
> 
> >          self.dut.send_expect(self.test_app_cmdline, "R.*T.*E.*>.*>",
> self.start_test_time)
> >          out = self.dut.send_expect("acl_autotest", "RTE>>",
> self.run_cmd_time)
> >          self.dut.send_expect("quit", "# ")
> > --
> > 1.8.3.1

Hi Konstantin,
We have add this case to test avx512 mode, if this judgment is not added, the cmdline will invalid.

Take a example:
x86_64-native-linuxapp-gcc/app/test/dpdk-test -l 1,2,3,4 -n 4 --file-prefix=dpdk_237965_20211103034106 --force-max-simd-bitwidth=512 --no-pci --force-max-simd-bitwidth=0

Regards,
HuangZhiMin




  reply	other threads:[~2021-11-02 11:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-02  6:43 [dts] [PATCH V1 1/4] tests/kernelpf_iavf: " Xiang An
2021-11-02  6:43 ` [dts] [PATCH V1 2/4] tests/vf_vlan: " Xiang An
2021-11-02  6:43 ` [dts] [PATCH V1 3/4] tests/l3fwdacl: " Xiang An
2021-11-02  6:43 ` [dts] [PATCH V1 4/4] tests/unit_tests_eal: " Xiang An
2021-11-02 10:43   ` Ananyev, Konstantin
2021-11-02 11:16     ` Huang, ZhiminX [this message]
2021-11-02 11:26       ` Ananyev, Konstantin
2021-11-03  3:07         ` Huang, ZhiminX
2021-11-03 10:39           ` Ananyev, Konstantin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BN0PR11MB57123854537291FF222EF089FD8B9@BN0PR11MB5712.namprd11.prod.outlook.com \
    --to=zhiminx.huang@intel.com \
    --cc=dts@dpdk.org \
    --cc=konstantin.ananyev@intel.com \
    --cc=xiangx.an@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).