RE: [dts] [PATCH V2 2/2] tests/ice_flow_priority: synchronize test plans and optimization scripts

RE: [dts] [PATCH V2 2/2] tests/ice_flow_priority: synchronize test plans and optimization scripts

[Jiale, SongX]

> -----Original Message-----
> From: Jiale, SongX <songx.jiale@intel.com>
> Sent: Wednesday, September 14, 2022 5:43 PM
> To: dts@dpdk.org
> Cc: Jiale, SongX <songx.jiale@intel.com>
> Subject: [dts] [PATCH V2 2/2] tests/ice_flow_priority: synchronize test plans
> and optimization scripts
> 
> 1.synchronize test plans to remove ip fragment packets.
> 2.optimization scripts, remove the method of reload ice.
> 
> According to dpdk commit cc46bab5968 ("net/ice: remove support for IP
> fragment default RSS").
> 
> Signed-off-by: Song Jiale <songx.jiale@intel.com>
> ---
Tested-by: Weiyuan Li <weiyuanx.li@intel.com>

[dts] [PATCH V2 1/2] test_plans/ice_flow_priority: remove ip fragment packets

[Song Jiale]

the default rss not support ipfrag rss, so remove ip fragment packets.

According to dpdk commit cc46bab5968 ("net/ice: remove support for IP fragment default RSS").

Signed-off-by: Song Jiale <songx.jiale@intel.com>
---
 test_plans/ice_flow_priority_test_plan.rst | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/test_plans/ice_flow_priority_test_plan.rst b/test_plans/ice_flow_priority_test_plan.rst
index 73095014..30433f57 100644
--- a/test_plans/ice_flow_priority_test_plan.rst
+++ b/test_plans/ice_flow_priority_test_plan.rst
@@ -314,15 +314,11 @@ rules::
 matched packets::
 
   >>> sendp([Ether()/IPv6(src="<ipv6 src>", dst="<ipv6 dst>")/("X"*480)], iface="<tester interface>")
-  >>> sendp([Ether()/IPv6(src="<ipv6 src>", dst="<ipv6 dst>")/IPv6ExtHdrFragment()/("X"*480)], iface="<tester interface>")
 
 mismatched packets::
 
   >>> sendp([Ether()/IPv6(src="<ipv6 src change inputset>", dst="<ipv6 dst>")/("X"*480)], iface="<tester interface>")
   >>> sendp([Ether()/IPv6(src="<ipv6 src>", dst="<ipv6 dst change inputset>")/("X"*480)], iface="<tester interface>")
-  >>> sendp([Ether()/IPv6(src="<ipv6 src change inputset>", dst="<ipv6 dst>")/IPv6ExtHdrFragment()/("X"*480)], iface="<tester interface>")
-  >>> sendp([Ether()/IPv6(src="<ipv6 src>", dst="<ipv6 dst change inputset>")/IPv6ExtHdrFragment()/("X"*480)], iface="<tester interface>")
-
 
 Test Case 4: MAC_IPV6_TCP
 -------------------------
@@ -632,7 +628,7 @@ mismatched packets::
 
 Test Case 20: check flow priority filter
 ----------------------------------------
-1. launch testpmd with --log-level="ice,8"
+1. launch testpmd with --log-level="ice,7"
 
 2. create rules with priority 0, check the rule is created to switch with a log "Succeeded to create (2) flow"::
 
-- 
2.17.1

[dts] [PATCH V2 2/2] tests/ice_flow_priority: synchronize test plans and optimization scripts

[Song Jiale]

1.synchronize test plans to remove ip fragment packets.
2.optimization scripts, remove the method of reload ice.

According to dpdk commit cc46bab5968 ("net/ice: remove support for IP fragment default RSS").

Signed-off-by: Song Jiale <songx.jiale@intel.com>
---
 tests/TestSuite_ice_flow_priority.py | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/tests/TestSuite_ice_flow_priority.py b/tests/TestSuite_ice_flow_priority.py
index 1179629f..8f569ba3 100644
--- a/tests/TestSuite_ice_flow_priority.py
+++ b/tests/TestSuite_ice_flow_priority.py
@@ -71,8 +71,6 @@ tv_mac_ipv6 = {
         "mismatched": [
             'Ether()/IPv6(src="CDCD:910A:2222:5498:8475:1111:3900:1537", dst="CDCD:910A:2222:5498:8475:1111:3900:2020")/("X"*480)',
             'Ether()/IPv6(src="CDCD:910A:2222:5498:8475:1111:3900:1536", dst="CDCD:910A:2222:5498:8475:1111:3900:2023")/("X"*480)',
-            'Ether()/IPv6(src="CDCD:910A:2222:5498:8475:1111:3900:1537", dst="CDCD:910A:2222:5498:8475:1111:3900:2020")/IPv6ExtHdrFragment()/("X"*480)',
-            'Ether()/IPv6(src="CDCD:910A:2222:5498:8475:1111:3900:1536", dst="CDCD:910A:2222:5498:8475:1111:3900:2023")/IPv6ExtHdrFragment()/("X"*480)',
         ],
     },
     "check_param": {"check_0": {"queue": [4, 5]}, "check_1": {"queue": 8}},
@@ -421,15 +419,8 @@ class ICEPFFlowPriorityTest(TestCase):
         """
         Run before each test case.
         """
-        self.reload_ice()
         self.launch_testpmd()
 
-    def reload_ice(self):
-        self.dut.bind_interfaces_linux("ice")
-        self.dut.send_expect("rmmod ice", "#", 120)
-        self.dut.send_expect("modprobe ice", "#", 120)
-        self.dut.bind_interfaces_linux("vfio-pci")
-
     def launch_testpmd(self, eal_param=False):
         """
         launch testpmd with the command
@@ -439,7 +430,7 @@ class ICEPFFlowPriorityTest(TestCase):
             self.pmdout.start_testpmd(
                 cores="1S/4C/1T",
                 ports=[self.pf_pci],
-                eal_param="--log-level=ice,8",
+                eal_param="--log-level=ice,7",
                 param="--rxq={0} --txq={0}".format(self.rxq),
             )
         # start testpmd in pipeline mode
-- 
2.17.1

[dts] [PATCH V2 2/2] tests/ice_flow_priority: synchronize test plans and optimization scripts

[lijuan.tu]

On Wed, 14 Sep 2022 09:42:50 +0000, Song Jiale <songx.jiale@intel.com> wrote:
> 1.synchronize test plans to remove ip fragment packets.
> 2.optimization scripts, remove the method of reload ice.
> 
> According to dpdk commit cc46bab5968 ("net/ice: remove support for IP fragment default RSS").
> 
> Signed-off-by: Song Jiale <songx.jiale@intel.com>

Acked-by: Lijuan Tu <lijuan.tu@intel.com>
Series applied, thanks