test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Chen, BoX C" <box.c.chen@intel.com>
To: "dts@dpdk.org" <dts@dpdk.org>
Subject: Re: [dts] [PATCH V2] tests/dual_vlan: Update unsupported network card
Date: Thu, 2 Jul 2020 07:19:16 +0000	[thread overview]
Message-ID: <BN6PR11MB166773D4F7A061034F15A2D4D96D0@BN6PR11MB1667.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200702033552.25298-1-box.c.chen@intel.com>

[-- Attachment #1: Type: text/plain, Size: 3162 bytes --]

Tested-by:  Chen, BoX C <BoX.C.Chen@intel.com>

Regards,
Chen Bo

> -----Original Message-----
> From: Chen, BoX C <box.c.chen@intel.com>
> Sent: July 2, 2020 11:36
> To: dts@dpdk.org
> Cc: Chen, BoX C <box.c.chen@intel.com>
> Subject: [dts][PATCH V2] tests/dual_vlan: Update unsupported network card
> 
> Update unsupported NIC, and delete code that will not be executed.
> 
> Signed-off-by: ChenBo <box.c.chen@intel.com>
> ---
>  conf/test_case_checklist.json | 1 +
>  tests/TestSuite_dual_vlan.py  | 8 --------
>  2 files changed, 1 insertion(+), 8 deletions(-)
> 
> diff --git a/conf/test_case_checklist.json b/conf/test_case_checklist.json
> index 493f403..d475229 100644
> --- a/conf/test_case_checklist.json
> +++ b/conf/test_case_checklist.json
> @@ -288,6 +288,7 @@
>                  "fortville_eagle",
>                  "fortville_spirit",
>                  "fortville_spirit_single",
> +                "foxville",
>                  "powerville",
>                  "kawela_4",
>                  "springville",
> diff --git a/tests/TestSuite_dual_vlan.py b/tests/TestSuite_dual_vlan.py
> index daa23d3..855769c 100644
> --- a/tests/TestSuite_dual_vlan.py
> +++ b/tests/TestSuite_dual_vlan.py
> @@ -342,14 +342,10 @@ class TestDualVlan(TestCase):
>          """
>          Enable/Disable VLAN packets strip on queue
>          """
> -        self.verify(self.nic not in ["columbiaville_25g", "columbiaville_100g",
> "fortville_eagle", "fortville_spirit", "fortville_spirit_single", "fortville_25g",
> "fortpark_TLV","fortpark_BASE-T", "cavium_a063", "cavium_a064",
> "carlsville"], "%s NIC not support queue vlan strip " % self.nic)
> -
>          self.mode_config(filter="off")
>          self.mode_config(extend="off")
>          self.mode_config(strip="off")
>          self.mode_config(stripq="off")
> -        if self.nic in ["fortville_eagle", "fortville_spirit", "fortville_spirit_single",
> "fortville_25g", "fortpark_TLV", "fortpark_BASE-T","carlsville"]:
> -            self.dut.send_expect('rx_vlan add %s %s' % (outvlan, dutRxPortId),
> "testpmd> ")
>          self.vlan_send_packet(outvlan)
>          out = self.get_tcpdump_package()
>          self.verify("vlan %s" % outvlan in out, "vlan strip queue disable error : " +
> out) @@ -361,13 +357,9 @@ class TestDualVlan(TestCase):
>          self.verify("vlan %s" % outvlan not in out, "vlan strip enable error: " + out)
> 
>          self.mode_config(stripq="off")
> -        if self.nic == 'foxville':
> -            self.mode_config(strip="off")
>          self.vlan_send_packet(outvlan)
>          out = self.get_tcpdump_package()
>          self.verify("vlan %s" % outvlan in out, "vlan strip queue disable error: " +
> out)
> -        if self.nic in ["columbiaville_25g", "columbiaville_100g", "fortville_eagle",
> "fortville_spirit", "fortville_spirit_single", "fortville_25g",
> "fortpark_TLV","fortpark_BASE-T" "carlsville"]:
> -            self.dut.send_expect('rx_vlan rm %s %s' % (outvlan, dutRxPortId),
> "testpmd> ")
> 
>      def test_vlan_insert_config(self):
>          """
> --
> 2.17.1


[-- Attachment #2: TestDualVlan.log --]
[-- Type: application/octet-stream, Size: 915543 bytes --]

  reply	other threads:[~2020-07-02  7:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-02  3:35 ChenBo
2020-07-02  7:19 ` Chen, BoX C [this message]
2020-07-02  7:19 ` Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BN6PR11MB166773D4F7A061034F15A2D4D96D0@BN6PR11MB1667.namprd11.prod.outlook.com \
    --to=box.c.chen@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).