From: "Peng, Yuan" <yuan.peng@intel.com>
To: "Zhou, JunX W" <junx.w.zhou@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Zhou, JunX W" <junx.w.zhou@intel.com>
Subject: Re: [dts] [PATCH V1] tests/TestSuite_generic_flow_api: put validate rule after create rule
Date: Tue, 29 Sep 2020 01:55:15 +0000 [thread overview]
Message-ID: <BN6PR11MB1841BA481D334E4524E97146FE320@BN6PR11MB1841.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200927082547.895-1-junx.w.zhou@intel.com>
Acked by Peng, Yuan <yuan.peng@intel.com>
-----Original Message-----
From: dts <dts-bounces@dpdk.org> On Behalf Of Zhou, Junx
Sent: Sunday, September 27, 2020 4:26 PM
To: dts@dpdk.org
Cc: Zhou, JunX W <junx.w.zhou@intel.com>
Subject: [dts] [PATCH V1] tests/TestSuite_generic_flow_api: put validate rule after create rule
From: Zhou jun <junx.w.zhou@intel.com>
it's not work if execute validate rule before execute create rule, so put validate after create rule.
Signed-off-by: Zhou jun <junx.w.zhou@intel.com>
---
tests/TestSuite_generic_flow_api.py | 70 ++++++++++++++++++-------------------
1 file changed, 35 insertions(+), 35 deletions(-)
diff --git a/tests/TestSuite_generic_flow_api.py b/tests/TestSuite_generic_flow_api.py
index da061fe..14b5713 100644
--- a/tests/TestSuite_generic_flow_api.py
+++ b/tests/TestSuite_generic_flow_api.py
@@ -1385,22 +1385,6 @@ class TestGeneric_flow_api(TestCase):
time.sleep(2)
# create the flow rules
basic_flow_actions = [
- {'create': 'validate', 'flows': ['vlan', 'ipv4'], 'actions': ['queue']},
- {'create': 'validate', 'flows': ['vlan', 'ipv4', 'udp'], 'actions': ['queue']},
- {'create': 'validate', 'flows': ['vlan', 'ipv4', 'tcp'], 'actions': ['queue']},
- {'create': 'validate', 'flows': ['vlan', 'ipv4', 'sctp'], 'actions': ['queue']},
- {'create': 'validate', 'flows': ['vlan', 'ipv4', 'vf0'], 'actions': ['queue']},
- {'create': 'validate', 'flows': ['vlan', 'ipv4', 'sctp', 'vf1'], 'actions': ['queue']},
- {'create': 'validate', 'flows': ['vlan', 'ipv4', 'sctp'], 'actions': ['drop']},
- {'create': 'validate', 'flows': ['vlan', 'ipv4', 'udp', 'vf1'], 'actions': ['drop']},
- {'create': 'validate', 'flows': ['vlan', 'ipv6'], 'actions': ['queue']},
- {'create': 'validate', 'flows': ['vlan', 'ipv6', 'udp'], 'actions': ['queue']},
- {'create': 'validate', 'flows': ['vlan', 'ipv6', 'tcp'], 'actions': ['queue']},
- {'create': 'validate', 'flows': ['vlan', 'ipv6', 'sctp'], 'actions': ['queue']},
- {'create': 'validate', 'flows': ['vlan', 'ipv6', 'vf0'], 'actions': ['queue']},
- {'create': 'validate', 'flows': ['vlan', 'ipv6', 'tcp', 'vf1'], 'actions': ['queue']},
- {'create': 'validate', 'flows': ['vlan', 'ipv6', 'sctp'], 'actions': ['drop']},
- {'create': 'validate', 'flows': ['vlan', 'ipv6', 'tcp', 'vf1'], 'actions': ['drop']},
{'create': 'create', 'flows': ['vlan', 'ipv4'], 'actions': ['queue']},
{'create': 'create', 'flows': ['vlan', 'ipv4', 'udp'], 'actions': ['queue']},
{'create': 'create', 'flows': ['vlan', 'ipv4', 'tcp'], 'actions': ['queue']}, @@ -1416,7 +1400,23 @@ class TestGeneric_flow_api(TestCase):
{'create': 'create', 'flows': ['vlan', 'ipv6', 'vf0'], 'actions': ['queue']},
{'create': 'create', 'flows': ['vlan', 'ipv6', 'tcp', 'vf1'], 'actions': ['queue']},
{'create': 'create', 'flows': ['vlan', 'ipv6', 'sctp'], 'actions': ['drop']},
- {'create': 'create', 'flows': ['vlan', 'ipv6', 'tcp', 'vf1'], 'actions': ['drop']}
+ {'create': 'create', 'flows': ['vlan', 'ipv6', 'tcp', 'vf1'], 'actions': ['drop']},
+ {'create': 'validate', 'flows': ['vlan', 'ipv4'], 'actions': ['queue']},
+ {'create': 'validate', 'flows': ['vlan', 'ipv4', 'udp'], 'actions': ['queue']},
+ {'create': 'validate', 'flows': ['vlan', 'ipv4', 'tcp'], 'actions': ['queue']},
+ {'create': 'validate', 'flows': ['vlan', 'ipv4', 'sctp'], 'actions': ['queue']},
+ {'create': 'validate', 'flows': ['vlan', 'ipv4', 'vf0'], 'actions': ['queue']},
+ {'create': 'validate', 'flows': ['vlan', 'ipv4', 'sctp', 'vf1'], 'actions': ['queue']},
+ {'create': 'validate', 'flows': ['vlan', 'ipv4', 'sctp'], 'actions': ['drop']},
+ {'create': 'validate', 'flows': ['vlan', 'ipv4', 'udp', 'vf1'], 'actions': ['drop']},
+ {'create': 'validate', 'flows': ['vlan', 'ipv6'], 'actions': ['queue']},
+ {'create': 'validate', 'flows': ['vlan', 'ipv6', 'udp'], 'actions': ['queue']},
+ {'create': 'validate', 'flows': ['vlan', 'ipv6', 'tcp'], 'actions': ['queue']},
+ {'create': 'validate', 'flows': ['vlan', 'ipv6', 'sctp'], 'actions': ['queue']},
+ {'create': 'validate', 'flows': ['vlan', 'ipv6', 'vf0'], 'actions': ['queue']},
+ {'create': 'validate', 'flows': ['vlan', 'ipv6', 'tcp', 'vf1'], 'actions': ['queue']},
+ {'create': 'validate', 'flows': ['vlan', 'ipv6', 'sctp'], 'actions': ['drop']},
+ {'create': 'validate', 'flows': ['vlan', 'ipv6', 'tcp',
+ 'vf1'], 'actions': ['drop']}
]
extrapkt_rulenum = self.all_flows_process(basic_flow_actions)
extra_packet = extrapkt_rulenum['extrapacket'] @@ -2264,17 +2264,6 @@ class TestGeneric_flow_api(TestCase):
# create the flow rules
basic_flow_actions = [
- {'create': 'validate', 'flows': ['ipv4', 'udp', 'vxlan', 'ineth'], 'actions': ['pf', 'queue']},
- {'create': 'validate', 'flows': ['ipv4', 'udp', 'vxlan', 'vni', 'ineth'], 'actions': ['pf', 'queue']},
- {'create': 'validate', 'flows': ['ipv4', 'udp', 'vxlan', 'ineth', 'invlan'], 'actions': ['pf', 'queue']},
- {'create': 'validate', 'flows': ['ipv4', 'udp', 'vxlan', 'vni', 'ineth', 'invlan'],
- 'actions': ['pf', 'queue']},
- {'create': 'validate', 'flows': ['dst_mac', 'ipv4', 'udp', 'vxlan', 'vni', 'ineth'],
- 'actions': ['pf', 'queue']},
- {'create': 'validate', 'flows': ['ipv4', 'udp', 'vxlan', 'vni', 'ineth', 'invlan'],
- 'actions': ['vf0', 'queue']},
- {'create': 'validate', 'flows': ['dst_mac', 'ipv4', 'udp', 'vxlan', 'vni', 'ineth'],
- 'actions': ['vf1', 'queue']},
{'create': 'create', 'flows': ['ipv4', 'udp', 'vxlan', 'ineth'], 'actions': ['pf', 'queue']},
{'create': 'create', 'flows': ['ipv4', 'udp', 'vxlan', 'vni', 'ineth'], 'actions': ['pf', 'queue']},
{'create': 'create', 'flows': ['ipv4', 'udp', 'vxlan', 'ineth', 'invlan'], 'actions': ['pf', 'queue']}, @@ -2286,6 +2275,17 @@ class TestGeneric_flow_api(TestCase):
'actions': ['vf0', 'queue']},
{'create': 'create', 'flows': ['dst_mac', 'ipv4', 'udp', 'vxlan', 'vni', 'ineth'],
'actions': ['vf1', 'queue']},
+ {'create': 'validate', 'flows': ['ipv4', 'udp', 'vxlan', 'ineth'], 'actions': ['pf', 'queue']},
+ {'create': 'validate', 'flows': ['ipv4', 'udp', 'vxlan', 'vni', 'ineth'], 'actions': ['pf', 'queue']},
+ {'create': 'validate', 'flows': ['ipv4', 'udp', 'vxlan', 'ineth', 'invlan'], 'actions': ['pf', 'queue']},
+ {'create': 'validate', 'flows': ['ipv4', 'udp', 'vxlan', 'vni', 'ineth', 'invlan'],
+ 'actions': ['pf', 'queue']},
+ {'create': 'validate', 'flows': ['dst_mac', 'ipv4', 'udp', 'vxlan', 'vni', 'ineth'],
+ 'actions': ['pf', 'queue']},
+ {'create': 'validate', 'flows': ['ipv4', 'udp', 'vxlan', 'vni', 'ineth', 'invlan'],
+ 'actions': ['vf0', 'queue']},
+ {'create': 'validate', 'flows': ['dst_mac', 'ipv4', 'udp', 'vxlan', 'vni', 'ineth'],
+ 'actions': ['vf1', 'queue']}
]
extrapkt_rulenum = self.all_flows_process(basic_flow_actions)
extra_packet = extrapkt_rulenum['extrapacket'] @@ -2338,13 +2338,6 @@ class TestGeneric_flow_api(TestCase):
# create the flow rules
basic_flow_actions = [
- {'create': 'validate', 'flows': ['ipv4', 'nvgre', 'ineth'], 'actions': ['pf', 'queue']},
- {'create': 'validate', 'flows': ['ipv4', 'nvgre', 'tni', 'ineth'], 'actions': ['pf', 'queue']},
- {'create': 'validate', 'flows': ['ipv4', 'nvgre', 'ineth', 'invlan'], 'actions': ['pf', 'queue']},
- {'create': 'validate', 'flows': ['ipv4', 'nvgre', 'tni', 'ineth', 'invlan'], 'actions': ['pf', 'queue']},
- {'create': 'validate', 'flows': ['dst_mac', 'ipv4', 'nvgre', 'tni', 'ineth'], 'actions': ['pf', 'queue']},
- {'create': 'validate', 'flows': ['ipv4', 'nvgre', 'tni', 'ineth', 'invlan'], 'actions': ['vf0', 'queue']},
- {'create': 'validate', 'flows': ['dst_mac', 'ipv4', 'nvgre', 'tni', 'ineth'], 'actions': ['vf1', 'queue']},
{'create': 'create', 'flows': ['ipv4', 'nvgre', 'ineth'], 'actions': ['pf', 'queue']},
{'create': 'create', 'flows': ['ipv4', 'nvgre', 'tni', 'ineth'], 'actions': ['pf', 'queue']},
{'create': 'create', 'flows': ['ipv4', 'nvgre', 'ineth', 'invlan'], 'actions': ['pf', 'queue']}, @@ -2352,6 +2345,13 @@ class TestGeneric_flow_api(TestCase):
{'create': 'create', 'flows': ['dst_mac', 'ipv4', 'nvgre', 'tni', 'ineth'], 'actions': ['pf', 'queue']},
{'create': 'create', 'flows': ['ipv4', 'nvgre', 'tni', 'ineth', 'invlan'], 'actions': ['vf0', 'queue']},
{'create': 'create', 'flows': ['dst_mac', 'ipv4', 'nvgre', 'tni', 'ineth'], 'actions': ['vf1', 'queue']},
+ {'create': 'validate', 'flows': ['ipv4', 'nvgre', 'ineth'], 'actions': ['pf', 'queue']},
+ {'create': 'validate', 'flows': ['ipv4', 'nvgre', 'tni', 'ineth'], 'actions': ['pf', 'queue']},
+ {'create': 'validate', 'flows': ['ipv4', 'nvgre', 'ineth', 'invlan'], 'actions': ['pf', 'queue']},
+ {'create': 'validate', 'flows': ['ipv4', 'nvgre', 'tni', 'ineth', 'invlan'], 'actions': ['pf', 'queue']},
+ {'create': 'validate', 'flows': ['dst_mac', 'ipv4', 'nvgre', 'tni', 'ineth'], 'actions': ['pf', 'queue']},
+ {'create': 'validate', 'flows': ['ipv4', 'nvgre', 'tni', 'ineth', 'invlan'], 'actions': ['vf0', 'queue']},
+ {'create': 'validate', 'flows': ['dst_mac', 'ipv4',
+ 'nvgre', 'tni', 'ineth'], 'actions': ['vf1', 'queue']}
]
extrapkt_rulenum = self.all_flows_process(basic_flow_actions)
extra_packet = extrapkt_rulenum['extrapacket']
--
1.8.3.1
next prev parent reply other threads:[~2020-09-29 1:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-27 8:25 Zhou, Junx
2020-09-27 8:35 ` Zhou, JunX W
2020-09-29 1:55 ` Peng, Yuan [this message]
2020-10-13 0:58 ` Tu, Lijuan
2020-10-27 4:57 ` Tu, Lijuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN6PR11MB1841BA481D334E4524E97146FE320@BN6PR11MB1841.namprd11.prod.outlook.com \
--to=yuan.peng@intel.com \
--cc=dts@dpdk.org \
--cc=junx.w.zhou@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).