test suite reviews and discussions
 help / color / mirror / Atom feed
* Re: [dts] [PATCH] test_plans/kernelpf_iavf: complete mac filter case
  2021-09-15  8:50 [dts] [PATCH] test_plans/kernelpf_iavf: complete mac filter case Lijuan Tu
@ 2021-09-15  5:14 ` Lin, Xueqin
  0 siblings, 0 replies; 2+ messages in thread
From: Lin, Xueqin @ 2021-09-15  5:14 UTC (permalink / raw)
  To: Tu, Lijuan; +Cc: dts


> -----Original Message-----
> From: Tu, Lijuan <lijuan.tu@intel.com>
> Sent: Wednesday, September 15, 2021 4:51 PM
> To: Lin, Xueqin <xueqin.lin@intel.com>
> Cc: dts@dpdk.org; Tu, Lijuan <lijuan.tu@intel.com>
> Subject: [PATCH] test_plans/kernelpf_iavf: complete mac filter case
> 
> the test case for mac filter missed some example for packets.
> so fill them out and users could easily understand.
> 
> Signed-off-by: Lijuan Tu <lijuan.tu@intel.com>
Acked-by: Xueqin Lin <xueqin.lin@intel.com>
> ---
>  test_plans/kernelpf_iavf_test_plan.rst | 14 +++++++++++---
>  1 file changed, 11 insertions(+), 3 deletions(-)
> 
> diff --git a/test_plans/kernelpf_iavf_test_plan.rst
> b/test_plans/kernelpf_iavf_test_plan.rst
> index 2b5a785..4351f79 100644
> --- a/test_plans/kernelpf_iavf_test_plan.rst
> +++ b/test_plans/kernelpf_iavf_test_plan.rst
> @@ -95,7 +95,9 @@ Disable promisc mode, add a new MAC to VF0 and then
> start testpmd::
>      testpmd> start
> 
>  Use scapy to send 100 random packets with current VF0's MAC, verify the -
> packets can be received and forwarded by the VF
> +packets can be received and forwarded by the VF::
> +
> +    p=Ether(dst="00:01:23:45:67:89")/IP()/Raw(load='X'*30)
> 
>  Use scapy to send 100 random packets with new added VF0's MAC, verify
> the  packets can be received and forwarded by the VF::
> @@ -112,6 +114,8 @@ Remove the MAC 00:11:22:33:44:55::
>  Use scapy to send 100 random packets with removed VF0's MAC, verify the
> packets can't be received and forwarded by the VF::
> 
> +    p=Ether(dst="00:11:22:33:44:55")/IP()/Raw(load='X'*30)
> +
>  Set the default mac address to other mac, check the mac address has be
> changed  to new set mac::
> 
> @@ -119,10 +123,14 @@ to new set mac::
>      testpmd> show port info 0
> 
>  Use scapy to send 100 random packets with original VF0's MAC, verify the -
> packets can't be received and forwarded by the VF
> +packets can't be received and forwarded by the VF::
> +
> +    p=Ether(dst="00:01:23:45:67:89")/IP()/Raw(load='X'*30)
> 
>  Use scapy to send 100 random packets with new set VF0's MAC, verify the -
> packets can be received and forwarded by the VF
> +packets can be received and forwarded by the VF::
> +
> +    p=Ether(dst="00:01:23:45:67:11")/IP()/Raw(load='X'*30)
> 
>  Reset to original mac address
> 
> --
> 1.8.3.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [dts] [PATCH] test_plans/kernelpf_iavf: complete mac filter case
@ 2021-09-15  8:50 Lijuan Tu
  2021-09-15  5:14 ` Lin, Xueqin
  0 siblings, 1 reply; 2+ messages in thread
From: Lijuan Tu @ 2021-09-15  8:50 UTC (permalink / raw)
  To: xueqin.lin; +Cc: dts, Lijuan Tu

the test case for mac filter missed some example for packets.
so fill them out and users could easily understand.

Signed-off-by: Lijuan Tu <lijuan.tu@intel.com>
---
 test_plans/kernelpf_iavf_test_plan.rst | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/test_plans/kernelpf_iavf_test_plan.rst b/test_plans/kernelpf_iavf_test_plan.rst
index 2b5a785..4351f79 100644
--- a/test_plans/kernelpf_iavf_test_plan.rst
+++ b/test_plans/kernelpf_iavf_test_plan.rst
@@ -95,7 +95,9 @@ Disable promisc mode, add a new MAC to VF0 and then start testpmd::
     testpmd> start
 
 Use scapy to send 100 random packets with current VF0's MAC, verify the
-packets can be received and forwarded by the VF
+packets can be received and forwarded by the VF::
+
+    p=Ether(dst="00:01:23:45:67:89")/IP()/Raw(load='X'*30)
 
 Use scapy to send 100 random packets with new added VF0's MAC, verify the
 packets can be received and forwarded by the VF::
@@ -112,6 +114,8 @@ Remove the MAC 00:11:22:33:44:55::
 Use scapy to send 100 random packets with removed VF0's MAC, verify the
 packets can't be received and forwarded by the VF::
 
+    p=Ether(dst="00:11:22:33:44:55")/IP()/Raw(load='X'*30)
+
 Set the default mac address to other mac, check the mac address has be changed
 to new set mac::
 
@@ -119,10 +123,14 @@ to new set mac::
     testpmd> show port info 0
 
 Use scapy to send 100 random packets with original VF0's MAC, verify the
-packets can't be received and forwarded by the VF
+packets can't be received and forwarded by the VF::
+
+    p=Ether(dst="00:01:23:45:67:89")/IP()/Raw(load='X'*30)
 
 Use scapy to send 100 random packets with new set VF0's MAC, verify the
-packets can be received and forwarded by the VF
+packets can be received and forwarded by the VF::
+
+    p=Ether(dst="00:01:23:45:67:11")/IP()/Raw(load='X'*30)
 
 Reset to original mac address
 
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-09-15  5:14 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-15  8:50 [dts] [PATCH] test_plans/kernelpf_iavf: complete mac filter case Lijuan Tu
2021-09-15  5:14 ` Lin, Xueqin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).