test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Ma, LihongX" <lihongx.ma@intel.com>
To: Owen Hilyard <ohilyard@iol.unh.edu>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Zhang, Yuwei1" <yuwei1.zhang@intel.com>,
	"changqingx.wu@intel.com" <changqingx.wu@intel.com>,
	"Xiao, QimaiX" <qimaix.xiao@intel.com>,
	"Hunt, David" <david.hunt@intel.com>,
	"lylavoie@iol.unh.edu" <lylavoie@iol.unh.edu>
Subject: Re: [dts] [PATCH] rx interrupt: Fixed test case
Date: Wed, 2 Sep 2020 02:01:58 +0000	[thread overview]
Message-ID: <BN8PR11MB3715545FE5ACBB11672122A49E2F0@BN8PR11MB3715.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200826150429.278284-1-ohilyard@iol.unh.edu>

Hi, Owen
I think the change of the plan is not make sense, the case ' PF interrupt pmd with different queue' is want to test the interrupt on different queue,
The original case will test the queue on min number, max number and normal number(between minimum and maximum), but your patch will only test one situation.


Regards,
Ma,lihong

> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Owen Hilyard
> Sent: Wednesday, August 26, 2020 11:04 PM
> To: dts@dpdk.org
> Cc: Zhang, Yuwei1 <yuwei1.zhang@intel.com>; changqingx.wu@intel.com; Xiao,
> QimaiX <qimaix.xiao@intel.com>; Hunt, David <david.hunt@intel.com>;
> lylavoie@iol.unh.edu; Owen Hilyard <ohilyard@iol.unh.edu>
> Subject: [dts] [PATCH] rx interrupt: Fixed test case
> 
> fixed test case issues with eal params
> removed extra instances of l3fwd-power
> 
> Signed-off-by: Owen Hilyard <ohilyard@iol.unh.edu>
> ---
>  test_plans/interrupt_pmd_test_plan.rst | 58 +++++++++-----------
>  tests/TestSuite_interrupt_pmd.py       | 73 ++++++++++++++------------
>  2 files changed, 64 insertions(+), 67 deletions(-)
> 
> diff --git a/test_plans/interrupt_pmd_test_plan.rst
> b/test_plans/interrupt_pmd_test_plan.rst
> index cb8b2f1..1f8816d 100644
> --- a/test_plans/interrupt_pmd_test_plan.rst
> +++ b/test_plans/interrupt_pmd_test_plan.rst


  reply	other threads:[~2020-09-02  2:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-26 15:04 Owen Hilyard
2020-09-02  2:01 ` Ma, LihongX [this message]
2020-09-02 18:42   ` Owen Hilyard
2020-09-09  5:58     ` Tu, Lijuan
2020-09-11 20:17       ` Owen Hilyard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BN8PR11MB3715545FE5ACBB11672122A49E2F0@BN8PR11MB3715.namprd11.prod.outlook.com \
    --to=lihongx.ma@intel.com \
    --cc=changqingx.wu@intel.com \
    --cc=david.hunt@intel.com \
    --cc=dts@dpdk.org \
    --cc=lylavoie@iol.unh.edu \
    --cc=ohilyard@iol.unh.edu \
    --cc=qimaix.xiao@intel.com \
    --cc=yuwei1.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).