test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Ma, LihongX" <lihongx.ma@intel.com>
To: "Xie, WeiX" <weix.xie@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Xie, WeiX" <weix.xie@intel.com>
Subject: Re: [dts] [PATCH V1 2/2] tests/TestSuite_kernelpf_iavf:adapt to I40E	driver update
Date: Fri, 30 Oct 2020 01:56:33 +0000	[thread overview]
Message-ID: <BN8PR11MB3715B7B8766CE355945E9B2D9E150@BN8PR11MB3715.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20201029074008.29911-2-weix.xie@intel.com>


> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Xie wei
> Sent: Thursday, October 29, 2020 3:40 PM
> To: dts@dpdk.org
> Cc: Xie, WeiX <weix.xie@intel.com>
> Subject: [dts] [PATCH V1 2/2] tests/TestSuite_kernelpf_iavf:adapt to I40E
> driver update
> 
> *Update i40e driver to 2.13.10, while vlan tag is removed, the pkts with
> vlan tag shall not be received.
> 
> Signed-off-by: Xie wei <weix.xie@intel.com>
> ---
>  tests/TestSuite_kernelpf_iavf.py | 28 ++++++++++++++++++++++------
>  1 file changed, 22 insertions(+), 6 deletions(-)
> 
> diff --git a/tests/TestSuite_kernelpf_iavf.py
> b/tests/TestSuite_kernelpf_iavf.py
> index da925109..adeac42f 100644
> --- a/tests/TestSuite_kernelpf_iavf.py
> +++ b/tests/TestSuite_kernelpf_iavf.py
> @@ -428,8 +428,12 @@ class TestKernelpfIavf(TestCase):
>          out = self.send_and_getout(vlan=random_vlan, pkt_type="VLAN_UDP")
>          tcpdump_out = self.get_tcpdump_package()
>          receive_pkt = re.findall('vlan %s' % random_vlan, tcpdump_out)
> -        self.verify(len(receive_pkt) == 2, "fail to tester received vlan
> packet!!!")
> -        self.verify(self.vf_mac in out, "Failed to received vlan
> packet!!!")
> +        if self.kdriver == 'ice':
> +            self.verify(len(receive_pkt) == 2, "fail to tester received
> vlan packet!!!")
> +            self.verify(self.vf_mac in out, "Failed to received vlan
> packet!!!")
> +        else:
> +            self.verify(len(receive_pkt) == 1, "fail to tester received
> vlan packet!!!")
> +            self.verify(self.vf_mac not in out, "Received vlan
> + packet!!!")

Some of the cases not set the cmd 'vlan filter on' , the modify do not match your description ,please check it.


Regards,
Ma,lihong


  parent reply	other threads:[~2020-10-30  1:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-29  7:40 [dts] [PATCH V1 1/2] tests/TestSuite_vf_vlan:adapt " Xie wei
2020-10-29  7:40 ` [dts] [PATCH V1 2/2] tests/TestSuite_kernelpf_iavf:adapt " Xie wei
2020-10-29  8:02   ` Xie, WeiX
2020-10-30  1:56   ` Ma, LihongX [this message]
2020-10-29  8:00 ` [dts] [PATCH V1 1/2] tests/TestSuite_vf_vlan:adapt " Xie, WeiX
2020-10-30  1:52 ` Ma, LihongX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BN8PR11MB3715B7B8766CE355945E9B2D9E150@BN8PR11MB3715.namprd11.prod.outlook.com \
    --to=lihongx.ma@intel.com \
    --cc=dts@dpdk.org \
    --cc=weix.xie@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).