test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Ma, LihongX" <lihongx.ma@intel.com>
To: "Jiang, YuX" <yux.jiang@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Jiang, YuX" <yux.jiang@intel.com>
Subject: Re: [dts] [PATCH V1 2/2] tests/TestSuite_vm2vm_virtio_user: Adapt	RTE_LIBRTE_PMD_PCAP updates
Date: Thu, 29 Oct 2020 08:10:28 +0000	[thread overview]
Message-ID: <BN8PR11MB3715E3AEB1320C57863227C69E140@BN8PR11MB3715.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20201023154828.1274699-3-yux.jiang@intel.com>


> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of JiangYuX
> Sent: Friday, October 23, 2020 11:48 PM
> To: dts@dpdk.org
> Cc: Jiang, YuX <yux.jiang@intel.com>
> Subject: [dts] [PATCH V1 2/2] tests/TestSuite_vm2vm_virtio_user: Adapt
> RTE_LIBRTE_PMD_PCAP updates
> 
> From: JiangYu <yux.jiang@intel.com>
> 
> For DPDK commit: b0b672aea, PMD_PCAP has been defined by default, should
> not redefine.
> 
> Signed-off-by: JiangYu <yux.jiang@intel.com>
> ---
>  tests/TestSuite_vm2vm_virtio_user.py | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/tests/TestSuite_vm2vm_virtio_user.py
> b/tests/TestSuite_vm2vm_virtio_user.py
> index d2dfb97..b35dc60 100644
> --- a/tests/TestSuite_vm2vm_virtio_user.py
> +++ b/tests/TestSuite_vm2vm_virtio_user.py
> @@ -99,11 +99,13 @@ class TestVM2VMVirtioUser(TestCase):
>          """
>          enable pcap lib in dpdk code and recompile
>          """
> -        client_dut.send_expect("sed -i 's/%s=n$/%s=y/'
> config/common_base" % (
> +        if self.dut.build_type == 'makefile':
> +            client_dut.send_expect("sed -i 's/%s=n$/%s=y/'
> config/common_base" % (
>                      self.config_value, self.config_value), '# ')
> -        client_dut.set_build_options({'RTE_LIBRTE_PMD_PCAP': 'y'})
> -        client_dut.build_install_dpdk(self.target)
> -        self.rebuild_flag = True
> +            client_dut.build_install_dpdk(self.target)
> +            self.rebuild_flag = True
> +        else:
> +            self.rebuild_flag = False
> 
>      def disable_pcap_lib_in_dpdk(self, client_dut):
>          """
> --
> 2.7.4

As now makefile have been remove from dpdk, I think you can delete them directly.

Regards,
Ma,lihong

      reply	other threads:[~2020-10-29  8:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-23 15:48 [dts] [PATCH V1 0/2] " JiangYuX
2020-10-23  7:53 ` Jiang, YuX
2020-10-23 15:48 ` [dts] [PATCH V1 1/2] tests/TestSuite_vm2vm_virtio_pmd: " JiangYuX
2020-10-23 15:48 ` [dts] [PATCH V1 2/2] tests/TestSuite_vm2vm_virtio_user: " JiangYuX
2020-10-29  8:10   ` Ma, LihongX [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BN8PR11MB3715E3AEB1320C57863227C69E140@BN8PR11MB3715.namprd11.prod.outlook.com \
    --to=lihongx.ma@intel.com \
    --cc=dts@dpdk.org \
    --cc=yux.jiang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).