From: "Dong, JunX" <junx.dong@intel.com>
To: "Juraj Linkeš" <juraj.linkes@pantheon.tech>,
"Tu, Lijuan" <lijuan.tu@intel.com>,
"ohilyard@iol.unh.edu" <ohilyard@iol.unh.edu>
Cc: "dts@dpdk.org" <dts@dpdk.org>
Subject: RE: [PATCH v1] framework/dut: fix pylama errors
Date: Fri, 7 Jan 2022 07:42:08 +0000 [thread overview]
Message-ID: <BN9PR11MB52747CE6E1F1147A53BA69A8EA4D9@BN9PR11MB5274.namprd11.prod.outlook.com> (raw)
In-Reply-To: <1638792877-2000-1-git-send-email-juraj.linkes@pantheon.tech>
On Monday, December 6, 2021 8:15 PM Juraj Linkeš <juraj.linkes@pantheon.tech> wrote:
> 628,7 +643,7 @@ class Dut(Crb):
> if pci_bus == port_info['pci']:
> port = port_info['port']
> break
> - if port and port.get_ipv4_addr() == crbs['IP'].strip():
> + if port and port.get_ipv4_addr() == self.crb['IP'].strip():
Suggest use get_ip_address instance method to get crb IP, not access inner date structure directly.
> return True
> else:
> return False
--
Dong Jun
next prev parent reply other threads:[~2022-01-07 7:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-06 12:14 Juraj Linkeš
2021-12-06 13:55 ` David Marchand
2022-01-18 13:59 ` Juraj Linkeš
2022-01-07 7:42 ` Dong, JunX [this message]
2022-01-19 12:05 ` [PATCH v2] " Juraj Linkeš
2022-01-25 3:30 ` Dong, JunX
2022-01-25 6:02 ` Tu, Lijuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN9PR11MB52747CE6E1F1147A53BA69A8EA4D9@BN9PR11MB5274.namprd11.prod.outlook.com \
--to=junx.dong@intel.com \
--cc=dts@dpdk.org \
--cc=juraj.linkes@pantheon.tech \
--cc=lijuan.tu@intel.com \
--cc=ohilyard@iol.unh.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).