test suite reviews and discussions
 help / color / mirror / Atom feed
* [PATCH v1] framework/qemu_kvm: fix pylama errors
@ 2021-12-06 12:21 Juraj Linkeš
  2021-12-16  3:15 ` Dong, JunX
  0 siblings, 1 reply; 2+ messages in thread
From: Juraj Linkeš @ 2021-12-06 12:21 UTC (permalink / raw)
  To: lijuan.tu, ohilyard; +Cc: dts, Juraj Linkeš

Pylama found the following errors:
framework/qemu_kvm.py:1498: [E] E0602 Undefined variable 'assgined_pcis_info' [pylint]
framework/qemu_kvm.py:1508: [E] E0602 Undefined variable 'assinged_pcis_info' [pylint]
framework/qemu_kvm.py:1508: [E] E1101 Instance of 'QEMUKvm' has no '__vf_has_been_assinged' member [pylint]
framework/qemu_kvm.py:1587: [E] E1121 Too many positional arguments for method call [pylint]
framework/qemu_kvm.py:1733: [E] E0213 Method should have "self" as first argument [pylint]
framework/qemu_kvm.py:1750: [E] E1102 func is not callable [pylint]

Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
---
Lijuan, please add additional people to review if needed.
---
 framework/qemu_kvm.py | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/framework/qemu_kvm.py b/framework/qemu_kvm.py
index 515a4c04..32cd668e 100644
--- a/framework/qemu_kvm.py
+++ b/framework/qemu_kvm.py
@@ -1495,7 +1495,7 @@ class QEMUKvm(VirtBase):
             if self.__is_vf_pci(pci):
                 assigned_pcis_info[pci]['is_vf'] = True
                 pf_pci = self.__map_vf_to_pf(pci)
-                assgined_pcis_info[pci]['pf_pci'] = pf_pci
+                assigned_pcis_info[pci]['pf_pci'] = pf_pci
                 if self.virt_pool.alloc_vf_from_pf(vm=self.vm_name,
                                                    pf_pci=pf_pci,
                                                    *[pci]):
@@ -1505,7 +1505,7 @@ class QEMUKvm(VirtBase):
             else:
                 # check that if any VF of specified PF has been
                 # used, raise exception
-                vf_pci = self.__vf_has_been_assinged(pci, **assinged_pcis_info)
+                vf_pci = self.__vf_has_been_assigned(pci, **assigned_pcis_info)
                 if vf_pci:
                     raise Exception(
                         "Error: A VF [%s] generated by PF [%s] has " %
@@ -1584,7 +1584,7 @@ class QEMUKvm(VirtBase):
         """
         Get IP which VM is connected by bridge.
         """
-        out = self.control_command('ping', '60')
+        out = self.control_command('ping')
         if not out:
             time.sleep(10)
             out = self.control_command('ifconfig')
@@ -1730,6 +1730,7 @@ class QEMUKvm(VirtBase):
 
         return cores
 
+    @staticmethod
     def handle_control_session(func):
         """
         Wrapper function to handle serial port, must return serial to host session
-- 
2.20.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* RE: [PATCH v1] framework/qemu_kvm: fix pylama errors
  2021-12-06 12:21 [PATCH v1] framework/qemu_kvm: fix pylama errors Juraj Linkeš
@ 2021-12-16  3:15 ` Dong, JunX
  0 siblings, 0 replies; 2+ messages in thread
From: Dong, JunX @ 2021-12-16  3:15 UTC (permalink / raw)
  To: Juraj Linkeš, Tu, Lijuan, ohilyard; +Cc: dts



> -----Original Message-----
> From: Juraj Linkeš <juraj.linkes@pantheon.tech>
> Sent: Monday, December 6, 2021 8:22 PM
> To: Tu, Lijuan <lijuan.tu@intel.com>; ohilyard@iol.unh.edu
> Cc: dts@dpdk.org; Juraj Linkeš <juraj.linkes@pantheon.tech>
> Subject: [PATCH v1] framework/qemu_kvm: fix pylama errors
> 
> Pylama found the following errors:
> framework/qemu_kvm.py:1498: [E] E0602 Undefined variable
> 'assgined_pcis_info' [pylint]
> framework/qemu_kvm.py:1508: [E] E0602 Undefined variable
> 'assinged_pcis_info' [pylint]
> framework/qemu_kvm.py:1508: [E] E1101 Instance of 'QEMUKvm' has no
> '__vf_has_been_assinged' member [pylint]
> framework/qemu_kvm.py:1587: [E] E1121 Too many positional arguments
> for method call [pylint]
> framework/qemu_kvm.py:1733: [E] E0213 Method should have "self" as first
> argument [pylint]
> framework/qemu_kvm.py:1750: [E] E1102 func is not callable [pylint]
> 
> Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
> ---
> Lijuan, please add additional people to review if needed.
> ---
>  framework/qemu_kvm.py | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/framework/qemu_kvm.py b/framework/qemu_kvm.py index
> 515a4c04..32cd668e 100644
> --- a/framework/qemu_kvm.py
> +++ b/framework/qemu_kvm.py
> @@ -1495,7 +1495,7 @@ class QEMUKvm(VirtBase):
>              if self.__is_vf_pci(pci):
>                  assigned_pcis_info[pci]['is_vf'] = True
>                  pf_pci = self.__map_vf_to_pf(pci)
> -                assgined_pcis_info[pci]['pf_pci'] = pf_pci
> +                assigned_pcis_info[pci]['pf_pci'] = pf_pci
>                  if self.virt_pool.alloc_vf_from_pf(vm=self.vm_name,
>                                                     pf_pci=pf_pci,
>                                                     *[pci]):
> @@ -1505,7 +1505,7 @@ class QEMUKvm(VirtBase):
>              else:
>                  # check that if any VF of specified PF has been
>                  # used, raise exception
> -                vf_pci = self.__vf_has_been_assinged(pci, **assinged_pcis_info)
> +                vf_pci = self.__vf_has_been_assigned(pci,
> + **assigned_pcis_info)
>                  if vf_pci:
>                      raise Exception(
>                          "Error: A VF [%s] generated by PF [%s] has " % @@ -1584,7
> +1584,7 @@ class QEMUKvm(VirtBase):
>          """
>          Get IP which VM is connected by bridge.
>          """
> -        out = self.control_command('ping', '60')
> +        out = self.control_command('ping')
>          if not out:
>              time.sleep(10)
>              out = self.control_command('ifconfig') @@ -1730,6 +1730,7 @@ class
> QEMUKvm(VirtBase):
> 
>          return cores
> 
> +    @staticmethod

Because below method used as decorator, so if it was decorated by staticmethod description, it will introduce issues same as nics/net_device module.

>      def handle_control_session(func):
>          """
>          Wrapper function to handle serial port, must return serial to host session
> --
> 2.20.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-12-16  3:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-06 12:21 [PATCH v1] framework/qemu_kvm: fix pylama errors Juraj Linkeš
2021-12-16  3:15 ` Dong, JunX

test suite reviews and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git