test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts][PATCH V1] test/rxtx_offload:remove jumboframe test
@ 2021-11-11 16:02 Lewei Yang
  2021-11-15 10:04 ` Jiang, YuX
  2021-11-22 14:27 ` Tu, Lijuan
  0 siblings, 2 replies; 4+ messages in thread
From: Lewei Yang @ 2021-11-11 16:02 UTC (permalink / raw)
  To: dts; +Cc: Lewei Yang

According to dpdk commit b563c1421282("ethdev: remove jumbo offload flag"),
'DEV_RX_OFFLOAD_JUMBO_FRAME' offload flag has been removed,so remove jumboframe related tests

Signed-off-by: Lewei Yang <leweix.yang@intel.com>
---
 test_plans/rxtx_offload_test_plan.rst | 79 ---------------------------
 tests/TestSuite_rxtx_offload.py       | 49 -----------------
 2 files changed, 128 deletions(-)

diff --git a/test_plans/rxtx_offload_test_plan.rst b/test_plans/rxtx_offload_test_plan.rst
index 383208dc..faa60de3 100644
--- a/test_plans/rxtx_offload_test_plan.rst
+++ b/test_plans/rxtx_offload_test_plan.rst
@@ -108,85 +108,6 @@ Prerequisites
 Rx Offload
 ==========
 
-Test case: Rx offload per-port setting
-======================================
-
-1. Enable jumboframe when start testpmd::
-
-    ./testpmd -c f -n 4 -- -i --rxq=4 --txq=4 --max-pkt-len=9000
-    testpmd> set fwd rxonly
-    testpmd> set verbose 1
-    testpmd> start
-    testpmd> show port 0 rx_offload configuration
-    Rx Offloading Configuration of port 0 :
-      Port : JUMBO_FRAME
-      Queue[ 0] :
-      Queue[ 1] :
-      Queue[ 2] :
-      Queue[ 3] :
-
-2. Increase the tester ports's mtu::
-
-    ifconfig enp131s0f0 mtu 9200
-    ifconfig enp131s0f1 mtu 9200
-
-   Send a jumboframe packet::
-
-    pkt1 = Ether(dst="52:54:00:00:00:01", src="52:00:00:00:00:00")/IP(dst="192.168.0.1", src="192.168.0.2", len=8981)/Raw(load="P"*8961)
-    pkt2 = Ether(dst="52:54:00:00:00:01", src="52:00:00:00:00:00")/IP(dst="192.168.0.1", src="192.168.0.3", len=8981)/Raw(load="P"*8961)
-
-   pkt1 was distributed to queue 1, pkt2 was distributed to queue 0.
-
-3. Failed to disable jumboframe per_queue::
-
-    testpmd> port stop 0
-    testpmd> port 0 rxq 1 rx_offload jumbo_frame off
-    testpmd> port start 0
-
-   The port can be started normally, but the setting doesn't take effect.
-   Pkt1 still can be distributed to queue 1.
-
-4. Succeed to disable jumboframe per_port::
-
-    testpmd> port stop 0
-    testpmd> port config 0 rx_offload jumbo_frame off
-    testpmd> port start 0
-    testpmd> show port 0 rx_offload configuration
-    Rx Offloading Configuration of port 0 :
-      Port :
-      Queue[ 0] :
-      Queue[ 1] :
-      Queue[ 2] :
-      Queue[ 3] :
-    testpmd> start
-
-   Send the same two packet, there is no packet received.
-
-5. Failed to enable jumboframe per_queue::
-
-    testpmd> port stop 0
-    testpmd> port 0 rxq 1 rx_offload jumbo_frame on
-    testpmd> port start 0
-    Configuring Port 0 (socket 0)
-    Ethdev port_id=0 rx_queue_id=1, new added offloads 0x800 must be within pre-queue offload capabilities 0x1 in rte_eth_rx_queue_setup()
-    Fail to configure port 0 rx queues
-
-6. Succeed to enable jumboframe per_port::
-
-    testpmd> port stop 0
-    testpmd> port config 0 rx_offload jumbo_frame on
-    testpmd> port start 0
-    testpmd> show port 0 rx_offload configuration
-    Rx Offloading Configuration of port 0 :
-      Port : JUMBO_FRAME
-      Queue[ 0] : JUMBO_FRAME
-      Queue[ 1] : JUMBO_FRAME
-      Queue[ 2] : JUMBO_FRAME
-      Queue[ 3] : JUMBO_FRAME
-
-   Send the same two packet, pkt1 was distributed to queue 1,
-   pkt2 was distributed to queue 0.
-
 Test case: Rx offload per-port setting in command-line
 ======================================================
 
diff --git a/tests/TestSuite_rxtx_offload.py b/tests/TestSuite_rxtx_offload.py
index 14fd40ac..6bb8f730 100644
--- a/tests/TestSuite_rxtx_offload.py
+++ b/tests/TestSuite_rxtx_offload.py
@@ -71,7 +71,6 @@ offloads = {'mbuf_fast_free': 'MBUF_FAST_FREE',
             'qinq_strip': 'QINQ_STRIP',
             'vlan_filter': 'VLAN_FILTER',
             'vlan_extend': 'VLAN_EXTEND',
-            'jumboframe': 'JUMBO_FRAME',
             'scatter': 'SCATTER',
             'keep_crc': 'KEEP_CRC',
             'macsec_strip': 'MACSEC_STRIP'
@@ -344,54 +343,6 @@ class TestRxTx_Offload(TestCase):
         self.tester.send_expect("killall tcpdump", "#")
         return self.tester.send_expect("tcpdump -nn -e -v -c 1024 -r ./getPackageByTcpdump.cap", "#", 120)
 
-    def test_rxoffload_port(self):
-        """
-        Set Rx offload by port.
-        """
-        # Define jumboframe packets
-        self.jumbo_pkt1 = r'sendp([Ether(dst="%s")/IP(dst="192.168.0.1",src="192.168.0.2", len=8981)/Raw(load="P"*8961)], iface="%s")' % (self.pf_mac, self.tester_itf0)
-        self.jumbo_pkt2 = r'sendp([Ether(dst="%s")/IP(dst="192.168.0.1",src="192.168.0.3", len=8981)/Raw(load="P"*8961)], iface="%s")' % (self.pf_mac, self.tester_itf0)
-
-        self.pmdout.start_testpmd("%s" % self.cores, "--rxq=4 --txq=4 --max-pkt-len=9000")
-        self.dut.send_expect("set fwd rxonly", "testpmd> ")
-        self.dut.send_expect("set verbose 1", "testpmd> ")
-        offload = ['jumboframe']
-        self.check_port_config("rx", offload)
-        self.tester.send_expect("ifconfig %s mtu %s" % (self.tester_itf0, ETHER_JUMBO_FRAME_MTU), "# ")
-        self.tester.send_expect("ifconfig %s mtu %s" % (self.tester_itf1, ETHER_JUMBO_FRAME_MTU), "# ")
-
-        pkt1_queue = self.get_queue_number(self.jumbo_pkt1)
-        pkt2_queue = self.get_queue_number(self.jumbo_pkt2)
-
-        # Failed to disable jumboframe per_queue, foxvillee 2.5g not support
-        if self.nic != 'foxville':
-            self.dut.send_expect("port stop 0", "testpmd> ")
-            self.dut.send_expect("port 0 rxq %s rx_offload jumbo_frame off" % pkt1_queue, "testpmd> ")
-            self.verify_result(self.jumbo_pkt1, 1, pkt1_queue)
-
-        # Succeed to disable jumboframe per_port
-        self.dut.send_expect("port stop 0", "testpmd> ")
-        self.dut.send_expect("port config 0 rx_offload jumbo_frame off", "testpmd> ")
-        self.check_port_config("rx", "NULL")
-        self.verify_result(self.jumbo_pkt1, 0, pkt1_queue)
-        self.verify_result(self.jumbo_pkt2, 0, pkt2_queue)
-
-        # Failed to enable jumboframe per_queue
-        self.dut.send_expect("port stop 0", "testpmd> ")
-        self.dut.send_expect("port 0 rxq %s rx_offload jumbo_frame on" % pkt1_queue, "testpmd> ")
-        outstring = self.dut.send_expect("port start 0", "testpmd> ")
-        self.verify("Fail" in outstring, "jumboframe can be set by queue.")
-
-        # Succeed to enable jumboframe per_port
-        self.dut.send_expect("port stop 0", "testpmd> ")
-        self.dut.send_expect("port config 0 rx_offload jumbo_frame on", "testpmd> ")
-        self.check_port_config("rx", offload)
-        self.verify_result(self.jumbo_pkt1, 1, pkt1_queue)
-        self.verify_result(self.jumbo_pkt2, 1, pkt2_queue)
-
-        self.tester.send_expect("ifconfig %s mtu %s" % (self.tester_itf0, ETHER_STANDARD_MTU), "# ")
-        self.tester.send_expect("ifconfig %s mtu %s" % (self.tester_itf1, ETHER_STANDARD_MTU), "# ")
-
     def test_rxoffload_port_cmdline(self):
         """
         Set Rx offload by port in cmdline.
-- 
2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: [dts][PATCH V1] test/rxtx_offload:remove jumboframe test
  2021-11-11 16:02 [dts][PATCH V1] test/rxtx_offload:remove jumboframe test Lewei Yang
@ 2021-11-15 10:04 ` Jiang, YuX
  2021-11-22 14:27 ` Tu, Lijuan
  1 sibling, 0 replies; 4+ messages in thread
From: Jiang, YuX @ 2021-11-15 10:04 UTC (permalink / raw)
  To: Yang, LeweiX, dts; +Cc: Yang, LeweiX

> -----Original Message-----
> From: Lewei Yang <leweix.yang@intel.com>
> Sent: Friday, November 12, 2021 12:03 AM
> To: dts@dpdk.org
> Cc: Yang, LeweiX <leweix.yang@intel.com>
> Subject: [dts][PATCH V1] test/rxtx_offload:remove jumboframe test
> 
> According to dpdk commit b563c1421282("ethdev: remove jumbo offload
> flag"), 'DEV_RX_OFFLOAD_JUMBO_FRAME' offload flag has been
> removed,so remove jumboframe related tests
> 
> Signed-off-by: Lewei Yang <leweix.yang@intel.com>
> ---
Tested-by: Lewei Yang <leweix.yang@intel.com>

ci/Intel-dts-suite-test	fai, due to dts patch http://patchwork.dpdk.org/project/dts/patch/20211112164959.107746-1-leweix.yang@intel.com/  is not merged.
	Detail test results:
	+---------------------------------------------+------------+---------------+
	| suit/case                                   | with_patch | without_patch |
	+---------------------------------------------+------------+---------------+
	| rxtx_offload/test_rxoffload_port            | n/a        | failed        |
	| rxtx_offload/test_rxoffload_port_all        | failed     | failed        |
	| rxtx_offload/test_rxoffload_port_cmdline    | failed     | failed        |
	| rxtx_offload/test_txoffload_port            | passed     | passed        |
	| rxtx_offload/test_txoffload_port_checksum   | passed     | passed        |
	| rxtx_offload/test_rxoffload_queue           | n/a        | n/a           |
	| rxtx_offload/test_txoffload_port_all        | passed     | passed        |
	| rxtx_offload/test_txoffload_port_multi_segs | passed     | passed        |
	| rxtx_offload/test_txoffload_queue           | passed     | passed        |
	| rxtx_offload/test_txoffload_port_cmdline    | passed     | passed        |
	+---------------------------------------------+------------+---------------+

^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: [dts][PATCH V1] test/rxtx_offload:remove jumboframe test
  2021-11-11 16:02 [dts][PATCH V1] test/rxtx_offload:remove jumboframe test Lewei Yang
  2021-11-15 10:04 ` Jiang, YuX
@ 2021-11-22 14:27 ` Tu, Lijuan
  2021-11-23  6:25   ` Jiang, YuX
  1 sibling, 1 reply; 4+ messages in thread
From: Tu, Lijuan @ 2021-11-22 14:27 UTC (permalink / raw)
  To: Yang, LeweiX, dts; +Cc: Yang, LeweiX

> -----Original Message-----
> From: Lewei Yang <leweix.yang@intel.com>
> Sent: 2021年11月12日 0:03
> To: dts@dpdk.org
> Cc: Yang, LeweiX <leweix.yang@intel.com>
> Subject: [dts][PATCH V1] test/rxtx_offload:remove jumboframe test
> 
> According to dpdk commit b563c1421282("ethdev: remove jumbo offload flag"),
> 'DEV_RX_OFFLOAD_JUMBO_FRAME' offload flag has been removed,so remove
> jumboframe related tests
> 
> Signed-off-by: Lewei Yang <leweix.yang@intel.com>

I think not only these cases are import, but also others, please fix all cases impacted.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: [dts][PATCH V1] test/rxtx_offload:remove jumboframe test
  2021-11-22 14:27 ` Tu, Lijuan
@ 2021-11-23  6:25   ` Jiang, YuX
  0 siblings, 0 replies; 4+ messages in thread
From: Jiang, YuX @ 2021-11-23  6:25 UTC (permalink / raw)
  To: Tu, Lijuan, Yang, LeweiX, dts; +Cc: Yang, LeweiX

> -----Original Message-----
> From: Tu, Lijuan <lijuan.tu@intel.com>
> Sent: Monday, November 22, 2021 10:27 PM
> To: Yang, LeweiX <leweix.yang@intel.com>; dts@dpdk.org
> Cc: Yang, LeweiX <leweix.yang@intel.com>
> Subject: RE: [dts][PATCH V1] test/rxtx_offload:remove jumboframe test
> 
> > -----Original Message-----
> > From: Lewei Yang <leweix.yang@intel.com>
> > Sent: 2021年11月12日 0:03
> > To: dts@dpdk.org
> > Cc: Yang, LeweiX <leweix.yang@intel.com>
> > Subject: [dts][PATCH V1] test/rxtx_offload:remove jumboframe test
> >
> > According to dpdk commit b563c1421282("ethdev: remove jumbo offload
> > flag"), 'DEV_RX_OFFLOAD_JUMBO_FRAME' offload flag has been
> removed,so
> > remove jumboframe related tests
> >
> > Signed-off-by: Lewei Yang <leweix.yang@intel.com>
> 
> I think not only these cases are import, but also others, please fix all cases
> impacted.

This suite only has this Jumboframe case. And we do not find other related suite.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-11-23  6:25 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-11 16:02 [dts][PATCH V1] test/rxtx_offload:remove jumboframe test Lewei Yang
2021-11-15 10:04 ` Jiang, YuX
2021-11-22 14:27 ` Tu, Lijuan
2021-11-23  6:25   ` Jiang, YuX

test suite reviews and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git