From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8FC5CA0350; Tue, 30 Jun 2020 09:17:00 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4BCA41B13C; Tue, 30 Jun 2020 09:17:00 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id F208E2AB for ; Tue, 30 Jun 2020 09:16:57 +0200 (CEST) IronPort-SDR: LsVGLpgjhlcJOdLlpYCmombEZriAdB6xb+ZuyCxUp/DpjHDdiIAltg9DzxbEG3dT4tJGnS4zoa GqGEHvOYDN7Q== X-IronPort-AV: E=McAfee;i="6000,8403,9666"; a="207677580" X-IronPort-AV: E=Sophos;i="5.75,296,1589266800"; d="scan'208";a="207677580" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jun 2020 00:16:56 -0700 IronPort-SDR: 6xir+LWCn9f/3HImmk/GUzRkFiGC6df9sqD3vYF1QtIQX0N4Ki704YsbweXq2yW+AGyehbR+// HKZCSmpOibGw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,296,1589266800"; d="scan'208";a="386617988" Received: from orsmsx106.amr.corp.intel.com ([10.22.225.133]) by fmsmga001.fm.intel.com with ESMTP; 30 Jun 2020 00:16:55 -0700 Received: from orsmsx154.amr.corp.intel.com (10.22.226.12) by ORSMSX106.amr.corp.intel.com (10.22.225.133) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 30 Jun 2020 00:16:54 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX154.amr.corp.intel.com (10.22.226.12) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 30 Jun 2020 00:16:54 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.172) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 30 Jun 2020 00:16:54 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qifq3tgqzaOVd3OsF1cxnkgJwy6b3ZuMqmM4JvfNZL9e8jycRn3OjOY/DpeV/PcP7cnWsByU+hDchpGD0H0GdVduZKTEvN/ezsKX0hcssD2a/SGPulwW45wjwAmWBkuYJuSUriSsgur2SZl6TGs8GnjrGBHg3TVbJvMCjqOSv3Anz6H+aYODbnmc6DxOFfgOgMQ01AvMrgrG4EPHgPKtAe80rqNsS71vzKiwtjZSrofRhYViiylpQREGH7O5bebzWwj3LKE+DYqim+sTB0Z4WHI+xIvC+pKwKRk7rMdc0EWFxGKEbXjwQUpcw8wVokaCMJr60SuHZ4mC2KG8J6s8/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Dbe7msTM1cqkpkA3TbyPfzfTbUifa7KLm2odn7wi6Fo=; b=dkYhmeRqzKNTjsnHWSE6u4NGcwPeEH+4kv+A+dqs+9RPtgK4mnLoGb83+2one4uSBaI1AWLIz0JOnIzR6JCDkJ/8YWQJdbgf1z+unM5b7KhMjnYPQ6lg0Q2GFylq2NIwrpxOadBAPiZt4eOOBswqOrF6JrZM6cZCwTyK2MIIXWfZuTRCqj7qO30V6XuW4wA6Ynp68NF8+78einWM35SG/qhINhLAQOpM3vBqhUd2cWp3oYEzwuYyHlwxsuF5ZvylSPkwvlUIY0xtbpz/OFHsPUU4TzOtanxUFC32V5GYxEFz4N0hpQjnhRMqjye/LQgs3euqOLDS8T0iM0d2g74OiQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Dbe7msTM1cqkpkA3TbyPfzfTbUifa7KLm2odn7wi6Fo=; b=H8L2Jp6RMvjLoBsIwHXzlY/12RHupsXbaYuI61C92vivqtReMU2dT0BgSFvvj+tNGAJTlIp5ZPhM4X+/+4QVeHAxKaKX1peckIqTfcM+7iS2hOm+Rq6JeABkKnUvPnqmtWfKnvWC1aqrJWiNldP6sPB3JMr5PpmF0mWUpvFLDU8= Received: from BY5PR11MB3893.namprd11.prod.outlook.com (2603:10b6:a03:183::26) by BY5PR11MB4321.namprd11.prod.outlook.com (2603:10b6:a03:1bf::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.21; Tue, 30 Jun 2020 07:16:52 +0000 Received: from BY5PR11MB3893.namprd11.prod.outlook.com ([fe80::c85c:ec78:c650:6ac9]) by BY5PR11MB3893.namprd11.prod.outlook.com ([fe80::c85c:ec78:c650:6ac9%3]) with mapi id 15.20.3131.027; Tue, 30 Jun 2020 07:16:52 +0000 From: "Peng, Yuan" To: "Chen, BoX C" , "dts@dpdk.org" CC: "Peng, Yuan" Thread-Topic: [dts] [PATCH V1] test/dual_vlan: Code optimization Thread-Index: AQHWTqzsoheNx2Nb4U6aqwBJGkr03ajwvPCAgAACc1A= Date: Tue, 30 Jun 2020 07:16:52 +0000 Message-ID: References: <20200630065838.18589-1-box.c.chen@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.206] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e1a01d56-e722-4019-5440-08d81cc59040 x-ms-traffictypediagnostic: BY5PR11MB4321: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:372; x-forefront-prvs: 0450A714CB x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: K5PUZxTotk53hz1l7HYYbaXsTo1qdQJuBJwcnKsbA124hTO6pPk/8ClVKh4UVluWLE9goWoldqGQ/gJqRy7IQfIlTC6nQjvJavzFsXoXjeinF4FYOAhQtJLbb4G6OnLO3klJXU27UORCKw55erzxgx0jZZDOYznT7+AbGYh149tWxs4gVfJ4MGEZ1hZdi3V1xsS93seLVaLVyzjwJs3TVTaCYVOPTf0+HzNluCzCUZjqzL7moOic3ZVU3KURhWhpHkeEyNLTAxUBFwHcF96KIu3mEdainoWvJcaFFFvnKn9C2DZI6j7Ys9ahc+sSAeWUHlQ7ZZzk8OshJnOGWZwDhA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR11MB3893.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(376002)(346002)(366004)(396003)(39860400002)(136003)(9686003)(316002)(55016002)(83380400001)(26005)(66446008)(52536014)(186003)(66476007)(64756008)(4326008)(66556008)(76116006)(66946007)(8936002)(478600001)(5660300002)(71200400001)(7696005)(107886003)(8676002)(110136005)(33656002)(53546011)(86362001)(6506007)(2906002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: ymCjOv/6CNsx3QJkZMHGBu4Dh5WxZZpjxu55/FRXWEE1aXUmnRxSTv3Y4fOodJ99DE9WOnHbl7wkQWLot/v0NltOIdsDc/iWMHuT48WBaYwNZRZYDfyA41V0y1wMOMPSso3WE9FgfnwjFfMEq4JKntTLsZULrt5FcYBsAtfkdUktclIKHxOQO+/aUeyT9J/V9NRpoydG9iLIcv75hHfTRcBgiJAmECy4LZnCFfLp+6fFQylb9MTC0/LBrmpn/Ms+crlXhP7b77qBqBNJXqY9U45YM/xpQPxAhoTa0cVuydgc5arVHjyboX+WUNigtPBg4vKAH8xB8SxdxISqv7fwVVR/CI+yTw2IpijpNa13eb2p4B76n8LvtSk79UxO2Ef3BTLVnNYSH885sUib5Xmb2DZzDkFi+3XlN+X+7TnwL35iUIFmbShazsoGeLsnOlNsSPbR0vbvXIaeQ0h9xc2H0B4kf2n7oCITTuoWTTvW38HNCyIu/OE1d5h6AgbokZm6 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR11MB3893.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e1a01d56-e722-4019-5440-08d81cc59040 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jun 2020 07:16:52.6155 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yfoNA/b44JCWQrNKEiRKSRym4G2S3e86DQo/CwIvK69AG/aBGRz/mYTM2vkT1eeiS4b6Edsdz4fKF5nFiZu/lQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4321 X-OriginatorOrg: intel.com Subject: Re: [dts] [PATCH V1] test/dual_vlan: Code optimization X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" Acked by Peng, Yuan -----Original Message----- From: dts On Behalf Of Chen, BoX C Sent: Tuesday, June 30, 2020 3:08 PM To: dts@dpdk.org Subject: Re: [dts] [PATCH V1] test/dual_vlan: Code optimization Tested-by: Chen, BoX C Regards, Chen Bo > -----Original Message----- > From: Chen, BoX C > Sent: June 30, 2020 14:59 > To: dts@dpdk.org > Cc: Chen, BoX C > Subject: [dts][PATCH V1] test/dual_vlan: Code optimization >=20 > Delete code that will not be executed >=20 > Signed-off-by: ChenBo > --- > tests/TestSuite_dual_vlan.py | 4 ---- > 1 file changed, 4 deletions(-) >=20 > diff --git a/tests/TestSuite_dual_vlan.py=20 > b/tests/TestSuite_dual_vlan.py index daa23d3..73d3156 100644 > --- a/tests/TestSuite_dual_vlan.py > +++ b/tests/TestSuite_dual_vlan.py > @@ -348,8 +348,6 @@ class TestDualVlan(TestCase): > self.mode_config(extend=3D"off") > self.mode_config(strip=3D"off") > self.mode_config(stripq=3D"off") > - if self.nic in ["fortville_eagle", "fortville_spirit", "fortvill= e_spirit_single", > "fortville_25g", "fortpark_TLV", "fortpark_BASE-T","carlsville"]: > - self.dut.send_expect('rx_vlan add %s %s' % (outvlan, dutRxPo= rtId), > "testpmd> ") > self.vlan_send_packet(outvlan) > out =3D self.get_tcpdump_package() > self.verify("vlan %s" % outvlan in out, "vlan strip queue=20 > disable error : " + > out) @@ -366,8 +364,6 @@ class TestDualVlan(TestCase): > self.vlan_send_packet(outvlan) > out =3D self.get_tcpdump_package() > self.verify("vlan %s" % outvlan in out, "vlan strip queue=20 > disable error: " + > out) > - if self.nic in ["columbiaville_25g", "columbiaville_100g", "fort= ville_eagle", > "fortville_spirit", "fortville_spirit_single", "fortville_25g",=20 > "fortpark_TLV","fortpark_BASE-T" "carlsville"]: > - self.dut.send_expect('rx_vlan rm %s %s' % (outvlan, dutRxPor= tId), > "testpmd> ") >=20 > def test_vlan_insert_config(self): > """ > -- > 2.17.1