test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Peng, Yuan" <yuan.peng@intel.com>
To: "Zhang, XiX" <xix.zhang@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Subject: Re: [dts] [PATCH V1] tests/TestSuite_rss_to_rte_flow:Create ivp6 TCP flow rules, but send IPv4 TCP packets, modify to send IPv6 TCP packets and Add multiple package test methods
Date: Fri, 17 Jul 2020 07:59:08 +0000	[thread overview]
Message-ID: <BY5PR11MB3893E130FE3985E6C8C938F6FE7C0@BY5PR11MB3893.namprd11.prod.outlook.com> (raw)
In-Reply-To: <E22AF82976AEF646B9B29E4604B9BED504CC0C12@CDSMSX102.ccr.corp.intel.com>

Acked-by Peng, Yuan <yuan.peng@intel.com>

-----Original Message-----
From: dts <dts-bounces@dpdk.org> On Behalf Of Zhang, XiX
Sent: Friday, July 17, 2020 3:55 PM
To: dts@dpdk.org
Subject: Re: [dts] [PATCH V1] tests/TestSuite_rss_to_rte_flow:Create ivp6 TCP flow rules, but send IPv4 TCP packets, modify to send IPv6 TCP packets and Add multiple package test methods

Tested-by: Zhang, XiX <xix.zhang@intel.com>

-----Original Message-----
From: Zhang, XiX 
Sent: Friday, July 17, 2020 3:53 PM
To: dts@dpdk.org
Cc: Zhang, XiX <xix.zhang@intel.com>
Subject: [dts][PATCH V1] tests/TestSuite_rss_to_rte_flow:Create ivp6 TCP flow rules, but send IPv4 TCP packets, modify to send IPv6 TCP packets and Add multiple package test methods

Create ivp6 TCP flow rules, but send IPv4 TCP packets, modify to send IPv6 TCP packets and Add multiple package test methods

Signed-off-by: xizhan4x <xix.zhang@intel.com>
---
 tests/TestSuite_rss_to_rte_flow.py | 80 ++++++++++++++++----------------------
 1 file changed, 33 insertions(+), 47 deletions(-)

diff --git a/tests/TestSuite_rss_to_rte_flow.py b/tests/TestSuite_rss_to_rte_flow.py
index 21ba8dc..55d5a3a 100644
--- a/tests/TestSuite_rss_to_rte_flow.py
+++ b/tests/TestSuite_rss_to_rte_flow.py
@@ -622,73 +622,59 @@ class TestRSS_to_Rteflow(TestCase):
         self.dut.send_expect("set verbose 1", "testpmd> ", 120)
         self.dut.send_expect("start", "testpmd> ", 120)
         time.sleep(2)
-        rss_queue = ["0"]
-        pkts = [self.pkt1, self.pkt2, self.pkt3, self.pkt4, self.pkt5, self.pkt6, self.pkt7, self.pkt8, self.pkt9, self.pkt10, self.pkt11]
-        self.send_and_check(pkts, rss_queue, port_id=0)
+        ptype_list1 = ["ipv4-other", "ipv4-frag", "ipv4-udp","ipv4-tcp", "ipv4-sctp", "ipv6-other", "ipv6-frag", "ipv6-udp", "ipv6-tcp", "ipv6-sctp", "l2-payload"]
+        self.send_check_100_packet_queue(ptype_list1, "0", port_id=0)
+        self.send_check_100_packet_queue(ptype_list1, "0", port_id=1)
 
         # enable ipv4-udp and ipv6-tcp RSS function type
         self.dut.send_expect(
             "flow create 0 ingress pattern eth / ipv4 / udp / end actions rss types ipv4-udp end queues end / end", "created")
         self.dut.send_expect(
             "flow create 0 ingress pattern eth / ipv6 / tcp / end actions rss types ipv6-tcp end queues end / end", "created")
-        rss_queue = ["0", "1", "2", "3", "4", "5", "6", "7"]
-        pkts = [self.pkt2, self.pkt3]
-        self.send_and_check(pkts, rss_queue, port_id=0)
-        rss_queue = ["0"]
-        pkts = [self.pkt1, self.pkt4, self.pkt5, self.pkt6, self.pkt7, self.pkt8, self.pkt9, self.pkt10]
-        self.send_and_check(pkts, rss_queue, port_id=0)
-        rss_queue = ["0"]
-        pkts = [self.pkt1, self.pkt2, self.pkt3, self.pkt4, self.pkt5, self.pkt6, self.pkt7, self.pkt8, self.pkt9, self.pkt10]
-        self.send_and_check(pkts, rss_queue, port_id=1)
+
+        ptype_list1 = ["ipv4-udp", "ipv6-tcp"]
+        self.send_check_100_packet_queue(ptype_list1, "all", port_id=0)
+        ptype_list2 = ["ipv4-other", "ipv4-frag", "ipv4-tcp", "ipv4-sctp", "ipv6-other", "ipv6-frag", "ipv6-udp", "ipv6-sctp", "l2-payload"]
+        self.send_check_100_packet_queue(ptype_list2, "0", port_id=0)
+        ptype_list3 = ["ipv4-other", "ipv4-frag", "ipv4-udp","ipv4-tcp", "ipv4-sctp", "ipv6-other", "ipv6-frag", "ipv6-udp", "ipv6-tcp", "ipv6-sctp", "l2-payload"]
+        self.send_check_100_packet_queue(ptype_list3, "0", port_id=1)
 
         #  set queue 1, 4, 7 into RSS queue rule
         self.dut.send_expect(
             "flow create 0 ingress pattern end actions rss types end queues 1 4 7 end / end", "created")
-        rss_queue = ["1", "4", "7"]
-        pkts = [self.pkt2, self.pkt3]
-        self.send_and_check(pkts, rss_queue, port_id=0)
-        rss_queue = ["0"]
-        pkts = [self.pkt1, self.pkt4, self.pkt5, self.pkt6, self.pkt7, self.pkt8, self.pkt9, self.pkt10]
-        self.send_and_check(pkts, rss_queue, port_id=0)
-        rss_queue = ["0"]
-        pkts = [self.pkt1, self.pkt2, self.pkt3, self.pkt4, self.pkt5, self.pkt6, self.pkt7, self.pkt8, self.pkt9, self.pkt10]
-        self.send_and_check(pkts, rss_queue, port_id=1)
+        ptype_list1 = ["ipv4-udp", "ipv6-tcp"]
+        self.send_check_100_packet_queue(ptype_list1, ["1","4","7"], port_id=0)
+        ptype_list2 = ["ipv4-other", "ipv4-frag", "ipv4-tcp", "ipv4-sctp", "ipv6-other", "ipv6-frag", "ipv6-udp", "ipv6-sctp", "l2-payload"]
+        self.send_check_100_packet_queue(ptype_list2, "0", port_id=0)
+        ptype_list3 = ["ipv4-other", "ipv4-frag", "ipv4-udp","ipv4-tcp", "ipv4-sctp", "ipv6-other", "ipv6-frag", "ipv6-udp", "ipv6-tcp", "ipv6-sctp", "l2-payload"]
+        self.send_check_100_packet_queue(ptype_list3, "0", port_id=1)
 
         # enable ipv4-udp and ipv6-other RSS function type on port 1
         self.dut.send_expect(
             "flow create 1 ingress pattern eth / ipv4 / udp / end actions rss types ipv4-udp end queues end / end", "created")
         self.dut.send_expect(
             "flow create 1 ingress pattern eth / ipv6 / end actions rss types ipv6-other end queues end / end", "created")
-        rss_queue = ["1", "4", "7"]
-        pkts = [self.pkt2, self.pkt3]
-        self.send_and_check(pkts, rss_queue, port_id=0)
-        rss_queue = ["0"]
-        pkts = [self.pkt1, self.pkt4, self.pkt5, self.pkt6, self.pkt7, self.pkt8, self.pkt9, self.pkt10]
-        self.send_and_check(pkts, rss_queue, port_id=0)
-
-        rss_queue = ["0", "1", "2", "3", "4", "5", "6", "7"]
-        pkts = [self.pkt2, self.pkt8]
-        self.send_and_check(pkts, rss_queue, port_id=1)
-        rss_queue = ["0"]
-        pkts = [self.pkt1, self.pkt3, self.pkt4, self.pkt5, self.pkt6, self.pkt7, self.pkt9, self.pkt10]
-        self.send_and_check(pkts, rss_queue, port_id=1)
+        ptype_list1 = ["ipv4-udp", "ipv6-tcp"]
+        self.send_check_100_packet_queue(ptype_list1, ["1","4","7"], port_id=0)
+        ptype_list2 = ["ipv4-other", "ipv4-frag", "ipv4-tcp", "ipv4-sctp", "ipv6-other", "ipv6-frag", "ipv6-udp", "ipv6-sctp", "l2-payload"]
+        self.send_check_100_packet_queue(ptype_list2, "0", port_id=0)
+        ptype_list3 = ["ipv4-udp", "ipv6-other"]
+        self.send_check_100_packet_queue(ptype_list3, "all", port_id=1)
+        ptype_list4 = ["ipv4-other", "ipv4-frag", "ipv4-tcp", "ipv4-sctp", "ipv6-frag", "ipv6-udp", "ipv6-tcp", "ipv6-sctp", "l2-payload"]
+        self.send_check_100_packet_queue(ptype_list4, "0", port_id=1)
 
         self.dut.send_expect("flow flush 0", "testpmd> ")
-        rss_queue = ["0"]
-        pkts = [self.pkt1, self.pkt2, self.pkt3, self.pkt4, self.pkt5, self.pkt6, self.pkt7, self.pkt8, self.pkt9, self.pkt10]
-        self.send_and_check(pkts, rss_queue, port_id=0)
-        rss_queue = ["0", "1", "2", "3", "4", "5", "6", "7"]
-        pkts = [self.pkt2, self.pkt8]
-        self.send_and_check(pkts, rss_queue, port_id=1)
-        rss_queue = ["0"]
-        pkts = [self.pkt1, self.pkt3, self.pkt4, self.pkt5, self.pkt6, self.pkt7, self.pkt9, self.pkt10]
-        self.send_and_check(pkts, rss_queue, port_id=1)
+        ptype_list1 = ["ipv4-other", "ipv4-frag", "ipv4-udp", "ipv4-tcp", "ipv4-sctp", "ipv6-other", "ipv6-frag", "ipv6-udp", "ipv6-tcp", "ipv6-sctp", "l2-payload"]
+        self.send_check_100_packet_queue(ptype_list1, "0", port_id=0)
+        ptype_list2 = ["ipv4-udp", "ipv6-other"]
+        self.send_check_100_packet_queue(ptype_list2, "all", port_id=1)
+        ptype_list3 = ["ipv4-other", "ipv4-frag", "ipv4-tcp", "ipv4-sctp", "ipv6-frag", "ipv6-udp", "ipv6-tcp", "ipv6-sctp", "l2-payload"]
+        self.send_check_100_packet_queue(ptype_list3, "0", port_id=1)
 
         self.dut.send_expect("flow flush 1", "testpmd> ")
-        rss_queue = ["0"]
-        pkts = [self.pkt1, self.pkt2, self.pkt3, self.pkt4, self.pkt5, self.pkt6, self.pkt7, self.pkt8, self.pkt9, self.pkt10]
-        self.send_and_check(pkts, rss_queue, port_id=0)
-        self.send_and_check(pkts, rss_queue, port_id=1)
+        ptype_list1 = ["ipv4-other", "ipv4-frag", "ipv4-udp", "ipv4-tcp", "ipv4-sctp", "ipv6-other", "ipv6-frag", "ipv6-udp", "ipv6-tcp", "ipv6-sctp", "l2-payload"]
+        self.send_check_100_packet_queue(ptype_list1, "0", port_id=0)
+        self.send_check_100_packet_queue(ptype_list1, "0", port_id=1)
 
     def test_flow_director_rss_rule_combination(self):
         """
-- 
1.8.3.1


  reply	other threads:[~2020-07-17  7:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-17  7:53 xizhan4x
2020-07-17  7:54 ` Zhang, XiX
2020-07-17  7:59   ` Peng, Yuan [this message]
2020-07-24  2:25 ` Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BY5PR11MB3893E130FE3985E6C8C938F6FE7C0@BY5PR11MB3893.namprd11.prod.outlook.com \
    --to=yuan.peng@intel.com \
    --cc=dts@dpdk.org \
    --cc=xix.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).