From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 264B1A0A02; Tue, 23 Mar 2021 15:53:33 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F128D140F1F; Tue, 23 Mar 2021 15:53:32 +0100 (CET) Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) by mails.dpdk.org (Postfix) with ESMTP id 1EC4B4069E for ; Tue, 23 Mar 2021 15:53:31 +0100 (CET) Received: by mail-lf1-f52.google.com with SMTP id o126so17555082lfa.0 for ; Tue, 23 Mar 2021 07:53:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dULNc+sbsfQ7Z7Fiwn/VAlRZVdXK7iU32qgEbg8uUqY=; b=Y7Mvd9hD9cBpf9C9kwlpwiM3rY8LV/oqJtHtTBy1MKPQxIb6fe2kq3fnNhxY4BFO6l xaHmM83I3evnd2O4Mfou1L4Oa/1983O7/9hTxcrx221plCQaCDEquyOR7J0rB0WFsM+e g+rWYMrclW6MUiD7DZ3dUMScjzajfukheYnaE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dULNc+sbsfQ7Z7Fiwn/VAlRZVdXK7iU32qgEbg8uUqY=; b=T/ZBF5dhB9+1QYL46ZzvaBeZpu+Anc872rbQE+eUMhnqR0e4fJ3dx/rViFbk2yggiX hJrzcvDrs3eh2BBQH27tIx+OKGDugBeSMclj/C6n6mdFmvKadU9oeEiZFCvVLLvIVjvO Mc+GGe9k580r5KctQWvYlozANQO52ysCLxSrgkHNfjdiTE5mPjT9TG7+2JHGgg5Rub3Y 91og+Z0ffpgm6U2ADHWEpZEt7KyToZfpt5j1alO1/K+3yHSvVgUSApVm4meNKpDQIwYs we6e0GkM9gGVNXOvT0ZHYrH4e8q9B+JopKjWr5QByMO5pzCfi5kNoHhrXnJj4gDmBIJk 6j3g== X-Gm-Message-State: AOAM531T2g86jbd+zuqCdZ2ipfmTl3nynGI9yZn8d73y/KLLwLDOtFlv MdREN14krcNGuzYn7PHoeUeCuNVEheG5JQb+Utvgmg== X-Google-Smtp-Source: ABdhPJyKaHSbju11TyVkdobjADX2B9LO/i4wthEy5/V0Xh69G81rqOHXmV7gP7Uv8e3fTt/2QgkTsXowvrrEcmiRhQQ= X-Received: by 2002:ac2:57c9:: with SMTP id k9mr2838066lfo.119.1616511210619; Tue, 23 Mar 2021 07:53:30 -0700 (PDT) MIME-Version: 1.0 References: <20210311104800.243752-1-lijuan.tu@intel.com> <0e4279f9e86442ed81df0416e9e19ffd@intel.com> In-Reply-To: <0e4279f9e86442ed81df0416e9e19ffd@intel.com> From: David Liu Date: Tue, 23 Mar 2021 10:52:54 -0400 Message-ID: To: "Tu, Lijuan" Cc: Ali Alnubani , "dts@dpdk.org" , "dpdklab@iol.unh.edu" Content-Type: multipart/alternative; boundary="0000000000007c20b105be3558b4" Subject: Re: [dts] [PATCH] tests/nic_single_core_perf: modify accepted_tolerance to percentage X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" --0000000000007c20b105be3558b4 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thank you for Ali and Lijuan. We had tested the patch on the Arm machines setup. Other than the value issues, the test is running as expected. On Tue, Mar 23, 2021 at 4:48 AM Tu, Lijuan wrote: > > > > -----Original Message----- > > From: Ali Alnubani > > Sent: 2021=E5=B9=B43=E6=9C=8823=E6=97=A5 16:44 > > To: Tu, Lijuan > > Cc: dts@dpdk.org; dpdklab@iol.unh.edu > > Subject: RE: [dts] [PATCH] tests/nic_single_core_perf: modify > > accepted_tolerance to percentage > > > > > -----Original Message----- > > > From: dts On Behalf Of Lijuan Tu > > > Sent: Thursday, March 11, 2021 12:48 PM > > > To: dpdklab@iol.unh.edu > > > Cc: dts@dpdk.org; Lijuan Tu > > > Subject: [dts] [PATCH] tests/nic_single_core_perf: modify > > > accepted_tolerance to percentage > > > > > > * accepted_tolerance in conf/nic_single_core_perf.cfg are changed to > > > percentage, e.g. > > > accepted_tolerance =3D '1%%' > > > if not set, it will be set to 2% by default. > > > * delat in json are chagned to percentage too, e.g. > > > 'delta': '1.5%' > > > * expected_throughput will be forced to 1Mpps for compute delat in > > > percentage > > > * add new conf test_interval in conf/nic_single_core_perf.cfg, which > > > indicates interval of getting throughput statistics in second, e.g. > > > test_interval =3D 10 > > > if not set, it will be set to 5 seconds by default. > > > * collect better statistics , get multiple throughput statistics > > > during the test run, and compute the average as the final results. > > > > > > Signed-off-by: Lijuan Tu > > > --- > > > > > +accepted_tolerance =3D '1%%' > > > > > + diff =3D > > > + (self.throughput[fwd_config][frame_size][nb_desc] - > > > + > > > self.expected_throughput[fwd_config][frame_size][nb_desc])/ \ > > > + > > > self.expected_throughput[fwd_config][frame_size][nb_desc] > > > > The value of `diff` here is still a decimal, and needs to be multiplied > by a 100 > > before it can be compared to `accepted_tolerance`. > > > > I suggest splitting this patch into multiple ones. One for making the > percentage > > change and one for taking the mean for multiple readings since they are > > unrelated changes. > > I also see other unrelated changes not explained in the commit message. > > Really appreciate for your review, I will accept your advices. > > > > > Thanks, > > Ali > --0000000000007c20b105be3558b4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thank you for Ali and Lijuan.

We had tested the pat= ch on the Arm machines setup. Other than the value issues, the test is runn= ing=C2=A0as expected.

On Tue, Mar 23, 2021 at 4:48 AM Tu, Lijuan <lijuan.tu@intel.com> wrote:
<= /div>


> -----Original Message-----
> From: Ali Alnubani <alialnu@nvidia.com>
> Sent: 2021=E5=B9=B43=E6=9C=8823=E6=97=A5 16:44
> To: Tu, Lijuan <lijuan.tu@intel.com>
> Cc: dts@dpdk.org= ; dpdklab@iol.unh.= edu
> Subject: RE: [dts] [PATCH] tests/nic_single_core_perf: modify
> accepted_tolerance to percentage
>
> > -----Original Message-----
> > From: dts <dts-bounces@dpdk.org> On Behalf Of Lijuan Tu
> > Sent: Thursday, March 11, 2021 12:48 PM
> > To: dpdk= lab@iol.unh.edu
> > Cc: dts@dpdk.or= g; Lijuan Tu <lijuan.tu@intel.com>
> > Subject: [dts] [PATCH] tests/nic_single_core_perf: modify
> > accepted_tolerance to percentage
> >
> > * accepted_tolerance in conf/nic_single_core_perf.cfg are changed= to
> > percentage, e.g.
> >=C2=A0 =C2=A0 =C2=A0accepted_tolerance =3D '1%%'
> >=C2=A0 =C2=A0 =C2=A0if not set, it will be set to 2% by default. > > * delat in json are chagned to percentage too, e.g.
> >=C2=A0 =C2=A0 =C2=A0'delta': '1.5%'
> > * expected_throughput will be forced to 1Mpps for compute delat i= n
> > percentage
> > * add new conf test_interval in conf/nic_single_core_perf.cfg, wh= ich
> > indicates interval of getting throughput statistics in second, e.= g.
> >=C2=A0 =C2=A0 =C2=A0test_interval =3D 10
> >=C2=A0 =C2=A0 =C2=A0if not set, it will be set to 5 seconds by def= ault.
> > * collect better statistics , get multiple throughput statistics<= br> > > during the test run, and compute the average as the final results= .
> >
> > Signed-off-by: Lijuan Tu <lijuan.tu@intel.com>
> > ---
> <snipped>
> > +accepted_tolerance =3D '1%%'
> <snipped>
> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 diff =3D
> > + (self.throughput[fwd_config][frame_size][nb_desc] -
> > +
> > self.expected_throughput[fwd_config][frame_size][nb_desc])/ \
> > +
> > self.expected_throughput[fwd_config][frame_size][nb_desc]
>
> The value of `diff` here is still a decimal, and needs to be multiplie= d by a 100
> before it can be compared to `accepted_tolerance`.
>
> I suggest splitting this patch into multiple ones. One for making the = percentage
> change and one for taking the mean for multiple readings since they ar= e
> unrelated changes.
> I also see other unrelated changes not explained in the commit message= .

Really appreciate for your review, I will accept your advices.

>
> Thanks,
> Ali
--0000000000007c20b105be3558b4--