Hi Lijuan, Just a quick update. We had tested the patch on all our bare-metal machines. And they all work as expected. Best, David On Thu, Mar 25, 2021 at 11:34 PM Tu, Lijuan wrote: > Hi Owen, > > > > I ‘d like to add 2 more changes in V2: > > > > 1, test_interval will be renamed to throughput_stat_sample_interval for > better understanding. > > 2, accepted_tolerance will be a float to algin with delta in json, both > format are {:.2f} > > > > > > *From:* dts *On Behalf Of * Tu, Lijuan > *Sent:* 2021年3月25日 15:29 > *To:* Owen Hilyard > *Cc:* David Liu ; Ali Alnubani ; > dts@dpdk.org; dpdklab@iol.unh.edu > *Subject:* Re: [dts] [dpdklab] Re: [PATCH] tests/nic_single_core_perf: > modify accepted_tolerance to percentage > > > > sure, I prefer to use a float too. > > > > *From:* Owen Hilyard > *Sent:* 2021年3月24日 1:24 > *To:* Tu, Lijuan > *Cc:* David Liu ; Ali Alnubani ; > dts@dpdk.org; dpdklab@iol.unh.edu > *Subject:* Re: [dpdklab] Re: [dts] [PATCH] tests/nic_single_core_perf: > modify accepted_tolerance to percentage > > > > Hello Lijuan, > > > > Would it be possible to have the delta be a float in the json > representation? For example, a 20% delta would be encoded as "delta": .2 in > json. Currently, most of the community lab's infrastructure expects to make > pass/fail determinations on a numeric type, so having the delta as a float > would reduce the required downtime to change everything over to percentages > since we shouldn't need to patch all of our services to expect a string. > > > > > > Thanks, > > Owen Hilyard > > > > On Tue, Mar 23, 2021 at 10:53 AM David Liu wrote: > > Thank you for Ali and Lijuan. > > We had tested the patch on the Arm machines setup. Other than the value > issues, the test is running as expected. > > > > On Tue, Mar 23, 2021 at 4:48 AM Tu, Lijuan wrote: > > > > > -----Original Message----- > > From: Ali Alnubani > > Sent: 2021年3月23日 16:44 > > To: Tu, Lijuan > > Cc: dts@dpdk.org; dpdklab@iol.unh.edu > > Subject: RE: [dts] [PATCH] tests/nic_single_core_perf: modify > > accepted_tolerance to percentage > > > > > -----Original Message----- > > > From: dts On Behalf Of Lijuan Tu > > > Sent: Thursday, March 11, 2021 12:48 PM > > > To: dpdklab@iol.unh.edu > > > Cc: dts@dpdk.org; Lijuan Tu > > > Subject: [dts] [PATCH] tests/nic_single_core_perf: modify > > > accepted_tolerance to percentage > > > > > > * accepted_tolerance in conf/nic_single_core_perf.cfg are changed to > > > percentage, e.g. > > > accepted_tolerance = '1%%' > > > if not set, it will be set to 2% by default. > > > * delat in json are chagned to percentage too, e.g. > > > 'delta': '1.5%' > > > * expected_throughput will be forced to 1Mpps for compute delat in > > > percentage > > > * add new conf test_interval in conf/nic_single_core_perf.cfg, which > > > indicates interval of getting throughput statistics in second, e.g. > > > test_interval = 10 > > > if not set, it will be set to 5 seconds by default. > > > * collect better statistics , get multiple throughput statistics > > > during the test run, and compute the average as the final results. > > > > > > Signed-off-by: Lijuan Tu > > > --- > > > > > +accepted_tolerance = '1%%' > > > > > + diff = > > > + (self.throughput[fwd_config][frame_size][nb_desc] - > > > + > > > self.expected_throughput[fwd_config][frame_size][nb_desc])/ \ > > > + > > > self.expected_throughput[fwd_config][frame_size][nb_desc] > > > > The value of `diff` here is still a decimal, and needs to be multiplied > by a 100 > > before it can be compared to `accepted_tolerance`. > > > > I suggest splitting this patch into multiple ones. One for making the > percentage > > change and one for taking the mean for multiple readings since they are > > unrelated changes. > > I also see other unrelated changes not explained in the commit message. > > Really appreciate for your review, I will accept your advices. > > > > > Thanks, > > Ali > >