From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DBD04A052A; Tue, 22 Dec 2020 21:19:37 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id ADCA8CA34; Tue, 22 Dec 2020 21:19:36 +0100 (CET) Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) by dpdk.org (Postfix) with ESMTP id A8B00CA1A for ; Tue, 22 Dec 2020 21:19:34 +0100 (CET) Received: by mail-lf1-f43.google.com with SMTP id o19so34980619lfo.1 for ; Tue, 22 Dec 2020 12:19:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=G9pMSwmpbylfS6CdkcT6Q3oZrmOu2Pm+f3c4auUfJkk=; b=B5ZBK85DAPQ5VGQ9oDCX8V5keBM7Wb3/ZrWyzNgkWP/gcE/FhW44up18Qh2YUNpDC3 fJw50LWbGN1bbTJJ0Gl1qaWORGesIqZasbIoCDNi/3jdToaV6SCXE9kV6R4Vn11PP83X 3Jkxr7iVEn6bmPZnmj1TufkAX56IAGyVdJ/Z4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=G9pMSwmpbylfS6CdkcT6Q3oZrmOu2Pm+f3c4auUfJkk=; b=suP7+I66YHRlWsNsxVNdLOa/BG0UVkrIIfMLNzNh9fd5y7JrJFXA8N3p0VJzqYck2r ALD/Kyh68uFfDrMVhnAq9IYN5rZdSIuq0Ru7M2w0jlgR55lGK0wY73CVwlfBd7bCykrB 1yYGzDsOBoS2HiCaIVw/fzMz6ikzCFP5HLgzZipcvWzW+kR08eXGsrg/oY3i5BfpzD6q 5t3RHowVWKIORmxW1s6P0W0ykB7S3qPePs2Jfv5mp5GRAq2+bheDmhZqxqjRXdh5bg4E B0MvTnJSi1WAMY+9oYvaJ1G+hfQQMIhrYERqfFiwYFH8x1sn87TLvdMN5GvL0IKKeMaY jizA== X-Gm-Message-State: AOAM5325OvmBdoh6vgg0KGKdLkqHHI3i6IF9ag1ZgHTSQSQRoShEzXSn Bxtr8uPq3pruh84yCm+LZ8kkwfAIYKjhXH+GJxMTQ156UKoJYg== X-Google-Smtp-Source: ABdhPJyywve1WGlVIXApqx9GW2bDO/UnmhvJS3G2hJ7jfwwHc1XQYOyjO7jjuAyZlu8n1eVobC99ftWh1Yo3IBJzGpA= X-Received: by 2002:ac2:5309:: with SMTP id c9mr9852730lfh.447.1608668373849; Tue, 22 Dec 2020 12:19:33 -0800 (PST) MIME-Version: 1.0 References: <20201222200537.63824-1-dliu@iol.unh.edu> In-Reply-To: <20201222200537.63824-1-dliu@iol.unh.edu> From: David Liu Date: Tue, 22 Dec 2020 15:18:57 -0500 Message-ID: To: dts@dpdk.org Cc: "Tu, Lijuan" , Lincoln Lavoie Content-Type: multipart/alternative; boundary="000000000000fc357f05b7134a5a" Subject: Re: [dts] [PATCH] tests/Test_mtu_update:fix only config ports in one side of the machine. Start testpmd with different parameter in mlx4/mlx5 X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" --000000000000fc357f05b7134a5a Content-Type: text/plain; charset="UTF-8" Sorry, forget to signed-off the patch. I will submit another one. On Tue, Dec 22, 2020 at 3:05 PM David Liu wrote: > --- > tests/TestSuite_mtu_update.py | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/tests/TestSuite_mtu_update.py b/tests/TestSuite_mtu_update.py > index 6e425dcb..4fe697b4 100644 > --- a/tests/TestSuite_mtu_update.py > +++ b/tests/TestSuite_mtu_update.py > @@ -51,8 +51,8 @@ import time > from test_case import TestCase > from pktgen import TRANSMIT_CONT > > -from framework.packet import Packet > -from framework.settings import HEADER_SIZE > +from packet import Packet > +from settings import HEADER_SIZE > > ETHER_HEADER_LEN = 18 > IP_HEADER_LEN = 20 > @@ -208,6 +208,7 @@ class TestMtuUpdate(TestCase): > @return: None > """ > self.admin_tester_port(self.tester.get_local_port(self.tx_port), > f"mtu {mtu:d}") > + self.admin_tester_port(self.tester.get_local_port(self.rx_port), > f"mtu {mtu:d}") > # > # > # > @@ -220,7 +221,12 @@ class TestMtuUpdate(TestCase): > """ > self.set_mtu(packet_size + 1) > > - self.pmdout.start_testpmd("Default") > + if self.kdriver == "mlx5_core" or self.kdriver == "mlx4_core": > + # Mellanox will need extra options to start testpmd > + self.pmdout.start_testpmd("Default", "--max-pkt-len=9500 > --tx-offloads=0x8000 --enable-scatter -a") > + else: > + self.pmdout.start_testpmd("Default") > + > self.exec("port stop all") > self.exec(f"port config mtu 0 {packet_size:d}") > self.exec(f"port config mtu 1 {packet_size:d}") > -- > 2.17.1 > > --000000000000fc357f05b7134a5a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Sorry, forget to signed-off=C2=A0the patch. I will submit = another one.

On Tue, Dec 22, 2020 at 3:05 PM David Liu <dliu@iol.unh.edu> wrote:
---
=C2=A0tests/TestSuite_mtu_update.py | 12 +++++++++---
=C2=A01 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/tests/TestSuite_mtu_update.py b/tests/TestSuite_mtu_update.py<= br> index 6e425dcb..4fe697b4 100644
--- a/tests/TestSuite_mtu_update.py
+++ b/tests/TestSuite_mtu_update.py
@@ -51,8 +51,8 @@ import time
=C2=A0from test_case import TestCase
=C2=A0from pktgen import TRANSMIT_CONT

-from framework.packet import Packet
-from framework.settings import HEADER_SIZE
+from packet import Packet
+from settings import HEADER_SIZE

=C2=A0ETHER_HEADER_LEN =3D 18
=C2=A0IP_HEADER_LEN =3D 20
@@ -208,6 +208,7 @@ class TestMtuUpdate(TestCase):
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0@return: None
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"""
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.admin_tester_port(self.tester.get_lo= cal_port(self.tx_port), f"mtu {mtu:d}")
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self.admin_tester_port(self.tester.get_local_p= ort(self.rx_port), f"mtu {mtu:d}")
=C2=A0 =C2=A0 =C2=A0#
=C2=A0 =C2=A0 =C2=A0#
=C2=A0 =C2=A0 =C2=A0#
@@ -220,7 +221,12 @@ class TestMtuUpdate(TestCase):
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"""
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.set_mtu(packet_size + 1)

-=C2=A0 =C2=A0 =C2=A0 =C2=A0 self.pmdout.start_testpmd("Default")=
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 if self.kdriver =3D=3D "mlx5_core" o= r self.kdriver =3D=3D "mlx4_core":
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 # Mellanox will need extra options to start te= stpmd
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 self.pmdout.start_testpmd("= Default", "--max-pkt-len=3D9500 --tx-offloads=3D0x8000 --enable-s= catter -a")
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 else:
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 self.pmdout.start_testpmd("= Default")
+=C2=A0 =C2=A0 =C2=A0 =C2=A0
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.exec("port stop all")
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.exec(f"port config mtu 0 {packe= t_size:d}")
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.exec(f"port config mtu 1 {packe= t_size:d}")
--
2.17.1

--000000000000fc357f05b7134a5a--