From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-f67.google.com (mail-ed1-f67.google.com [209.85.208.67]) by dpdk.org (Postfix) with ESMTP id 791E1DE3 for ; Thu, 24 Jan 2019 02:54:13 +0100 (CET) Received: by mail-ed1-f67.google.com with SMTP id g22so3291141edr.7 for ; Wed, 23 Jan 2019 17:54:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yWGaobXE3G09/+/4bSB9x93rtzMazvvVQQC8mlhlvQE=; b=axeoLiQ9qtQF19IvxT30hlZxhppOaCc0TqUv/DC4frMrAUsstRbRLqhwgs5ZIqSmh7 kAhYyJJPgiy+jUHb1R9e5J1YRqoxiv5Y2DC3VXX1V8yAXt9XHTpQEMRX4TbMFGEm3MeD 9zMfN4mrcIVhEvQYfZclVKSnYwSbQQ4iFeyVR1QCdcgslCyQFOYbBeQhYcvogYnXprBZ r4cI3Tq/FNIW4KsHku9XH/Z4ZJ4q9Rxs9HIAim2N8QJQBYz1UwtoUi9QRtwi00MR0tyF oFq+dB3MxRioS66xvlyb3vz3ct0zN4SpXdd6hrdvI4mLICa6uPzUTA3yS/q8fMvTruct FCVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yWGaobXE3G09/+/4bSB9x93rtzMazvvVQQC8mlhlvQE=; b=g/EOfpc+8eHAOCYxYNEs1gpJHpVlvTyRzZS0nbTSw4UuD8nhlfvegf3pVUMdD8fXy2 /xKc+clEaJBG0woejkMkF1oy338x8esqnd6dA1NLGzu1yq+CBSwjyhivW4INuHWrJhOp fAMvREqdTrClRdwraKx3mY3nTJQRgsyp+Q4HDa8y7gqL6ToBRMq9DY3E/u6SHr/iCPz3 x/zxrhHy6W6EJ1XVzSJ3Q/2MdNJnKr7lKEdk+EwJ1Mdu/L/mi+Kpxz1EGG6R9P9/YB91 cRkwaRJ9Ey9DY0MuCC2y8U4z6XBuJ06MnGYuwTaizIATP59gtGqKz9x5xjfqZncTFjXF Ih2A== X-Gm-Message-State: AJcUuke0lX+TcHK5Ruc5osh15rsiwYxPTqDOhFm8EHfwMh99vYF3Vqoe 5u++DtFq8ZeN0D1SIPsJNGUKneZxXJiIVGwSv+EZvr+3 X-Google-Smtp-Source: ALg8bN5stBbZftmZbii9FXONIYDfE+M3wUAPulJ1GRsW1lyOOHUFSckjgMQcsGvRDFieqSVURi4TU4u4pX6PtQGslKk= X-Received: by 2002:a17:906:6a17:: with SMTP id o23mr4216876ejr.71.1548294852997; Wed, 23 Jan 2019 17:54:12 -0800 (PST) MIME-Version: 1.0 References: <1548293433-25085-1-git-send-email-shuaix.zhu@intel.com> In-Reply-To: <1548293433-25085-1-git-send-email-shuaix.zhu@intel.com> From: Rami Rosen Date: Thu, 24 Jan 2019 03:54:06 +0200 Message-ID: To: "zhu,shuai" Cc: dts@dpdk.org Content-Type: multipart/alternative; boundary="000000000000b8767605802a7cd3" Subject: Re: [dts] [PATCH V1] tests/ipfrag:Modify the way to get the core. X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jan 2019 01:54:13 -0000 --000000000000b8767605802a7cd3 Content-Type: text/plain; charset="UTF-8" Hi, Zhu, > Some platforms have a core number less than a fixed value. Thanks for this patch. You are right, obviously there are platforms with other combinations than "2S/2C/2T", and actually I myself run DTS on diifferent platforms than this and had some issues related to it with various DTS test modules. I have a question, though,if I may: On which platform ( i mean which combination of socket/core/thread in that platform) did the solution of using cores = self.dut.get_core_listst("all") instead of the hard coded "2S/2C/2T" worked for you for this ipfrag Test Module? And a general question to DTS developers/maintainer: all the DTS test suites use hard coded values for the S/C/T combination. And obviously this will fail on certain platforms. Wouldn't it be reasonable to replace all these occurrences with self.dut.get_core_listst("all") ? Will self.dut.get_core_listst("all") always work, for any combination of socket/core/thread ? Will this work for 2S/4C/2T ? Regards, Rami Rosen --000000000000b8767605802a7cd3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi, Zhu,

> Some platforms have a core nu= mber less than a fixed value.

Thanks for t= his patch. You are right, obviously there are platforms with other combinat= ions than=C2=A0
"2S/2C/2T", and actually I myself = run DTS on diifferent platforms than this and had some issues related to it= with various DTS test modules.

=C2=A0I have a question, though,if I may:=C2=A0=
On which platform = ( i mean which combination of socket/core/thread in that platform) did the = solution of using cores =3D s= elf.dut.get_core_listst("= ;all") instead of the=C2=A0 hard coded=C2=A0"2S/2C/2T" worked=C2=A0=C2= =A0for you for this ipfrag Test Module?=C2=A0

= And a general question to DTS develo= pers/maintainer:=C2=A0 all the DTS test suites use hard coded values for th= e S/C/T combination. And obviously this will fail on certain platforms. Wou= ldn't it be reasonable to replace all these occurrences with=C2=A0self.dut.get_core_listst("all") ? Will=C2=A0self.dut.get_core_listst("all") always work, for any comb= ination of socket/core/thread ? Will this work for 2S/4C/2T ?=C2=A0<= /div>

Regards,
Rami Rosen<= /span>
--000000000000b8767605802a7cd3--