From: Rami Rosen <ramirose@gmail.com>
To: Peng Yuan <yuan.peng@intel.com>
Cc: dts@dpdk.org
Subject: Re: [dts] [PATCH] test_plans: modify the operation to up vf port
Date: Wed, 9 Jan 2019 21:16:24 +0200 [thread overview]
Message-ID: <CAHLOa7RaYcLa0LVi3pifkc-TbDyOxXkMf9OtNC+BYG=DkTqUXA@mail.gmail.com> (raw)
In-Reply-To: <1547025702-22648-1-git-send-email-yuan.peng@intel.com>
[-- Attachment #1: Type: text/plain, Size: 303 bytes --]
Hi,
Nack about this patch.
By default, network interfaX11Dai-Nces in Linux are created starting from
eth0, then eht1, and so on.
So "ifconfig eth up" or "ethtool - S" is not realistic.
So I would suggest to consider changing eth to eth0 in all occurences of
eth in that patch.
Regards,
Rami Rosen
>
[-- Attachment #2: Type: text/html, Size: 776 bytes --]
prev parent reply other threads:[~2019-01-09 19:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-09 9:21 Peng Yuan
2019-01-09 19:16 ` Rami Rosen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHLOa7RaYcLa0LVi3pifkc-TbDyOxXkMf9OtNC+BYG=DkTqUXA@mail.gmail.com' \
--to=ramirose@gmail.com \
--cc=dts@dpdk.org \
--cc=yuan.peng@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).