test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH] test_plans: modify the operation to up vf port
@ 2019-01-09  9:21 Peng Yuan
  2019-01-09 19:16 ` Rami Rosen
  0 siblings, 1 reply; 2+ messages in thread
From: Peng Yuan @ 2019-01-09  9:21 UTC (permalink / raw)
  To: dts; +Cc: Peng Yuan

Modify the operation to up vf port for ixgbe_vf_get_extra_queue_information_test_plan.rst

Signed-off-by: Peng Yuan <yuan.peng@intel.com>

diff --git a/test_plans/ixgbe_vf_get_extra_queue_information_test_plan.rst b/test_plans/ixgbe_vf_get_extra_queue_information_test_plan.rst
index aa94df2..6ef5be0 100644
--- a/test_plans/ixgbe_vf_get_extra_queue_information_test_plan.rst
+++ b/test_plans/ixgbe_vf_get_extra_queue_information_test_plan.rst
@@ -94,10 +94,9 @@ Test case 1: DPDK PF, kernel VF, enable DCB mode with TC=4
     testpmd> port config 0 dcb vt on 4 pfc off
     testpmd> port start 0
 
-2. check if VF port is linked. if vf port is down, reload the ixgbevf driver::
+2. check if VF port is linked. if vf port is down, up the port::
 
-    rmmod ixgbevf
-    modprobe ixgbevf
+    ifconfig eth up
 
    then you can see VF information in PF side::
 
@@ -106,7 +105,7 @@ Test case 1: DPDK PF, kernel VF, enable DCB mode with TC=4
 
 3. check VF's queue number::
 
-    ethtool -S ens3
+    ethtool -S eth
 
    there is 1 tx queue and 4 rx queues which equals TC number.
 
@@ -125,7 +124,7 @@ Test case 1: DPDK PF, kernel VF, enable DCB mode with TC=4
 
 5. check the packets with different User Priority mapping to TC::
 
-    ethtool -S ens3
+    ethtool -S eth
 
    check the NIC statistics to check the packets increasing of different rx queue.
    pkt1 to queue 0, pkt2 to queue 1, pkt3 to queue 2, pkt4 to queue 3,
@@ -136,9 +135,13 @@ Test case 2: DPDK PF, kernel VF, disable DCB mode
 
 1. start the testpmd on PF::
 
-    ./x86_64-native-linuxapp-gcc/app/testpmd -c 1ffff -n 4 -- -i --nb-cores=16 --rxq=2 --txq=2
+    ./x86_64-native-linuxapp-gcc/app/testpmd -c 1ffff -n 4 -- -i --rxq=2 --txq=2 --nb-cores=16
+
+2. check if VF port is linked. if vf port is down, up the port::
+
+    ifconfig eth up
 
-2. check if VF port is linked. if vf port is down, reload the ixgbevf driver::
+   if vf port is still down, reload the ixgbevf driver::
 
     rmmod ixgbevf
     modprobe ixgbevf
@@ -154,7 +157,7 @@ Test case 2: DPDK PF, kernel VF, disable DCB mode
 
 4. check VF's queue number::
 
-    ethtool -S ens3
+    ethtool -S eth
 
    there is 2 tx queues and 2 rx queues as default number.
 
@@ -166,7 +169,7 @@ Test case 2: DPDK PF, kernel VF, disable DCB mode
 5. check the NIC statistics to verify the different packets mapping to
    different queues according RSS rule::
 
-    ethtool -S ens3
+    ethtool -S eth
 
    send 100 pkt1 to VF, all the packets received by queue 0,
    then, send 100 pkt2 to VF, all the packets received by queue 1.
-- 
2.7.4

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH] test_plans: modify the operation to up vf port
  2019-01-09  9:21 [dts] [PATCH] test_plans: modify the operation to up vf port Peng Yuan
@ 2019-01-09 19:16 ` Rami Rosen
  0 siblings, 0 replies; 2+ messages in thread
From: Rami Rosen @ 2019-01-09 19:16 UTC (permalink / raw)
  To: Peng Yuan; +Cc: dts

[-- Attachment #1: Type: text/plain, Size: 303 bytes --]

Hi,
Nack about this patch.
By default, network interfaX11Dai-Nces in Linux are created starting from
eth0, then eht1, and so on.
So "ifconfig eth up" or "ethtool - S" is not realistic.

So I would suggest to consider changing eth to eth0 in all occurences of
eth in that patch.

Regards,
Rami Rosen


>

[-- Attachment #2: Type: text/html, Size: 776 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-01-09 19:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-09  9:21 [dts] [PATCH] test_plans: modify the operation to up vf port Peng Yuan
2019-01-09 19:16 ` Rami Rosen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).