From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ramirose@gmail.com>
Received: from mail-ed1-f68.google.com (mail-ed1-f68.google.com
 [209.85.208.68]) by dpdk.org (Postfix) with ESMTP id 4E4D11B495
 for <dts@dpdk.org>; Wed,  9 Jan 2019 20:16:34 +0100 (CET)
Received: by mail-ed1-f68.google.com with SMTP id b3so8282920ede.1
 for <dts@dpdk.org>; Wed, 09 Jan 2019 11:16:34 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to
 :cc; bh=4WMpcvivgFOWd5MNoWMD+YRQwvT3VnWNiha/Ro7WpEQ=;
 b=RS1J/O6qxUch/jPyRsRr8/uVM6klwNsilkmmMZ8GWA0og72Z5qZwex+Wf5tE5h6nsU
 lx8e6Cirn/ThFBdW8Z2EUw9sSABlsiKKO5xSxcLx53xaI4zUbbQ1zbW7HjsH7Hx4290u
 NKjibSZlWfcBpGQKXZbiDkC7dJRb8d02B1aih7aff686NFrfX5ztl0B1qndhfz6XOGl3
 JdqrlJdhXA2mvWPpqugzan/eYvLuTyRM+RsMVRrhPnaYOk9sOcQ/9L6SKx8VK6a4+GoA
 MuDGKgIaQwRRObG+4NY5CwNWlJ6j2w3Hxzitt2Ysc9q7ypTZYpbzj2ZMomF56HzD4L+f
 H4Hg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=4WMpcvivgFOWd5MNoWMD+YRQwvT3VnWNiha/Ro7WpEQ=;
 b=MkdMqlbG805qnYkwmAS9HHqpw6KwOkI2T2MNI3sv6epl2kisKuljLqHEmWoNhZm0aQ
 mMaxS824EYA+/0o+f4OnuyPT+QuEq2EsZL+fNd7XEEtTEx8OARqghuNhqkaBcJfSOuVV
 OddDGNLIw9KTAETAw2j59W+DbBPK1IRbB7Owdwgsym/kiN1acXrjRBpejX6W8LaX1SuR
 6AIRTI01ceGPH/T05b0xjpRv5d6eW9mtjYdcxoWkt0gfEIP7gAnFXWG37TRUQkbHnpI7
 SIihrfRllMOUDB5s1ZZdorpNeKqRNAshRc2YprC90i9zlHfO3WljgExb3q5D16gd9w/j
 dArg==
X-Gm-Message-State: AJcUukd49l51cjlUo1hjJww7k1woQqJ5oqE1qdFaOta74PkXo4pp1VWf
 T/nt00/pL4Qpb5E2ZZ6ZQmCVbxoOzQNbgrVHwcc=
X-Google-Smtp-Source: ALg8bN59tiPfM1P3eg6LeO5YCO809uy54BBwPh85hp38YGeRDQ6dHqjuzR8cCFWR0MEKazO+eiObmWw4/cAT2DfvwYo=
X-Received: by 2002:a50:b667:: with SMTP id c36mr7340549ede.190.1547061393893; 
 Wed, 09 Jan 2019 11:16:33 -0800 (PST)
MIME-Version: 1.0
References: <1547025702-22648-1-git-send-email-yuan.peng@intel.com>
In-Reply-To: <1547025702-22648-1-git-send-email-yuan.peng@intel.com>
From: Rami Rosen <ramirose@gmail.com>
Date: Wed, 9 Jan 2019 21:16:24 +0200
Message-ID: <CAHLOa7RaYcLa0LVi3pifkc-TbDyOxXkMf9OtNC+BYG=DkTqUXA@mail.gmail.com>
To: Peng Yuan <yuan.peng@intel.com>
Cc: dts@dpdk.org
Content-Type: multipart/alternative; boundary="000000000000d42e30057f0b4c09"
Subject: Re: [dts] [PATCH] test_plans: modify the operation to up vf port
X-BeenThere: dts@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: test suite reviews and discussions <dts.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dts>,
 <mailto:dts-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dts/>
List-Post: <mailto:dts@dpdk.org>
List-Help: <mailto:dts-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dts>,
 <mailto:dts-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 09 Jan 2019 19:16:34 -0000

--000000000000d42e30057f0b4c09
Content-Type: text/plain; charset="UTF-8"

Hi,
Nack about this patch.
By default, network interfaX11Dai-Nces in Linux are created starting from
eth0, then eht1, and so on.
So "ifconfig eth up" or "ethtool - S" is not realistic.

So I would suggest to consider changing eth to eth0 in all occurences of
eth in that patch.

Regards,
Rami Rosen


>

--000000000000d42e30057f0b4c09
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"auto">Hi,<div dir=3D"auto">Nack about this patch.</div><div dir=
=3D"auto">By default, network interfa<span style=3D"font-family:calibri,san=
s-serif;font-size:14px">X11Dai-N</span>ces in Linux are created starting fr=
om eth0, then eht1, and so on.</div><div dir=3D"auto">So &quot;ifconfig eth=
 up&quot; or &quot;ethtool - S&quot; is not realistic.</div><div dir=3D"aut=
o"><br></div><div dir=3D"auto">So I would suggest to consider changing eth =
to eth0 in all occurences of eth in that patch.</div><div dir=3D"auto"><br>=
</div><div dir=3D"auto">Regards,</div><div dir=3D"auto">Rami Rosen</div><di=
v dir=3D"auto"><br></div><div class=3D"gmail_quote" dir=3D"auto"><blockquot=
e class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc sol=
id;padding-left:1ex">
<br>
</blockquote></div></div>

--000000000000d42e30057f0b4c09--