test suite reviews and discussions
 help / color / mirror / Atom feed
From: Rami Rosen <ramirose@gmail.com>
To: "zhang,yan" <yanx.a.zhang@intel.com>
Cc: dts@dpdk.org
Subject: Re: [dts] [PATCH V1] tests/vf_jumboframe:disable promise mode to forbid misc packets
Date: Wed, 17 Apr 2019 18:26:20 +0300	[thread overview]
Message-ID: <CAHLOa7RpU75V9h3DwAtzE+xrL9-K-gsHy5mHMYNpRDuCmW=4JA@mail.gmail.com> (raw)
In-Reply-To: <1555493234-8281-1-git-send-email-yanx.a.zhang@intel.com>

[-- Attachment #1: Type: text/plain, Size: 255 bytes --]

Hi Zhang,
Two minor comments about the patch subject and the commit message:

disable promise mode-> disable promisc mode

 so use command "set promisc all off" to forbidden them->
 so use command "set promisc all off" to forbid them

Regards,
Rami Rosen

[-- Attachment #2: Type: text/html, Size: 660 bytes --]

      reply	other threads:[~2019-04-17 15:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-17  9:27 zhang,yan
2019-04-17 15:26 ` Rami Rosen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHLOa7RpU75V9h3DwAtzE+xrL9-K-gsHy5mHMYNpRDuCmW=4JA@mail.gmail.com' \
    --to=ramirose@gmail.com \
    --cc=dts@dpdk.org \
    --cc=yanx.a.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).