From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) by dpdk.org (Postfix) with ESMTP id F024D1B465 for ; Wed, 9 Jan 2019 14:06:35 +0100 (CET) Received: by mail-ed1-f49.google.com with SMTP id y20so7226142edw.9 for ; Wed, 09 Jan 2019 05:06:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CBwEzdLqPwAYvoWC/LmZ8vrMK/8NQd7fpNfHYdQSc2M=; b=iPtEZZLn/rjKF+Aww4nNJI3K4pjo2clKNAaK00UqOYKmSPj6ry9mIOi4O7bGar80Ar YVAUYMNHabxepl+8A2/hQG58K16LcmLz2QsJ+tUZGh4HQIe5O+x3B9Q97Z08VO183k/b n350gXGjw8ud2D2t2rELvwLdn0kmlC52QfBq3ZFECOoViWZcUDJP9cGykU2gtZxB1mAA KQugquJlnNzPzBaqSO+a0yrTFa+exwqEMmoCrhu39nuQdc368CTnNpxiefnfJd28sGl2 V6pDFFhhlECCE3gLqfxjTlfy8MNBvu/VNTaR/PAlD7hIxSbCIuNPA4dkcR4OlvfNUUyi XkMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CBwEzdLqPwAYvoWC/LmZ8vrMK/8NQd7fpNfHYdQSc2M=; b=hGYs2nxOAUETogA1iffUNSB7r97pOnIq6PHx9pGZyNqMn74FBDpnksBO98GfegyYNM XmFn0A1eVPpxq9Arf152/AruJxN8/v5VBPBmC7HCcdx+8RH6qbsF0DZgziDdU6QJ9LTp bJ6Z05/EUoJVkBEotHz77P/Zi1TBqxJJNLzyvQDf0DPUf/w8zLBZcOzBznKCk+UGLze0 oVPQm/R6j/Fg4UZ5KXXibTGX1XbrAn4tPqJqjbu4+nFN0cbsTJmP/zUBks0boro7za+X Zedy3GKZsPqTz7SIpExWkX++lzzx1oNQpTPschZjV8qz31Va8bRNMuS0G4cG0ZnE+81F dMCw== X-Gm-Message-State: AJcUukeQuOPHwzvbFzpoCHDLghlNoWlmtW2f0CLmWUWeKZWoy77Ayde/ 4Upxry4TAR8OALmbKpyUOPY8X712pyqHKEuUG1c= X-Google-Smtp-Source: ALg8bN7iHxTvTBLeQ4q7V5MdwvBLCT9CpAfB3u1rEGXv/VWcZyWSJRMHaWIEY0DAJ8ib21YkTfTyQ84J+UEUbPEC8Yw= X-Received: by 2002:a50:b667:: with SMTP id c36mr6171233ede.190.1547039195517; Wed, 09 Jan 2019 05:06:35 -0800 (PST) MIME-Version: 1.0 References: <1547028131-22824-1-git-send-email-yuan.peng@intel.com> In-Reply-To: <1547028131-22824-1-git-send-email-yuan.peng@intel.com> From: Rami Rosen Date: Wed, 9 Jan 2019 15:06:24 +0200 Message-ID: To: Peng Yuan Cc: dts@dpdk.org Content-Type: multipart/alternative; boundary="000000000000b3d892057f0621d8" Subject: Re: [dts] [PATCH] tests: correct spelling errors X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jan 2019 13:06:36 -0000 --000000000000b3d892057f0621d8 Content-Type: text/plain; charset="UTF-8" Acked-by: Rami Rosen On Wed, Jan 9, 2019 at 11:58 AM Peng Yuan wrote: > Correct spelling errors of TestSuite_vmdq.py. > > Signed-off-by: Peng Yuan > > diff --git a/tests/TestSuite_vmdq.py b/tests/TestSuite_vmdq.py > index 10cb8e6..796a214 100644 > --- a/tests/TestSuite_vmdq.py > +++ b/tests/TestSuite_vmdq.py > @@ -6,7 +6,6 @@ DPDK Test suite. > Tests for vmdq. > > """ > - > import utils > import re > from etgen import IxiaPacketGenerator > @@ -30,7 +29,6 @@ class TestVmdq(TestCase, IxiaPacketGenerator): > """ > Run at the start of each test suite. > """ > - > self.tester.extend_external_packet_generator(TestVmdq, self) > > self.dut.send_expect("sed -i > 's/CONFIG_RTE_MAX_QUEUES_PER_PORT=256/CONFIG_RTE_MAX_QUEUES_PER_PORT=1024/' > ./config/common_base", "# ", 5) > @@ -53,12 +51,10 @@ class TestVmdq(TestCase, IxiaPacketGenerator): > out = self.dut.send_expect("make -C examples/vmdq", "#", 10) > self.verify("Error" not in out, "Compilation error") > > - > def validateApproxEqual(self, lines): > """ > Check that all the rx queue stats are within a 30% range. > """ > - > minimum = 1000000 > maximun = 0 > > @@ -85,7 +81,6 @@ class TestVmdq(TestCase, IxiaPacketGenerator): > MAX queues is 128 > queues/pools = 128/npools > """ > - > self.current_frame_size = self.default_framesize > > self.dut_ports = self.dut.get_ports(self.nic) > @@ -130,8 +125,8 @@ class TestVmdq(TestCase, IxiaPacketGenerator): > > def test_perf_vmdq_64pools_queues(self): > """ > - This function call " Npools_128queues" with differen number > - of pools. Details see below. if not sure, set it as 8 pools. > + This function call "Npools_128queues" with different number > + of pools. Details see below. If not sure, set it as 8 pools. > """ > if self.nic in ("niantic", "springfountain"): > self.Npools_128queues(64) > @@ -144,9 +139,8 @@ class TestVmdq(TestCase, IxiaPacketGenerator): > > def test_perf_vmdq_performance(self): > """ > - Try different configuration and different packe size > + Try different configuration and different packet size > """ > - > self.tester.get_interface( > self.tester.get_local_port(self.dut_ports[0])) > > @@ -240,7 +234,6 @@ class TestVmdq(TestCase, IxiaPacketGenerator): > """ > Change Ixia configuration > """ > - > self.add_tcl_cmd("vlan config -mode vIncrement") > self.add_tcl_cmd("vlan config -step 1") > self.add_tcl_cmd("vlan config -repeat %d" % self.vlan_repeat) > @@ -250,7 +243,7 @@ class TestVmdq(TestCase, IxiaPacketGenerator): > > def ether(self, port, src, dst, type): > """ > - Configure Ether protocal. > + Configure Ether protocol. > """ > self.add_tcl_cmd("protocol config -ethernetType ethernetII") > self.add_tcl_cmd('stream config -sa "%s"' % > self.macToTclFormat(src)) > @@ -258,5 +251,3 @@ class TestVmdq(TestCase, IxiaPacketGenerator): > self.add_tcl_cmd('stream config -daRepeatCounter increment') > self.add_tcl_cmd('stream config -daStep 1') > self.add_tcl_cmd('stream config -numDA %d' % self.da_repeat) > - > - > -- > 2.7.4 > > -- regards, Rami Rosen --000000000000b3d892057f0621d8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Acked-by: Rami Rosen <ramirose@gmail.com>

On Wed, Jan 9, 2019 at 11:58 AM Peng Y= uan <yuan.peng@intel.com> = wrote:
Correct s= pelling errors of TestSuite_vmdq.py.

Signed-off-by: Peng Yuan <yuan.peng@intel.com>

diff --git a/tests/TestSuite_vmdq.py b/tests/TestSuite_vmdq.py
index 10cb8e6..796a214 100644
--- a/tests/TestSuite_vmdq.py
+++ b/tests/TestSuite_vmdq.py
@@ -6,7 +6,6 @@ DPDK Test suite.
=C2=A0Tests for vmdq.

=C2=A0"""
-
=C2=A0import utils
=C2=A0import re
=C2=A0from etgen import IxiaPacketGenerator
@@ -30,7 +29,6 @@ class TestVmdq(TestCase, IxiaPacketGenerator):
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"""
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Run at the start of each test suite.
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"""
-
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.tester.extend_external_packet_genera= tor(TestVmdq, self)

=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.dut.send_expect("sed -i 's/= CONFIG_RTE_MAX_QUEUES_PER_PORT=3D256/CONFIG_RTE_MAX_QUEUES_PER_PORT=3D1024/= ' ./config/common_base", "# ", 5)
@@ -53,12 +51,10 @@ class TestVmdq(TestCase, IxiaPacketGenerator):
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0out =3D self.dut.send_expect("make -= C examples/vmdq", "#", 10)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.verify("Error" not in out,= "Compilation error")

-
=C2=A0 =C2=A0 =C2=A0def validateApproxEqual(self, lines):
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"""
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Check that all the rx queue stats are wit= hin a 30% range.
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"""
-
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0minimum =3D 1000000
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0maximun =3D 0

@@ -85,7 +81,6 @@ class TestVmdq(TestCase, IxiaPacketGenerator):
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0MAX queues is 128
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0queues/pools =3D 128/npools
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"""
-
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.current_frame_size =3D self.default_= framesize

=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.dut_ports =3D self.dut.get_ports(sel= f.nic)
@@ -130,8 +125,8 @@ class TestVmdq(TestCase, IxiaPacketGenerator):

=C2=A0 =C2=A0 =C2=A0def test_perf_vmdq_64pools_queues(self):
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"""
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 This function call " Npools_128queues&quo= t; with differen number
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 of pools. Details see below. if not sure, set = it as 8 pools.
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 This function call "Npools_128queues"= ; with different number
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 of pools. Details see below. If not sure, set = it as 8 pools.
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"""
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if self.nic in ("niantic", &quo= t;springfountain"):
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.Npools_128queues(64) @@ -144,9 +139,8 @@ class TestVmdq(TestCase, IxiaPacketGenerator):

=C2=A0 =C2=A0 =C2=A0def test_perf_vmdq_performance(self):
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"""
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 Try=C2=A0 different configuration and differen= t packe size
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 Try different configuration and different pack= et size
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"""
-
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.tester.get_interface(
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.tester.get_local_port(= self.dut_ports[0]))

@@ -240,7 +234,6 @@ class TestVmdq(TestCase, IxiaPacketGenerator):
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"""
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Change Ixia configuration
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"""
-
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.add_tcl_cmd("vlan config -mode = vIncrement")
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.add_tcl_cmd("vlan config -step = 1")
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.add_tcl_cmd("vlan config -repea= t %d" % self.vlan_repeat)
@@ -250,7 +243,7 @@ class TestVmdq(TestCase, IxiaPacketGenerator):

=C2=A0 =C2=A0 =C2=A0def ether(self, port, src, dst, type):
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"""
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 Configure Ether protocal.
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 Configure Ether protocol.
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"""
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.add_tcl_cmd("protocol config -e= thernetType ethernetII")
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.add_tcl_cmd('stream config -sa &= quot;%s"' % self.macToTclFormat(src))
@@ -258,5 +251,3 @@ class TestVmdq(TestCase, IxiaPacketGenerator):
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.add_tcl_cmd('stream config -daRe= peatCounter increment')
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.add_tcl_cmd('stream config -daSt= ep 1')
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.add_tcl_cmd('stream config -numD= A %d' % self.da_repeat)
-
-
--
2.7.4



--
regards,
Rami Rosen
--000000000000b3d892057f0621d8--