From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AB8D4A0C56; Thu, 12 Aug 2021 18:29:54 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 986614014D; Thu, 12 Aug 2021 18:29:54 +0200 (CEST) Received: from mail-ot1-f51.google.com (mail-ot1-f51.google.com [209.85.210.51]) by mails.dpdk.org (Postfix) with ESMTP id B7F5440042 for ; Thu, 12 Aug 2021 18:29:52 +0200 (CEST) Received: by mail-ot1-f51.google.com with SMTP id a7-20020a9d5c870000b029050333abe08aso8378100oti.13 for ; Thu, 12 Aug 2021 09:29:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=lc9L+pY2i80ppKJf6WQ6XA2QCOH0fDXjRWyyZV+DDaI=; b=SGPNfS6j9ZPIrRp+IcmdF8O+deqD4qrJ5ulWZxzHFANOROmL46mGSPa7xsh6ACKc8n 37zmoQi14jMHa8iy5N2ygiWqp0KhFRKKdrxk5liDiE7MP8TPaHc3tdLNmiI2cQGtsro3 ZMZ1TmdgE1pigPx68/XwufkA9M1NBXMwoyUOc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=lc9L+pY2i80ppKJf6WQ6XA2QCOH0fDXjRWyyZV+DDaI=; b=Mj4ZHo+Sra44hT2wV3ayEYOawe+UePbz0IPiMXntw/oYLNsQLF1fKhUO1g8DonJ9NX l8A+Aq/XWJ3IajYPADDC8Ha0wN145cVeQbY3mUoPO96kudAyLykF0H0Xn/oUkReHHGT9 xWr6Yh96GsTBb3ObCtIg4tkJD+IPL9KL/GeRac1HqPZGFwZOZk/8vL+hQq2sKH5w9NlU Rif9sJpIH7oZjukW01OjwJnN+bDGfzl+VVBZuEd7zPXZh1C4mZvil807dzhWcVMA9jlL 64hy83a38b/9dZ3XjGZcEgOFCRspH1hmSbWLrCKa0NLw9+7e8zmTnwQyRVfdn1/DcJHd vgvg== X-Gm-Message-State: AOAM533v1tfNJpyXq0SFlqbWACEgFkI17mmftPTFuPGvSFwqN6of8bPH tuRzllAxlBOgnopOJNceemug5BPNEUx+ym4aXAhNKfD/r9o7xQ== X-Google-Smtp-Source: ABdhPJz/Yj5m6gaa6Uv92f6CqWlBNw7l+oj3Z4eJZD0ZJI5DMbGA1jWe771lZcYTwKvIhnXT3LuxTCz88aPAWCxf+n8= X-Received: by 2002:a05:6830:44a8:: with SMTP id r40mr4077865otv.222.1628785791859; Thu, 12 Aug 2021 09:29:51 -0700 (PDT) MIME-Version: 1.0 References: <20210812162255.80127-1-ohilyard@iol.unh.edu> In-Reply-To: <20210812162255.80127-1-ohilyard@iol.unh.edu> From: Owen Hilyard Date: Thu, 12 Aug 2021 12:29:16 -0400 Message-ID: To: dts@dpdk.org Content-Type: multipart/alternative; boundary="0000000000008a167205c95f3ee3" Subject: Re: [dts] [PATCH] ci/pylama: Added pylama config file X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" --0000000000008a167205c95f3ee3 Content-Type: text/plain; charset="UTF-8" This depends on the requirements file that I added when adding the other ci script. I want to make it as easy as possible to install everything needed for CI, which means all of it should go in one requirements file. Even with my removing many issues, this still has a lot of issues with the DTS codebase, 35126 issues to be exact. We may want to bring this back to the working group and discuss more, after fixing just the errors, since there is a manageable amount of those. On Thu, Aug 12, 2021 at 12:23 PM wrote: > From: Owen Hilyard > > I ended up turning off most of the formatting-releated checks due to > some minor conflicts with black (black allows lines > 80 characters for > instance). This produces a very substantial list of errors, some of > which may need to be simply disabled instead of being fixed due to > architectural reasons. > > Signed-off-by: Owen Hilyard > --- > ci/requirements.txt | 5 ++++- > pylama.ini | 5 +++++ > 2 files changed, 9 insertions(+), 1 deletion(-) > create mode 100644 pylama.ini > > diff --git a/ci/requirements.txt b/ci/requirements.txt > index 0abd6716..e19e540e 100644 > --- a/ci/requirements.txt > +++ b/ci/requirements.txt > @@ -29,4 +29,7 @@ > # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE > # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > > -argparse==1.4.0 > \ No newline at end of file > +argparse==1.4.0 > +pylama > +pylama_pylint > +black > \ No newline at end of file > diff --git a/pylama.ini b/pylama.ini > new file mode 100644 > index 00000000..aef408c0 > --- /dev/null > +++ b/pylama.ini > @@ -0,0 +1,5 @@ > +[pylama] > +format = pylint > +linters = pep8,pycodestyle,pylint > +ignore = F0401,C0111,E731,E266,E501,E203 > + > -- > 2.30.2 > > --0000000000008a167205c95f3ee3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
This depends on the requirements file that I added when ad= ding the other ci script. I want to make it as easy as=C2=A0possible to ins= tall everything needed for CI, which means all of it should go in one requi= rements file. Even with my removing many issues, this still has a lot of is= sues with the DTS codebase, 35126 issues to be exact. We may want to bring = this back to the working group and discuss more, after fixing just the erro= rs, since there is a manageable=C2=A0amount of those.

On Thu, Aug 12, 2021= at 12:23 PM <ohilyard@iol.unh.e= du> wrote:
ohilyard@iol.unh.edu>

I ended up turning off most of the formatting-releated checks due to
some minor conflicts with black (black allows lines > 80 characters for<= br> instance). This produces a very substantial list of errors, some of
which may need to be simply disabled instead of being fixed due to
architectural reasons.

Signed-off-by: Owen Hilyard <ohilyard@iol.unh.edu>
---
=C2=A0ci/requirements.txt | 5 ++++-
=C2=A0pylama.ini=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 5 +++++
=C2=A02 files changed, 9 insertions(+), 1 deletion(-)
=C2=A0create mode 100644 pylama.ini

diff --git a/ci/requirements.txt b/ci/requirements.txt
index 0abd6716..e19e540e 100644
--- a/ci/requirements.txt
+++ b/ci/requirements.txt
@@ -29,4 +29,7 @@
=C2=A0# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE U= SE
=C2=A0# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE= .

-argparse=3D=3D1.4.0
\ No newline at end of file
+argparse=3D=3D1.4.0
+pylama
+pylama_pylint
+black
\ No newline at end of file
diff --git a/pylama.ini b/pylama.ini
new file mode 100644
index 00000000..aef408c0
--- /dev/null
+++ b/pylama.ini
@@ -0,0 +1,5 @@
+[pylama]
+format =3D pylint
+linters =3D pep8,pycodestyle,pylint
+ignore =3D F0401,C0111,E731,E266,E501,E203
+
--
2.30.2

--0000000000008a167205c95f3ee3--