From: Owen Hilyard <ohilyard@iol.unh.edu>
To: "Juraj Linkeš" <juraj.linkes@pantheon.tech>
Cc: "dts@dpdk.org" <dts@dpdk.org>,
"lijuan.tu@intel.com" <lijuan.tu@intel.com>
Subject: Re: [PATCH v2 2/2] update files depending on tests/util
Date: Wed, 13 Apr 2022 08:50:11 -0400 [thread overview]
Message-ID: <CAHx6DYA_11EpEwyFOyX9m1x8oRnmCQCx5YvK9JFAQPi-yWMMfw@mail.gmail.com> (raw)
In-Reply-To: <62c2c46af37445c7b216cf1972d1cb20@pantheon.tech>
[-- Attachment #1: Type: text/plain, Size: 778 bytes --]
Yes, that is a result of the automatic refactoring by Pycharm. I'll clean
that up when I resubmit.
On Wed, Apr 13, 2022 at 3:28 AM Juraj Linkeš <juraj.linkes@pantheon.tech>
wrote:
> > diff --git a/framework/dut.py b/framework/dut.py index a2a93734..d6b8d34a
> > 100644
> > --- a/framework/dut.py
> > +++ b/framework/dut.py
> > @@ -46,7 +46,7 @@ from .settings import LOG_NAME_SEP, NICS from
> > .ssh_connection import SSHConnection from .test_result import
> ResultTable
> > from .utils import RED, remove_old_rsa_key -from .virt_resource import
> > VirtResource
> > +from framework.virt_resource import VirtResource
> >
>
> A minor point, this is an unneccesary change that violates the current
> convention. Is this a result of automated tools?
>
>
[-- Attachment #2: Type: text/html, Size: 1068 bytes --]
next prev parent reply other threads:[~2022-04-13 12:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-11 17:55 [PATCH v2 1/2] framework: Move test-specific files to test directory ohilyard
2022-04-11 17:55 ` [PATCH v2 2/2] update files depending on tests/util ohilyard
2022-04-11 17:57 ` Owen Hilyard
2022-04-13 7:28 ` Juraj Linkeš
2022-04-13 12:50 ` Owen Hilyard [this message]
2022-04-13 7:25 ` [PATCH v2 1/2] framework: Move test-specific files to test directory Juraj Linkeš
2022-04-13 12:50 ` Owen Hilyard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHx6DYA_11EpEwyFOyX9m1x8oRnmCQCx5YvK9JFAQPi-yWMMfw@mail.gmail.com \
--to=ohilyard@iol.unh.edu \
--cc=dts@dpdk.org \
--cc=juraj.linkes@pantheon.tech \
--cc=lijuan.tu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).