From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 45342A050B; Wed, 13 Apr 2022 14:50:49 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0DA4B40694; Wed, 13 Apr 2022 14:50:49 +0200 (CEST) Received: from mail-oi1-f182.google.com (mail-oi1-f182.google.com [209.85.167.182]) by mails.dpdk.org (Postfix) with ESMTP id 6685E4068B for ; Wed, 13 Apr 2022 14:50:47 +0200 (CEST) Received: by mail-oi1-f182.google.com with SMTP id k10so1988653oia.0 for ; Wed, 13 Apr 2022 05:50:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EbVG7X5xEfnOkaUgd6jXbFwM2879yTXLuWwd5k4lgnI=; b=bgyCUN0fZqs/Wq02dz+1yaSiu0xR5u+8wvyTAsUwbjA9gecRW9oIOnCMvkeT2hrVVu tMO7WSWPAp3WeQfNoJt2bNGuwR2ZhGg7Gvb1u4sBoKUL8G+9uQu+pn93JKelqqNpewnI JxMK/KvAR1uJl4oRfXxdMIYAJE5OgqYZw5yj8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EbVG7X5xEfnOkaUgd6jXbFwM2879yTXLuWwd5k4lgnI=; b=zwh58LtF9OkaN7euPSKDRmRB8gnsdtbeSbpDnkaJCn9jHxHKt8i57F2MQp6bcCdmKV lWGSqqxjlVtrspqeEZT/3Dffzyu8gZt8Zm8GJBK9tva96Ikd3tDktB/27eN1mC8IYjJX 0QRmEVyAds0pAY/8CsWNTd+v5816W+4Me/PIv5Nq6ElclT/PQAO7p4XAmjBaikxq0x6D BFBEVw2TP/zuL7wu2jxPhBACr9/PrzV+AOwKnJl/kUKwdcTCu9KUaFsD0qilxWOqDQ/Z AE3zAp0rpjinCcMMR3uZTyqPyEFWjja59EDcKi81UcXPoVAKWwt339PVwe3c1H4H3V3m TR8w== X-Gm-Message-State: AOAM5314ikv/nyyOevWSD0IlkB0yoPvIVrKbhgZDqFClljeBiNmQ6Rxw nCKt9cC9wzXCqNqV/WSLTDwv0Sq1/Mm0qNy8qp3RuQ== X-Google-Smtp-Source: ABdhPJyWUj1r3lDzbT3XVd2PxtKdsLXz0im2U9RZukF55xCfwvVeLMTUPWRyxp8XvM7TS6gM4rRcaS3cORL+PgyNF8c= X-Received: by 2002:a05:6808:f90:b0:2f9:7b1d:1f50 with SMTP id o16-20020a0568080f9000b002f97b1d1f50mr3673423oiw.19.1649854246722; Wed, 13 Apr 2022 05:50:46 -0700 (PDT) MIME-Version: 1.0 References: <20220411175549.14680-1-ohilyard@iol.unh.edu> <20220411175549.14680-2-ohilyard@iol.unh.edu> <62c2c46af37445c7b216cf1972d1cb20@pantheon.tech> In-Reply-To: <62c2c46af37445c7b216cf1972d1cb20@pantheon.tech> From: Owen Hilyard Date: Wed, 13 Apr 2022 08:50:11 -0400 Message-ID: Subject: Re: [PATCH v2 2/2] update files depending on tests/util To: =?UTF-8?Q?Juraj_Linke=C5=A1?= Cc: "dts@dpdk.org" , "lijuan.tu@intel.com" Content-Type: multipart/alternative; boundary="0000000000004eb1e005dc88a0d1" X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org --0000000000004eb1e005dc88a0d1 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Yes, that is a result of the automatic refactoring by Pycharm. I'll clean that up when I resubmit. On Wed, Apr 13, 2022 at 3:28 AM Juraj Linke=C5=A1 wrote: > > diff --git a/framework/dut.py b/framework/dut.py index a2a93734..d6b8d3= 4a > > 100644 > > --- a/framework/dut.py > > +++ b/framework/dut.py > > @@ -46,7 +46,7 @@ from .settings import LOG_NAME_SEP, NICS from > > .ssh_connection import SSHConnection from .test_result import > ResultTable > > from .utils import RED, remove_old_rsa_key -from .virt_resource import > > VirtResource > > +from framework.virt_resource import VirtResource > > > > A minor point, this is an unneccesary change that violates the current > convention. Is this a result of automated tools? > > --0000000000004eb1e005dc88a0d1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Yes, that is a result of the automatic refactoring by Pych= arm. I'll clean that up when I resubmit.=C2=A0

On Wed, Apr 13, 2022 at 3= :28 AM Juraj Linke=C5=A1 <juraj.linkes@pantheon.tech> wrote:
> diff --git a/framew= ork/dut.py b/framework/dut.py index a2a93734..d6b8d34a
> 100644
> --- a/framework/dut.py
> +++ b/framework/dut.py
> @@ -46,7 +46,7 @@ from .settings import LOG_NAME_SEP, NICS=C2=A0 from<= br> > .ssh_connection import SSHConnection=C2=A0 from .test_result import Re= sultTable
> from .utils import RED, remove_old_rsa_key -from .virt_resource import=
> VirtResource
> +from framework.virt_resource import VirtResource
>

A minor point, this is an unneccesary change that violates the current conv= ention. Is this a result of automated tools?

--0000000000004eb1e005dc88a0d1--