test suite reviews and discussions
 help / color / mirror / Atom feed
From: Owen Hilyard <ohilyard@iol.unh.edu>
To: DongJunX <junx.dong@intel.com>, "Tu, Lijuan" <lijuan.tu@intel.com>
Cc: qinx.sun@intel.com, "Ling, WeiX" <weix.ling@intel.com>,
	yanx.xia@intel.com, yux.jiang@intel.com, zhiminx.huang@intel.com,
	 "Xu, HailinX" <hailinx.xu@intel.com>,
	songx.jiale@intel.com, dts@dpdk.org
Subject: Re: [dts] [PATCH V1 3/4] framework/*: removed makefile from framework
Date: Wed, 12 Jan 2022 10:28:42 -0500	[thread overview]
Message-ID: <CAHx6DYAyo9C3tRDBWe_mmFVma5uEOxAMR7dX7QbDU7+D7WaijA@mail.gmail.com> (raw)
In-Reply-To: <20211117085444.2254-3-junx.dong@intel.com>

[-- Attachment #1: Type: text/plain, Size: 757 bytes --]

>
> -        build_type = load_global_setting(HOST_BUILD_TYPE_SETTING)
> -        set_build_options = getattr(self, 'set_build_options_%s' %
> (build_type))
> +        set_build_options = getattr(self, 'set_build_options_meson')
>          set_build_options(config_parms, config_file)
>

It seems like this could just be:

set_build_options_meson(config_parms, config_file)

That avoids using reflection to get the function and is much easer to read
in my opinion

 build_install_dpdk = getattr(self, 'build_install_dpdk_%s_meson' %
> self.get_os_type())


While changes are being made here, could you convert this to use a chain of
if statements?

 build_dpdk_apps = getattr(self, 'build_dpdk_apps_%s_meson' %
> self.get_os_type())


Same as the last one.

[-- Attachment #2: Type: text/html, Size: 1419 bytes --]

  reply	other threads:[~2022-01-12 15:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-17  8:54 [dts] [PATCH V1 1/4] executions/execution*: removed makefile from configure file DongJunX
2021-11-17  8:54 ` [dts] [PATCH V1 2/4] doc/dts_gsg: removed makefile from user guide document DongJunX
2022-01-12 15:16   ` Owen Hilyard
2021-11-17  8:54 ` [dts] [PATCH V1 3/4] framework/*: removed makefile from framework DongJunX
2022-01-12 15:28   ` Owen Hilyard [this message]
2021-11-17  8:54 ` [dts] [PATCH V1 4/4] tests/*: removed makefile from test suite DongJunX
2021-11-18  8:23   ` David Marchand
2022-01-12 15:36     ` Owen Hilyard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHx6DYAyo9C3tRDBWe_mmFVma5uEOxAMR7dX7QbDU7+D7WaijA@mail.gmail.com \
    --to=ohilyard@iol.unh.edu \
    --cc=dts@dpdk.org \
    --cc=hailinx.xu@intel.com \
    --cc=junx.dong@intel.com \
    --cc=lijuan.tu@intel.com \
    --cc=qinx.sun@intel.com \
    --cc=songx.jiale@intel.com \
    --cc=weix.ling@intel.com \
    --cc=yanx.xia@intel.com \
    --cc=yux.jiang@intel.com \
    --cc=zhiminx.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).